Skip to contentSkip to conversation

Added #include of module.h to s3c_adc_battery.c

PATCH In review Ian 4 participants 5 messages Aug 18, 2011 – Aug 19, 2011

lore
Share & tools
lore

Ian

author
#0 lore raw

PATCH 1/1 Added #include of module.h to s3c_adc_battery.c

s3c_adc_battery.c will not compile without moule.h as it contains the definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.

Signed-off-by Ian Lartey <[email protected]>
---
 drivers/power/s3c_adc_battery.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/power/s3c_adc_battery.c +1 -0
index a675e31..20770ba 100644
@@ -9,6 +9,7 @@
  *
  */
 
+#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <linux/power_supply.h>
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 2 lines · On Thursday 18 August 2011 13:14:09 Ian wrote:

s3c_adc_battery.c will not compile without moule.h as it contains the definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.

I've already sent pretty same patch a ~week ago, here it is:
https://patchwork.kernel.org/patch/1061302/

Regards
Vasily

Quoted 18 lines
Signed-off-by Ian Lartey <[email protected]>
---
 drivers/power/s3c_adc_battery.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/drivers/power/s3c_adc_battery.c index a675e31..20770ba 100644

drivers/power/s3c_adc_battery.c +1 -0
@@ -9,6 +9,7 @@
  *
  */
 
+#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <linux/power_supply.h>
author
#2 lore raw
Quoted 6 lines · Vasily Khoruzhick
Quoted 2 lines · On Thursday 18 August 2011 13:14:09 Ian wrote:

s3c_adc_battery.c will not compile without moule.h as it contains the definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.

I've already sent pretty same patch a ~week ago, here it is:
https://patchwork.kernel.org/patch/1061302/

Ah, apologies - please disregard this patch then.

Regards
Ian

Quoted 22 lines

Regards
Vasily

Quoted 18 lines
Signed-off-by Ian Lartey <[email protected]>
---
 drivers/power/s3c_adc_battery.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/drivers/power/s3c_adc_battery.c index a675e31..20770ba 100644

drivers/power/s3c_adc_battery.c +1 -0
@@ -9,6 +9,7 @@
  *
  */
 
+#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <linux/power_supply.h>
#3 lore raw
Quoted 9 lines · Ian
Quoted 6 lines · Vasily Khoruzhick
Quoted 2 lines · On Thursday 18 August 2011 13:14:09 Ian wrote:

s3c_adc_battery.c will not compile without moule.h as it contains the definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.

I've already sent pretty same patch a ~week ago, here it is:
https://patchwork.kernel.org/patch/1061302/

Ah, apologies - please disregard this patch then.

Hrm, Anton's been pretty quiet recently - might be an idea to start CCing akpm on this stuff?

#4 lore raw
Quoted 6 lines · Mark Brown
Quoted 5 lines · Ian
Quoted 4 lines · Vasily Khoruzhick
Quoted 2 lines · On Thursday 18 August 2011 13:14:09 Ian wrote:

s3c_adc_battery.c will not compile without moule.h as it contains the definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

I've already sent pretty same patch a ~week ago, here it is:
https://patchwork.kernel.org/patch/1061302/

Ah, apologies - please disregard this patch then.

Hrm, Anton's been pretty quiet recently - might be an idea to start CCing akpm on this stuff?

Don't panic. :-) I'm still here, been on a vacation (and was trying to not read emails :-), then was catching up with my other duties.

Ian, I added your Signed-off-by line to the Vasily's patch, for the credits.

Thank you!

Signature · 2 lines
Anton Vorontsov
Email: [email protected]