Skip to contentSkip to conversation

ARM: mach-davinci: Select PHYLIB for ARCH_DAVINCI_DM644x

PATCH In review Axel Lin 2 participants 3 messages Aug 21, 2011 – Sep 1, 2011

Subsystems (3)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ARM: mach-davinci: Select PHYLIB for ARCH_DAVINCI_DM644x

We call phy_register_fixup_for_uid in davinci_evm_init, thus we need select PHYLIB to fix below build error: (with "make davinci_all_defconfig")

LD .tmp_vmlinux1
arch/arm/mach-davinci/built-in.o: In function `davinci_phy_fixup':
pm.c:(.text+0x35b8): undefined reference to mdiobus_read' pm.c:(.text+0x35d4): undefined reference to mdiobus_write' arch/arm/mach-davinci/built-in.o: In function `davinci_evm_init':
pm.c:(.init.text+0x237c): undefined reference to `phy_register_fixup_for_uid'
make: *** [.tmp_vmlinux1] Error 1

---
 arch/arm/mach-davinci/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-davinci/Kconfig +1 -0
index c0deaca..029ec46b 100644
@@ -18,6 +18,7 @@ config ARCH_DAVINCI_DM644x
 	bool "DaVinci 644x based system"
 	select AINTC
 	select ARCH_DAVINCI_DMx
+	select PHYLIB
 
 config ARCH_DAVINCI_DM355
 	bool "DaVinci 355 based system"
Signature · 1 line
1.7.4.1
#1 lore raw

Hi Axel,

Quoted 2 lines · Axel Lin

We call phy_register_fixup_for_uid in davinci_evm_init, thus we need select PHYLIB to fix below build error: (with "make davinci_all_defconfig")

This shouldn't happen with davinci_all_defconfig as it selects PHYLIB (this doesn't undermine the need for a fix).

Quoted 19 lines

LD .tmp_vmlinux1
arch/arm/mach-davinci/built-in.o: In function `davinci_phy_fixup':
pm.c:(.text+0x35b8): undefined reference to mdiobus_read' pm.c:(.text+0x35d4): undefined reference to mdiobus_write' arch/arm/mach-davinci/built-in.o: In function `davinci_evm_init':
pm.c:(.init.text+0x237c): undefined reference to `phy_register_fixup_for_uid'
make: *** [.tmp_vmlinux1] Error 1

---
 arch/arm/mach-davinci/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-davinci/Kconfig +0 -0
index c0deaca..029ec46b 100644

arch/arm/mach-davinci/Kconfig config ARCH_DAVINCI_DM644x · line 21

Quoted 4 lines
arch/arm/mach-davinci/Kconfig +1 -0
@@ -18,6 +18,7 @@ config ARCH_DAVINCI_DM644x
 	bool "DaVinci 644x based system"
 	select AINTC
 	select ARCH_DAVINCI_DMx
+	select PHYLIB

Selecting PHYLIB for the SoC isn't right because only the EVM is affected by this issue.

Also, instead of selecting PHYLIB, a better fix would be to define the fixup function within #ifdef PHYLIB and have an empty fixup registration function in case PHYLIB is not defined (which should happen only when EMAC driver is not configured in which case a fixup is not required anyway).

Thanks,
Sekhar

author
#2 lore raw

2011/9/2 Nori, Sekhar <[email protected]>:

Quoted 8 lines

Hi Axel,

Quoted 2 lines · Axel Lin

We call phy_register_fixup_for_uid in davinci_evm_init, thus we need select PHYLIB to fix below build error: (with "make davinci_all_defconfig")

This shouldn't happen with davinci_all_defconfig as it selects PHYLIB (this doesn't undermine the need for a fix).

I remember that I got the build error with davinci_all_defconfig, but the build seems ok now with linux-next ( next-20110831 ).

Regards,
Axel