Skip to contentSkip to conversation

power_supply: s3c_adc_battery: Needs module.h

PATCH In review Axel Lin 2 participants 2 messages Aug 21, 2011 – Aug 23, 2011

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 power_supply: s3c_adc_battery: Needs module.h

power/s3c_adc_battery:.c uses interfaces from linux/module.h, so it should include that file.

This patch fixes below build error:

CC drivers/power/s3c_adc_battery.o
drivers/power/s3c_adc_battery.c:435: error: expected declaration specifiers or '...' before string constant drivers/power/s3c_adc_battery.c:435: warning: data definition has no type or storage class drivers/power/s3c_adc_battery.c:435: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/power/s3c_adc_battery.c:435: warning: function declaration isn't a prototype drivers/power/s3c_adc_battery.c:436: error: expected declaration specifiers or '...' before string constant drivers/power/s3c_adc_battery.c:436: warning: data definition has no type or storage class drivers/power/s3c_adc_battery.c:436: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/power/s3c_adc_battery.c:436: warning: function declaration isn't a prototype drivers/power/s3c_adc_battery.c:437: error: expected declaration specifiers or '...' before string constant drivers/power/s3c_adc_battery.c:437: warning: data definition has no type or storage class drivers/power/s3c_adc_battery.c:437: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/power/s3c_adc_battery.c:437: warning: function declaration isn't a prototype make[2]: *** [drivers/power/s3c_adc_battery.o] Error 1
make[1]: *** [drivers/power] Error 2
make: *** [drivers] Error 2

---
 drivers/power/s3c_adc_battery.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/power/s3c_adc_battery.c +1 -0
index a675e31..20770ba 100644
@@ -9,6 +9,7 @@
  *
  */
 
+#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <linux/power_supply.h>
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 22 lines · Axel Lin

power/s3c_adc_battery:.c uses interfaces from linux/module.h, so it should include that file.

This patch fixes below build error:

CC drivers/power/s3c_adc_battery.o
drivers/power/s3c_adc_battery.c:435: error: expected declaration specifiers or '...' before string constant drivers/power/s3c_adc_battery.c:435: warning: data definition has no type or storage class drivers/power/s3c_adc_battery.c:435: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/power/s3c_adc_battery.c:435: warning: function declaration isn't a prototype drivers/power/s3c_adc_battery.c:436: error: expected declaration specifiers or '...' before string constant drivers/power/s3c_adc_battery.c:436: warning: data definition has no type or storage class drivers/power/s3c_adc_battery.c:436: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/power/s3c_adc_battery.c:436: warning: function declaration isn't a prototype drivers/power/s3c_adc_battery.c:437: error: expected declaration specifiers or '...' before string constant drivers/power/s3c_adc_battery.c:437: warning: data definition has no type or storage class drivers/power/s3c_adc_battery.c:437: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/power/s3c_adc_battery.c:437: warning: function declaration isn't a prototype make[2]: *** [drivers/power/s3c_adc_battery.o] Error 1
make[1]: *** [drivers/power] Error 2
make: *** [drivers] Error 2

Quoted 2 lines

---

Vasily Khoruzhick sent a similar fix.

I'm going to send a pull request with these fixes soon.

Signature · 2 lines
Anton Vorontsov
Email: [email protected]