dt-bindings: trivial-devices: Document elgin,spi-lcd
Subsystems (3)
PATCH 1/3 dt-bindings: trivial-devices: Document elgin,spi-lcd
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
Add an entry for the "elgin,spi-lcd" compatible string.
--- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
@@ -110,6 +110,8 @@ properties: - domintech,dmard09 # DMARD10: 3-axis Accelerometer - domintech,dmard10 + # Elgin SPI-controlled LCD + - elgin,spi-lcd # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor - fsl,mma7660 # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
Signature · 1 line
2.34.1
PATCH 2/3 spi: spidev: Add an entry for "elgin,spi-lcd"
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
Add the "elgin,spi-lcd" compatible string.
--- drivers/spi/spidev.c | 1 + 1 file changed, 1 insertion(+)
drivers/spi/spidev.c +1 -0
@@ -730,6 +730,7 @@ static int spidev_of_check(struct device *dev)static const struct of_device_id spidev_dt_ids[] = { { .compatible ="cisco,spi-petra" , .data = &spidev_of_check }, { .compatible ="dh,dhcom-board" , .data = &spidev_of_check }, + { .compatible ="elgin,spi-lcd" , .data = &spidev_of_check }, { .compatible ="lineartechnology,ltc2488" , .data = &spidev_of_check }, { .compatible ="lwn,bk4" , .data = &spidev_of_check }, { .compatible ="menlo,m53cpld" , .data = &spidev_of_check },
Signature · 1 line
2.34.1
PATCH 3/3 ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device
In reply to Fabio EstevamThere is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
There is an LCD controlled via SPI though.
Properly describe it by adding the "elgin,spi-lcd" compatible string.
---
Hi Heiko,
Conor sent a patch removing the rohm,dh2228fv entry from rv1108-elgin-r1.dts:
https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
If you prefer, I can send a patch on top of his.
Or you can apply this one instead.
arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts +2 -2
@@ -168,8 +168,8 @@ &spi { pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>; status = "okay"; - dh2228fv: dac@0 { - compatible = "rohm,dh2228fv"; + display: display@0 { + compatible = "elgin,spi-lcd"; reg = <0>; spi-max-frequency = <24000000>; spi-cpha;
Signature · 1 line
2.34.1
Heiko Stübner
maintainerRe: [PATCH 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device
Hi Fabio,
Am Donnerstag, 18. Juli 2024, 22:05:40 CEST schrieb Fabio Estevam:
Quoted 10 lines
There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
There is an LCD controlled via SPI though.
Properly describe it by adding the "elgin,spi-lcd" compatible string.
Quoted 8 lines
---
Hi Heiko,Conor sent a patch removing the rohm,dh2228fv entry from
rv1108-elgin-r1.dts:https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
If you prefer, I can send a patch on top of his.
The decision is interesting, one less patch vs. keeping Conor's separate patch history. Maybe Conor voices his opinion while we're still in the merge window :-) .
Heiko
Quoted 21 lines
Or you can apply this one instead.
arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts +2
-2@@ -168,8 +168,8 @@ &spi { pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>; status = "okay"; - dh2228fv: dac@0 { - compatible = "rohm,dh2228fv"; + display: display@0 { + compatible = "elgin,spi-lcd"; reg = <0>; spi-max-frequency = <24000000>; spi-cpha;
Re: [PATCH 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device
Quoted 16 lines · Heiko Stübner
Am Donnerstag, 18. Juli 2024, 22:05:40 CEST schrieb Fabio Estevam:
Quoted 15 lines
There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
There is an LCD controlled via SPI though.
Properly describe it by adding the "elgin,spi-lcd" compatible string.
Reported-by Conor Dooley <[email protected]>Signed-off-by Fabio Estevam <[email protected]>---
Hi Heiko,Conor sent a patch removing the rohm,dh2228fv entry from
rv1108-elgin-r1.dts:
Quoted 7 lines
Quoted 3 lines
https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
If you prefer, I can send a patch on top of his.
The decision is interesting, one less patch vs. keeping Conor's separate patch history. Maybe Conor voices his opinion while we're still in the merge window :-) .
Adding the correct device is an improvement over my patch, I don't see a reason (other than vanity) for applying both. However, I don't think that "elgin,spi-lcd" is a suitable compatible as it is far too generic.
Quoted 14 lines · Fabio Estevam
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
Add an entry for the "elgin,spi-lcd" compatible string.
Signed-off-by Fabio Estevam <[email protected]>--- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/trivial-devices.yaml +0
-0
Documentation/devicetree/bindings/trivial-devices.yaml properties: · line 114
Quoted 5 lines
Documentation/devicetree/bindings/trivial-devices.yaml +2
-0@@ -110,6 +110,8 @@ properties: - domintech,dmard09 # DMARD10: 3-axis Accelerometer - domintech,dmard10 + # Elgin SPI-controlled LCD + - elgin,spi-lcd
As mentioned on the dts patch, this needs to be far more specific. Are there no markings etc on the panel?
I still can't find any information online about this board, other than linux/u-boot lists or related repos.
Quoted 6 lines
Documentation/devicetree/bindings/trivial-devices.yaml +0
-0# MMA7660FC: 3-Axis Orientation/Motion Detection Sensor - fsl,mma7660 # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic AccelerometerSignature · 1 line
2.34.1
Hi Conor,
Quoted 2 lines · Conor Dooley
As mentioned on the dts patch, this needs to be far more specific. Are there no markings etc on the panel?
I submitted v2 with a more specific compatible string containing the markings on the panel.
Thanks