Skip to contentSkip to conversation

Input: adp5588-keys - remove incorrect modalias

PATCH Applied Axel Lin 3 participants 3 messages Aug 25, 2011 – Aug 27, 2011

Subsystems (3)
HID Input drivers ADP5588 qwerty keypad and io expander driver (ADP5588/ADP5587)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 Input: adp5588-keys - remove incorrect modalias

Quoted 1 line

From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Thu, 25 Aug 2011 18:26:56 +0800
Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias

For i2c drivers, we should use "i2c:" prefix for modalias. MODULE_DEVICE_TABLE will setup the modulalias for us, thus adding a MODULE_ALIAS here seems redundant.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/input/keyboard/adp5588-keys.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/input/keyboard/adp5588-keys.c +0 -1
index 7b404e54..e34eeb8 100644
@@ -668,4 +668,3 @@ module_exit(adp5588_exit);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Michael Hennerich <[email protected]>");
 MODULE_DESCRIPTION("ADP5588/87 Keypad driver");
-MODULE_ALIAS("platform:adp5588-keys");
Signature · 1 line
1.7.4.1
maintainer Acked-by on v1 1/1
#1 lore raw

Axel Lin wrote on 2011-08-25:

Quoted 10 lines

From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
From: Axel Lin <[email protected]>
Date: Thu, 25 Aug 2011 18:26:56 +0800
Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias

For i2c drivers, we should use "i2c:" prefix for modalias. MODULE_DEVICE_TABLE will setup the modulalias for us, thus adding a MODULE_ALIAS here seems redundant.

Signed-off-by Axel Lin <[email protected]>
Acked-by Michael Hennerich <[email protected]>
Quoted 4 lines
---
 drivers/input/keyboard/adp5588-keys.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
(quoted diff) +0 -0
Quoted 8 lines

b/drivers/input/keyboard/adp5588-keys.c index 7b404e54..e34eeb8 100644 --- a/drivers/input/keyboard/adp5588-keys.c +++ b/drivers/input/keyboard/adp5588-keys.c @@ -668,4 +668,3 @@ module_exit(adp5588_exit);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Michael Hennerich <[email protected]>"); MODULE_DESCRIPTION("ADP5588/87 Keypad driver");
-MODULE_ALIAS("platform:adp5588-keys");

Greetings,
Michael

--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif

maintainer Applied
#2 lore raw
Quoted 6 lines · Michael

Axel Lin wrote on 2011-08-25:

Quoted 5 lines

From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
From: Axel Lin <[email protected]>
Date: Thu, 25 Aug 2011 18:26:56 +0800
Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias

Quoted 7 lines
Quoted 5 lines

For i2c drivers, we should use "i2c:" prefix for modalias. MODULE_DEVICE_TABLE will setup the modulalias for us, thus adding a MODULE_ALIAS here seems redundant.

Signed-off-by Axel Lin <[email protected]>
Acked-by Michael Hennerich <[email protected]>

Applied, thanks Axel.

Signature · 1 line
Dmitry