Skip to contentSkip to conversation

lowercase include header name in syshead.h

PATCH In review Heiko Hund 3 participants 3 messages Aug 31, 2011

lore
Share & tools
lore

Heiko Hund

author
#0 lore raw

PATCH 1/1 lowercase include header name in syshead.h

Cross compiling for Windows is broken since commit 739fa9881f12e67dc8b9cadc7230e59e7fe42423 added the mixed case header name "NtDDNdis.h" to the file. While this header exists in a MinGW build environment it's lowercase there.

Windows doesn't mind the case of a file name, but Linux does. So, lowercasing the filename will make openvpn build in both worlds.

Signed-off-by Heiko Hund <[email protected]...>
---
 syshead.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
syshead.h +1 -1
index 87cc369..e208d4c 100644
@@ -342,7 +342,7 @@
 
 #ifdef WIN32
 #include <iphlpapi.h>
-#include <NtDDNdis.h>
+#include <ntddndis.h>
 #include <wininet.h>
 /* The following two headers are needed of PF_INET6 */
 #include <winsock2.h>
Signature · 1 line
1.7.5.4
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 10 lines · Heiko Hund

Cross compiling for Windows is broken since commit 739fa9881f12e67dc8b9cadc7230e59e7fe42423 added the mixed case header name "NtDDNdis.h" to the file. While this header exists in a MinGW build environment it's lowercase there.

Windows doesn't mind the case of a file name, but Linux does. So, lowercasing the filename will make openvpn build in both worlds.

Signed-off-by Heiko Hund <[email protected]...>

ACK. Applied to testing and stable master branches. Commit a18c2b025c851a50bd2df33af5bad99b467da595

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk5ecbsACgkQDC186MBRfrodcwCggiac4FmGOzLpHbO87fO1PzXZ TicAn3Uo0hCE70SIqn6hJ8sin08DCft6
=uWWT
-----END PGP SIGNATURE-----

#2 lore raw
In reply to Heiko Hund

Hi,

Quoted 4 lines · Heiko Hund

Cross compiling for Windows is broken since commit 739fa9881f12e67dc8b9cadc7230e59e7fe42423 added the mixed case header name "NtDDNdis.h" to the file. While this header exists in a MinGW build environment it's lowercase there.

ACK, thanks for fixing this for good. (We had a somewhat lengthy discussion about that header file, but it didn't go anywhere due to lack of windows cluefulness... and maybe willingness :) ).

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...