Skip to contentSkip to conversation

devkit8000 & omap3stalker LCD panel

PATCH In review Tomi Valkeinen 2 participants 6 messages Sep 1, 2011 – Sep 5, 2011

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

Hi Thomas, Jason,

I noticed that both devkit8000 and omap3stalker boards use the generic dpi driver for LCD. Why is that? If the boards have a normal fixed resolution LCD, the timings for the LCD should be added to the panel-generic-dpi.c.

Tomi

#1 lore raw

Am 01.09.2011 08:42, schrieb Tomi Valkeinen:

Quoted 10 lines

Hi Thomas, Jason,

I noticed that both devkit8000 and omap3stalker boards use the generic dpi driver for LCD. Why is that? If the boards have a normal fixed resolution LCD, the timings for the LCD should be added to the panel-generic-dpi.c.

Tomi

Hello Tomi,

I will send a patch that adds support for the devkit8000 panel.

Thomas

#2 lore raw

PATCH 1/3 OMAP: DSS2: Support for Innolux AT070TN83

In reply to Tomi Valkeinen

Add support for Innolux AT070TN83, a 7 inch LCD with RGB-Interface and touch panel to panel-generic-dpi.

Tested with Devkit8000.

---
 drivers/video/omap2/displays/panel-generic-dpi.c |   25 ++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)
drivers/video/omap2/displays/panel-generic-dpi.c +25 -0
index 9c90f75..b401304 100644
@@ -232,6 +232,31 @@ static struct panel_config generic_dpi_panels[] = {
 		.power_off_delay	= 0,
 		.name			= "powertip_ph480272t",
 	},
+
+	/* Innolux AT070TN83 */
+	{
+		{
+			.x_res		= 800,
+			.y_res		= 480,
+
+			.pixel_clock	= 40000,
+
+			.hsw		= 48,
+			.hfp		= 1,
+			.hbp		= 1,
+
+			.vsw		= 3,
+			.vfp		= 12,
+			.vbp		= 25,
+		},
+		.acbi			= 0x0,
+		.acb			= 0x28,
+		.config			= OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
+					  OMAP_DSS_LCD_IHS,
+		.power_on_delay		= 0,
+		.power_off_delay	= 0,
+		.name			= "innolux_at070tn83",
+	},
 };
 
 struct panel_drv_data {
Signature · 1 line
1.7.6.1
#3 lore raw

PATCH 2/3 OMAP: Devkit8000: Change lcd driver to AT070TN83

Change lcd driver from generic to AT070TN83.

---
 arch/arm/mach-omap2/board-devkit8000.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-devkit8000.c +1 -1
index 4b1f6c6..a3b8e81 100644
@@ -139,7 +139,7 @@ static struct regulator_consumer_supply devkit8000_vio_supply[] = {
 };
 
 static struct panel_generic_dpi_data lcd_panel = {
-	.name			= "generic",
+	.name			= "innolux_at070tn83",
 	.platform_enable        = devkit8000_panel_enable_lcd,
 	.platform_disable       = devkit8000_panel_disable_lcd,
 };
Signature · 1 line
1.7.6.1
#4 lore raw

Re: [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83

In reply to Thomas Weber
Quoted 9 lines · Thomas Weber

Add support for Innolux AT070TN83, a 7 inch LCD with RGB-Interface and touch panel to panel-generic-dpi.

Tested with Devkit8000.

---
 drivers/video/omap2/displays/panel-generic-dpi.c |   25 ++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)

Thanks, these look fine to me.

The subject suggests there are 3 patches, but I presume that's wrong?

Tomi

#5 lore raw

Re: [PATCH 1/3] OMAP: DSS2: Support for Innolux AT070TN83

Am 02.09.2011 09:58, schrieb Tomi Valkeinen:

Quoted 10 lines · Thomas Weber
Quoted 9 lines

Add support for Innolux AT070TN83, a 7 inch LCD with RGB-Interface and touch panel to panel-generic-dpi.

Tested with Devkit8000.

---
 drivers/video/omap2/displays/panel-generic-dpi.c |   25 ++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)
Quoted 8 lines

Thanks, these look fine to me.

The subject suggests there are 3 patches, but I presume that's wrong?

Tomi

You are right, I had an additional patch during format-patch.

Thomas