Skip to contentSkip to conversation

makedumpfile: omit those section has 0 size

PATCH In review Lei Wen 3 participants 4 messages Sep 4, 2011 – Sep 5, 2011

Subsystems (2)
lore
Share & tools
lore

Lei Wen

author
#0 lore raw

PATCH 1/1 makedumpfile: omit those section has 0 size

If the area reserved for the kdump is at the end of system memory, then it would occur such case that the second sector is turly 0 size. And as the beginnig of the second sector is already out of system memory range. Try to access this range, would cause makedumpfile failed.

---
 makedumpfile.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
makedumpfile.c +4 -0
index 7d0c663..3f8d9af 100644
@@ -1336,6 +1336,8 @@ get_elf_info(void)
 		}
 		if (phdr.p_type != PT_LOAD)
 			continue;
+		if (phdr.p_filesz == 0)
+			continue;
 
 		if (j == 0) {
 			info->offset_load_memory = phdr.p_offset;
@@ -5756,6 +5758,8 @@ write_elf_pages(struct cache_data *cd_header, struct cache_data *cd_page)
 
 		if (load.p_type != PT_LOAD)
 			continue;
+		if (load.p_filesz == 0)
+			continue;
 
 		off_memory= load.p_offset;
 		paddr     = load.p_paddr;
Signature · 7 lines
1.7.0.4


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
#1 lore raw

Hi Lei,

Thank you for the patch.

The almost same patch has been merged into the devel git-tree, does the following patch fix the prblem you said ?

http://makedumpfile.git.sourceforge.net/git/gitweb.cgi?p=makedumpfile/makedumpfile;a=commit;h=63f720a7784debce82c8942970d5c0d8412f209f

Thanks
Ken'ichi Ohmichi

Quoted 41 lines · On Sun, 4 Sep 2011 09:02:39 -0700 Lei Wen <[email protected]> wrote:

If the area reserved for the kdump is at the end of system memory, then it would occur such case that the second sector is turly 0 size. And as the beginnig of the second sector is already out of system memory range. Try to access this range, would cause makedumpfile failed.

---
 makedumpfile.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
makedumpfile.c +4 -0
index 7d0c663..3f8d9af 100644
@@ -1336,6 +1336,8 @@ get_elf_info(void)
 		}
 		if (phdr.p_type != PT_LOAD)
 			continue;
+		if (phdr.p_filesz == 0)
+			continue;
 
 		if (j == 0) {
 			info->offset_load_memory = phdr.p_offset;
@@ -5756,6 +5758,8 @@ write_elf_pages(struct cache_data *cd_header, struct cache_data *cd_page)
 
 		if (load.p_type != PT_LOAD)
 			continue;
+		if (load.p_filesz == 0)
+			continue;
 
 		off_memory= load.p_offset;
 		paddr     = load.p_paddr;
Signature · 7 lines
1.7.0.4


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#2 lore raw

Hi Ken'ichi,

Quoted 10 lines · Ken'ichi Ohmichi

Hi Lei,

Thank you for the patch.

The almost same patch has been merged into the devel git-tree, does the following patch fix the prblem you said ?

http://makedumpfile.git.sourceforge.net/git/gitweb.cgi?p=makedumpfile/makedumpfile;a=commit;h=63f720a7784debce82c8942970d5c0d8412f209f

Yes, that fix my issue.

Thanks,
Lei

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#3 lore raw
Quoted 8 lines · On Mon, 5 Sep 2011 09:15:04 +0800 Lei Wen <[email protected]> wrote:
Quoted 6 lines

The almost same patch has been merged into the devel git-tree, does the following patch fix the prblem you said ?

http://makedumpfile.git.sourceforge.net/git/gitweb.cgi?p=makedumpfile/makedumpfile;a=commit;h=63f720a7784debce82c8942970d5c0d8412f209f

Yes, that fix my issue.

Thank you for the check. I see.

Thanks
Ken'ichi Ohmichi

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec