Skip to contentSkip to conversation

qt4e-demo-image: improve image

PATCH In review Eric Bénard 2 participants 3 messages Sep 7, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qt4e-demo-image: improve image

use ${POKY_BASE_INSTALL} in order to have the base files and ools in the image.

---
 meta/recipes-qt/images/qt4e-demo-image.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-qt/images/qt4e-demo-image.bb +1 -1
index 6a7c086..6523379 100644
@@ -11,7 +11,7 @@ RDEPENDS_${PN} += " \
 	"
 
 IMAGE_INSTALL += "\
-	busybox \
+	${POKY_BASE_INSTALL} \
 	module-init-tools \
 	task-qt4e-base \
 "
Signature · 1 line
1.7.6
#1 lore raw

meta/recipes-qt/images/qt4e-demo-image.bb RDEPENDS_${PN} += " \ · line 17

Quoted 11 lines · On Wednesday 07 September 2011 14:17:10 Eric Bénard wrote:

use ${POKY_BASE_INSTALL} in order to have the base files and ools in the image.

..

IMAGE_INSTALL += "\

meta/recipes-qt/images/qt4e-demo-image.bb +1 -1
-	busybox \
+	${POKY_BASE_INSTALL} \
 	module-init-tools \
 	task-qt4e-base \
 "

Hmm, I missed this when the original patches came in; surely it would be better to just append to IMAGE_INSTALL after the "inherit core-image" line, then we start with the default value from core-image.bbclass?

(Of course with either fix we'll run into the build annoyance pointed out in the other message I just sent, where a whole bunch of X apps we won't need will get built.)

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#2 lore raw
Quoted 6 lines · Paul Eggleton
Quoted 5 lines · On Wednesday 07 September 2011 14:17:10 Eric Bénard wrote:

use ${POKY_BASE_INSTALL} in order to have the base files and ools in the image.

..

Quoted 11 lines

meta/recipes-qt/images/qt4e-demo-image.bb RDEPENDS_${PN} += " \ · line 17

Quoted 6 lines
  IMAGE_INSTALL += "\
meta/recipes-qt/images/qt4e-demo-image.bb +1 -1
-	busybox \
+	${POKY_BASE_INSTALL} \
  	module-init-tools \
  	task-qt4e-base \
  "

Hmm, I missed this when the original patches came in; surely it would be better to just append to IMAGE_INSTALL after the "inherit core-image" line, then we start with the default value from core-image.bbclass?

ok I was not sure this would work this way, I'll test and send a v2.

Thanks,
Eric