Skip to contentSkip to conversation

Trivial: devtmpfs.c: No need to set the task state to TASK_RUNNING

PATCH In review Kautuk Consul 1 participant 2 messages Sep 8, 2011 – Sep 21, 2011 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Trivial: devtmpfs.c: No need to set the task state to TASK_RUNNING

I think that there should be no need to set the task state to TASK_RUNNING as wake_up_process will do that for us.

---
 drivers/base/devtmpfs.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/base/devtmpfs.c +0 -1
index a4760e0..8a3f028 100644
@@ -416,7 +416,6 @@ static int devtmpfsd(void *p)
 		set_current_state(TASK_INTERRUPTIBLE);
 		spin_unlock(&req_lock);
 		schedule();
-		__set_current_state(TASK_RUNNING);
 	}
 	return 0;
 out:
Signature · 1 line
1.7.4.1
#1 lore raw

Hi,

Please ignore this trivial patch.
I found one more trivial change which I would like to make in this patch, so I'll resend
this one in a separate email chain.

Thanks,
Kautuk.

Quoted 24 lines · Kautuk Consul

I think that there should be no need to set the task state to TASK_RUNNING as wake_up_process will do that for us.

---
 drivers/base/devtmpfs.c |    1 -

 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/base/devtmpfs.c +0 -1
index a4760e0..8a3f028 100644
@@ -416,7 +416,6 @@ static int devtmpfsd(void *p)
                set_current_state(TASK_INTERRUPTIBLE);
                spin_unlock(&req_lock);
                schedule();
-               __set_current_state(TASK_RUNNING);
        }
        return 0;

 out:
--
1.7.4.1