Skip to contentSkip to conversation

ARM7TDMI: Enable ARMv4T features

PATCH In review Marek Vasut 2 participants 3 messages Sep 9, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM7TDMI: Enable ARMv4T features

---
 target-arm/helper.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
target-arm/helper.c +1 -0
index 58cd99f..2f3e937 100644
@@ -53,6 +53,7 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
     env->cp15.c0_cpuid = id;
     switch (id) {
     case ARM_CPUID_ARM7TDMI:
+        set_feature(env, ARM_FEATURE_V4T);
         // set_feature(env, ARM_FEATURE_ABORT_BU);
 	// set_feature(env, ARM_FEATURE_NO_CP15);
         break;
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 12 lines · Marek Vasut

---
 target-arm/helper.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
target-arm/helper.c +0 -0
index 58cd99f..2f3e937 100644
@@ -53,6 +53,7 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
     env->cp15.c0_cpuid = id;
     switch (id) {
Quoted 5 lines

    case ARM_CPUID_ARM7TDMI:
+        set_feature(env, ARM_FEATURE_V4T); // set_feature(env, ARM_FEATURE_ABORT_BU); // set_feature(env, ARM_FEATURE_NO_CP15); break;

Did you mean to send this as part of a patch series or something? Upstream qemu doesn't have any support for ARM7TDMI (and in particular doesn't even define ARM_CPUID_ARM7TDMI), so this patch obviously applies on top of something else...

-- PMM

#2 lore raw
Quoted 15 lines · Peter Maydell
Quoted 14 lines · Marek Vasut
---
 target-arm/helper.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
target-arm/helper.c +1 -0
index 58cd99f..2f3e937 100644
@@ -53,6 +53,7 @@ static void cpu_reset_model_id(CPUARMState *env,
 uint32_t id) env->cp15.c0_cpuid = id;
    switch (id) {
    case ARM_CPUID_ARM7TDMI:
+        set_feature(env, ARM_FEATURE_V4T);
Quoted 8 lines

target-arm/helper.c static void cpu_reset_model_id(CPUARMState *env, uint32_t id) · line 59

Quoted 3 lines
target-arm/helper.c +0 -0
        // set_feature(env, ARM_FEATURE_ABORT_BU);
       // set_feature(env, ARM_FEATURE_NO_CP15);
        break;

Did you mean to send this as part of a patch series or something? Upstream qemu doesn't have any support for ARM7TDMI (and in particular doesn't even define ARM_CPUID_ARM7TDMI), so this patch obviously applies on top of something else...

Ah damn, I just realized I have it on top of a patchset from some other person. I'll continue cleaning up the patchset, then submit the whole thing. Please ignore this one.

Cheers

Quoted 2 lines

-- PMM