policycoreutils: sandbox: FIXME add level based kill
PATCH 35/67 policycoreutils: sandbox: FIXME add level based kill
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
This patch looks good to me. acked.
The comment in your patch says sandbox will default to -K, this is not true, the patch is fine though.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk5yVesACgkQrlYvE4MpobMfuACgynaP1XdCWq1mk5PgZu6KfDQ5 AwMAnjhvqu8K0NUM4cDXBGIIf8bTbbjT
=XMYr
-----END PGP SIGNATURE-----
Review childerr: · line 1019
Quoted 10 lines · Daniel J Walsh
(quoted diff) +3
-0@@ -941,6 +1011,9 @@ childerr: waitpid(child, &status, 0); status_to_retval(status, status); + if (execcon && kill_all) + killall(execcon); + if (tmpdir_r) cleanup_tmpdir(tmpdir_r, tmpdir_s, pwd, 1); err:
Was it not just "kill" instead of "kill_all" ?
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 5 lines · Guido Trentalancia
Quoted 4 lines · Daniel J Walsh
(quoted diff) +0
-0@@ -941,6 +1011,9 @@ childerr: waitpid(child, &status, 0); status_to_retval(status, status);
Quoted 8 lines
Review childerr: · line 1019
Quoted 6 lines
(quoted diff) +3
-0+ if (execcon && kill_all) + killall(execcon); + if (tmpdir_r) cleanup_tmpdir(tmpdir_r, tmpdir_s, pwd, 1); err:Was it not just "kill" instead of "
kill_all" ?
I just realised that variable is going to get renamed in another patch ([PATCH 36/67] policycoreutils: sandbox: cntrl-c should kill entire). So I think this patch requires 36/67, that's it but was not evident at first sight.
Guido
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 13 lines · Guido Trentalancia
Quoted 11 lines · Guido Trentalancia
Quoted 8 lines · Daniel J Walsh
(quoted diff) +1
-0@@ -941,6 +1011,9 @@ childerr: waitpid(child, &status, 0); status_to_retval(status, status); + if (execcon && kill_all) + killall(execcon); + if (tmpdir_r) cleanup_tmpdir(tmpdir_r, tmpdir_s, pwd, 1);err:
Was it not just "kill" instead of "
kill_all" ?
Quoted 7 lines
I just realised that variable is going to get renamed in another patch ([PATCH 36/67] policycoreutils: sandbox: cntrl-c should kill entire). So I think this patch requires 36/67, that's it but was not evident at first sight.
Guido
kill would conflict with the function kill. -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk5zXMsACgkQrlYvE4MpobP5twCdFv8PeXU5xxUK8jVlDh4AEGpC jjQAnRsPrMSo0umWF4NeSO/+0iKg64TB
=DEO6
-----END PGP SIGNATURE-----
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 11 lines · Guido Trentalancia
Quoted 10 lines · Guido Trentalancia
Quoted 9 lines · Daniel J Walsh
(quoted diff) +3
-0@@ -941,6 +1011,9 @@ childerr: waitpid(child, &status, 0); status_to_retval(status, status); + if (execcon && kill_all) + killall(execcon); + if (tmpdir_r) cleanup_tmpdir(tmpdir_r, tmpdir_s, pwd, 1);
Quoted 8 lines
Quoted 3 lines
Review childerr: · line 1019
Quoted 1 line
(quoted diff) +0
-0err:Was it not just "kill" instead of "
kill_all" ?I just realised that variable is going to get renamed in another patch ([PATCH 36/67] policycoreutils: sandbox: cntrl-c should kill entire). So I think this patch requires 36/67, that's it but was not evident at first sight.
Thanks, mistake on my part. Will move the required change from patch #36 into patch #35 before committing.
-Eric
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.