Skip to contentSkip to conversation

mfd: jz4740-adc: Fix generic irq chip ack function name.

PATCH In review Lars-Peter Clausen 2 participants 2 messages Sep 19, 2011 – Sep 20, 2011 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: jz4740-adc: Fix generic irq chip ack function name.

In commit 659fb32d1b6("genirq: replace irq_gc_ack() with {set,clr}_bit variants"), irq_gc_ack was renamed to irq_gc_ack_set_bit. The jz4740-adc driver still uses the old name which results in a compile error.

---
Samuel, it would be good if this fix could make it into 3.1

---
 drivers/mfd/jz4740-adc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/jz4740-adc.c +1 -1
index 21131c7..563654c 100644
@@ -273,7 +273,7 @@ static int __devinit jz4740_adc_probe(struct platform_device *pdev)
 	ct->regs.ack = JZ_REG_ADC_STATUS;
 	ct->chip.irq_mask = irq_gc_mask_set_bit;
 	ct->chip.irq_unmask = irq_gc_mask_clr_bit;
-	ct->chip.irq_ack = irq_gc_ack;
+	ct->chip.irq_ack = irq_gc_ack_set_bit;
 
 	irq_setup_generic_chip(gc, IRQ_MSK(5), 0, 0, IRQ_NOPROBE | IRQ_LEVEL);
 
Signature · 1 line
1.7.2.5
#1 lore raw

Hi Lars,

Quoted 7 lines · Lars-Peter Clausen

In commit 659fb32d1b6("genirq: replace irq_gc_ack() with {set,clr}_bit variants"), irq_gc_ack was renamed to irq_gc_ack_set_bit. The jz4740-adc driver still uses the old name which results in a compile error.

---
Samuel, it would be good if this fix could make it into 3.1

I will try to have it merged. For now, it's on my for-next branch.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/