Skip to contentSkip to conversation

ASoC: Staticise bf5xx_pcm_ac97_new()

PATCH In review Axel Lin 4 participants 7 messages Sep 21, 2011

Subsystems (3)
Sound ASoC Ingenic JZ47xx SoCs
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/4 ASoC: Staticise bf5xx_pcm_ac97_new()

It is not used outside this driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/blackfin/bf5xx-ac97-pcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/blackfin/bf5xx-ac97-pcm.c +1 -1
index 9e59f68..56815c1 100644
@@ -418,7 +418,7 @@ static void bf5xx_pcm_free_dma_buffers(struct snd_pcm *pcm)
 
 static u64 bf5xx_pcm_dmamask = DMA_BIT_MASK(32);
 
-int bf5xx_pcm_ac97_new(struct snd_soc_pcm_runtime *rtd)
+static int bf5xx_pcm_ac97_new(struct snd_soc_pcm_runtime *rtd)
 {
 	struct snd_card *card = rtd->card->snd_card;
 	struct snd_soc_dai *dai = rtd->cpu_dai;
Signature · 1 line
1.7.4.1
author
#1 lore raw

PATCH 2/4 ASoC: Staticise bf5xx_pcm_i2s_new()

It is not used outside this driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/blackfin/bf5xx-i2s-pcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/blackfin/bf5xx-i2s-pcm.c +1 -1
index 61ddf94..7565e15 100644
@@ -257,7 +257,7 @@ static void bf5xx_pcm_free_dma_buffers(struct snd_pcm *pcm)
 
 static u64 bf5xx_pcm_dmamask = DMA_BIT_MASK(32);
 
-int bf5xx_pcm_i2s_new(struct snd_soc_pcm_runtime *rtd)
+static int bf5xx_pcm_i2s_new(struct snd_soc_pcm_runtime *rtd)
 {
 	struct snd_card *card = rtd->card->snd_card;
 	struct snd_soc_dai *dai = rtd->cpu_dai;
Signature · 1 line
1.7.4.1
author
#2 lore raw

PATCH 3/4 ASoC: Staticise jz4740_pcm_new()

In reply to Axel Lin

It is not used outside this driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/jz4740/jz4740-pcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/jz4740/jz4740-pcm.c +1 -1
index a7c9578..d1989cd 100644
@@ -299,7 +299,7 @@ static void jz4740_pcm_free(struct snd_pcm *pcm)
 
 static u64 jz4740_pcm_dmamask = DMA_BIT_MASK(32);
 
-int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
+static int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
 {
 	struct snd_card *card = rtd->card->snd_card;
 	struct snd_soc_dai *dai = rtd->cpu_dai;
Signature · 1 line
1.7.4.1
Acked-by on v1 3/4
#3 lore raw

Re: [PATCH 3/4] ASoC: Staticise jz4740_pcm_new()

Quoted 3 lines · Axel Lin

It is not used outside this driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>
Acked-by Lars-Peter Clausen <[email protected]>

Thanks.

Quoted 17 lines
---
 sound/soc/jz4740/jz4740-pcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/jz4740/jz4740-pcm.c +1 -1
index a7c9578..d1989cd 100644
@@ -299,7 +299,7 @@ static void jz4740_pcm_free(struct snd_pcm *pcm)
 
 static u64 jz4740_pcm_dmamask = DMA_BIT_MASK(32);
 
-int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
+static int jz4740_pcm_new(struct snd_soc_pcm_runtime *rtd)
 {
 	struct snd_card *card = rtd->card->snd_card;
 	struct snd_soc_dai *dai = rtd->cpu_dai;
author
#4 lore raw

PATCH 4/4 ASoC: Staticise nuc900_dma_getposition()

In reply to Axel Lin

It is not used outside this driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/nuc900/nuc900-pcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/nuc900/nuc900-pcm.c +1 -1
index e46d551..4e3626b 100644
@@ -227,7 +227,7 @@ static int nuc900_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 	return ret;
 }
 
-int nuc900_dma_getposition(struct snd_pcm_substream *substream,
+static int nuc900_dma_getposition(struct snd_pcm_substream *substream,
 					dma_addr_t *src, dma_addr_t *dst)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
Signature · 1 line
1.7.4.1
#5 lore raw

Re: [PATCH 4/4] ASoC: Staticise nuc900_dma_getposition()

2011/9/21 Axel Lin <[email protected]>:

Quoted 21 lines

It is not used outside this driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/nuc900/nuc900-pcm.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/nuc900/nuc900-pcm.c +1 -2
index e46d551..4e3626b 100644
@@ -227,7 +227,7 @@ static int nuc900_dma_trigger(struct snd_pcm_substream *substream, int cmd)
        return ret;
  }
 
-int nuc900_dma_getposition(struct snd_pcm_substream *substream,
+static int nuc900_dma_getposition(struct snd_pcm_substream *substream,
                                        dma_addr_t *src, dma_addr_t *dst)
  {
        struct snd_pcm_runtime *runtime = substream->runtime;
--
Quoted 2 lines

1.7.4.1

thanks!

Acked- by: Wan Zongshun <[email protected]>

Quoted 3 lines
Signature · 6 lines
Wan ZongShun.
www.mcuos.com
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel