Initial support for Picochip picoxcell

+ ? ? ? clocks {
+ ? ? ? ? ? ? ? #address-cells = <1>;
+ ? ? ? ? ? ? ? #size-cells = <1>;
+ ? ? ? ? ? ? ? ranges;

(quoted diff) +78 -0

+
+ ? ? ? ? ? ? ? clkgate: clkgate at 800a0048 {
+ ? ? ? ? ? ? ? ? ? ? ? #address-cells = <1>;
+ ? ? ? ? ? ? ? ? ? ? ? #size-cells = <0>;
+ ? ? ? ? ? ? ? ? ? ? ? reg = <0x800a0048 4>;
+ ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-clk-gate";
+
+ ? ? ? ? ? ? ? ? ? ? ? tzprot_clk: clock at 0 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-gated-clk";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? picochip,clk-disable-bit = <0>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <200000000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ref-clock = <&ref_clk>, "ref";
+ ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? spi_clk: clock at 1 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-gated-clk";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? picochip,clk-disable-bit = <1>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <200000000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ref-clock = <&ref_clk>, "ref";
+ ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? dmac0_clk: clock at 2 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-gated-clk";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? picochip,clk-disable-bit = <2>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <200000000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ref-clock = <&ref_clk>, "ref";
+ ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? dmac1_clk: clock at 3 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-gated-clk";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? picochip,clk-disable-bit = <3>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <200000000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ref-clock = <&ref_clk>, "ref";
+ ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? ebi_clk: clock at 4 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-gated-clk";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? picochip,clk-disable-bit = <4>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <200000000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ref-clock = <&ref_clk>, "ref";
+ ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? ipsec_clk: clock at 5 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-gated-clk";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? picochip,clk-disable-bit = <5>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <200000000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ref-clock = <&ref_clk>, "ref";
+ ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? l2_clk: clock at 6 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-gated-clk";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? picochip,clk-disable-bit = <6>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <200000000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ref-clock = <&ref_clk>, "ref";
+ ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? trng_clk: clock at 7 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-gated-clk";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? picochip,clk-disable-bit = <7>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <200000000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ref-clock = <&ref_clk>, "ref";
+ ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? fuse_clk: clock at 8 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "picochip,pc3x3-gated-clk";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? picochip,clk-disable-bit = <8>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <200000000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ref-clock = <&ref_clk>, "ref";
+ ? ? ? ? ? ? ? ? ? ? ? };

The PC7302 board can be populated with either a PC3X2 or PC3X3 device. Add DTS files for both variants of the PC7302.

Signed-off-by Jamie Iles <[email protected]>

---
?arch/arm/boot/dts/picoxcell-pc7302-pc3x2.dts | ? 87 ++++++++++++++++++++++++ ?arch/arm/boot/dts/picoxcell-pc7302-pc3x3.dts | ? 93 ++++++++++++++++++++++++++ ?2 files changed, 180 insertions(+), 0 deletions(-)
?create mode 100644 arch/arm/boot/dts/picoxcell-pc7302-pc3x2.dts ?create mode 100644 arch/arm/boot/dts/picoxcell-pc7302-pc3x3.dts

arch/arm/boot/dts/picoxcell-pc7302-pc3x2.dts new file +87 -0

new file mode 100644
index 0000000..4c9a7ba
@@ -0,0 +1,87 @@
+/*
+ * ?Copyright (C) 2011 Picochip, Jamie Iles
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ?See the
+ * GNU General Public License for more details.
+ */
+
+/dts-v1/;
+/include/ "picoxcell-pc3x2.dtsi"
+/ {
+ ? ? ? model = "Picochip PC7302 (PC3X2)";
+ ? ? ? compatible = "picochip,pc7302-pc3x2", "picochip,pc3x2";
+
+ ? ? ? memory {
+ ? ? ? ? ? ? ? device_type = "memory";
+ ? ? ? ? ? ? ? reg = <0x0 0x08000000>;
+ ? ? ? };
+
+ ? ? ? chosen {
+ ? ? ? ? ? ? ? bootargs = "console=ttyS0,115200 earlyprintk loglevel=9 root=ubi0:rootfs rw rootfstype=ubifs ubi.mtd=5,2048";
+ ? ? ? ? ? ? ? linux,stdout-path = &uart0;
+ ? ? ? };
+
+ ? ? ? clocks {
+ ? ? ? ? ? ? ? ref_clk: clock at 1 {
+ ? ? ? ? ? ? ? ? ? ? ? compatible = "fixed-clock";
+ ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "ref";
+ ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <20000000>;
+ ? ? ? ? ? ? ? };
+ ? ? ? };
+
+ ? ? ? rwid-axi {
+ ? ? ? ? ? ? ? ebi at 50000000 {
+ ? ? ? ? ? ? ? ? ? ? ? nand: gpio-nand at 2,0 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? compatible = "gpio-control-nand";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? #address-cells = <1>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? #size-cells = <1>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg = <2 0x0000 0x1000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? bus-clock = <&pclk>, "bus";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? gpio-control-nand,io-sync-reg =
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? <0x00000000 0x80220000>;
+
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? gpios = <&banka 1 0 ? ? /* rdy */
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&banka 2 0 ? ? /* nce */
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&banka 3 0 ? ? /* ale */
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&banka 4 0 ? ? /* cle */
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?0 ? ? ? ? ? ? ?/* nwp */>;
+
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? boot at 100000 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? label = "Boot";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg = <0x100000 0x80000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? redundant-boot at 200000 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? label = "Redundant Boot";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg = <0x200000 0x80000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? boot-env at 300000 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? label = "Boot Evironment";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg = <0x300000 0x20000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? redundant-boot-env at 320000 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? label = "Redundant Boot Environment";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg = <0x300000 0x20000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? kernel at 380000 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? label = "Kernel";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg = <0x380000 0x800000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? };
+
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? fs at b80000 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? label = "File System";
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg = <0xb80000 0xf480000>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? };
+ ? ? ? ? ? ? ? ? ? ? ? };
+ ? ? ? ? ? ? ? };
+ ? ? ? };
+};

arch/arm/boot/dts/picoxcell-pc7302-pc3x3.dts new file +25 -0

new file mode 100644
index 0000000..381eb6a
@@ -0,0 +1,93 @@
+/*
+ * ?Copyright (C) 2011 Picochip, Jamie Iles
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ?See the
+ * GNU General Public License for more details.
+ */
+
+/dts-v1/;
+/include/ "picoxcell-pc3x3.dtsi"
+/ {
+ ? ? ? model = "Picochip PC7302 (PC3X3)";
+ ? ? ? compatible = "picochip,pc7302-pc3x3", "picochip,pc3x3";
+
+ ? ? ? memory {
+ ? ? ? ? ? ? ? device_type = "memory";
+ ? ? ? ? ? ? ? reg = <0x0 0x08000000>;
+ ? ? ? };
+
+ ? ? ? chosen {

2011/8/24 Jamie Iles <[email protected]>:

Quoted 6 lines

+ ? ? ? clocks {
+ ? ? ? ? ? ? ? ref_clk: clock at 10 {
+ ? ? ? ? ? ? ? ? ? ? ? compatible = "fixed-clock";
+ ? ? ? ? ? ? ? ? ? ? ? clock-outputs = "ref";
+ ? ? ? ? ? ? ? ? ? ? ? clock-frequency = <20000000>;
+ ? ? ? ? ? ? ? };

ok. find it. is its name just "ref_clk"? could it be a pll/osc or some meaningful name?

arch/arm/boot/dts/picoxcell-pc7302-pc3x2.dts line 28

Quoted 4 lines · Jamie Iles

arch/arm/boot/dts/picoxcell-pc7302-pc3x2.dts new file +4 -0

+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk loglevel=9 root=ubi0:rootfs rw rootfstype=ubifs ubi.mtd=5,2048";
+		linux,stdout-path = &uart0;
+	};

Hrm... we don't normally put the bootargs in the device-tree.

Either you have a way to pass it from a previous firmware (which can then slap it into the device-tree at runtime), or you can have a way to compile it in the kernel image but the device-tree isn't the right place for it.

Quoted 9 lines · Jamie Iles

Quoted 5 lines

+ ? chosen {
+ ? ? ? ? ? bootargs = "console=ttyS0,115200 earlyprintk loglevel=9 root=ubi0:rootfs rw rootfstype=ubifs ubi.mtd=5,2048";
+ ? ? ? ? ? linux,stdout-path = &uart0;
+ ? };

Hrm... we don't normally put the bootargs in the device-tree.

Quoted 4 lines

Either you have a way to pass it from a previous firmware (which can then slap it into the device-tree at runtime), or you can have a way to compile it in the kernel image but the device-tree isn't the right place for it.

OK, that's fair enough. ?A few other ARM platforms (tegra, prima2 and zynq) have bootargs in the chosen node and that's where I got it from, but our bootloader has fdt support so this can easily be removed.

Thanks,

Jamie

2011/9/15 Jamie Iles <[email protected]>:

Quoted 15 lines · Benjamin Herrenschmidt

Quoted 13 lines · Jamie Iles

arch/arm/boot/dts/picoxcell-pc7302-pc3x2.dts line 28

Quoted 5 lines

arch/arm/boot/dts/picoxcell-pc7302-pc3x2.dts new file +4 -0

+   chosen {
+           bootargs = "console=ttyS0,115200 earlyprintk loglevel=9 root=ubi0:rootfs rw rootfstype=ubifs ubi.mtd=5,2048";
+           linux,stdout-path = &uart0;
+   };

Hrm... we don't normally put the bootargs in the device-tree.

Either you have a way to pass it from a previous firmware (which can then slap it into the device-tree at runtime), or you can have a way to compile it in the kernel image but the device-tree isn't the right place for it.

Quoted 3 lines

OK, that's fair enough. A few other ARM platforms (tegra, prima2 and zynq) have bootargs in the chosen node and that's where I got it from, but our bootloader has fdt support so this can easily be removed.

some powerpc platforms also do that:

asp834x-redboot.dts: bootargs = "console=ttyS0,38400
root=/dev/mtdblock3 rootfstype=jffs2";
gamecube.dts: bootargs = "root=/dev/gcnsda2 rootwait udbg-immortal";
prpmc2800.dts: bootargs = "ip=on";
rainier.dts: bootargs = "console=ttyS0,115200";
sequoia.dts: bootargs = "console=ttyS0,115200";
virtex440-ml507.dts: bootargs = "console=ttyS0 root=/dev/ram";
virtex440-ml510.dts: bootargs = "console=ttyS0 root=/dev/ram";
wii.dts: bootargs = "root=/dev/mmcblk0p2 rootwait udbg-immortal";

if we have no bootargs in bootloader, kernel will use that one in DT.

This series adds support for Picochip picoXcell (PC3X2 and PC3X3) ARM1176JZ-S based devices. This is a device tree only platform and currently supports interrupt controllers and UARTs.

This series is based off of Grant's devicetree/test branch and also uses Russell's io and gpio cleanup patches to remove the definition of IO_SPACE_LIMIT and trivial gpio definitions.

Changes since v1:

- Cleanup empty headers
- Use of_platform_populate() and the default match table
- Split the VIC's into separate device nodes

This series adds support for Picochip picoXcell (PC3X2 and PC3X3) ARM1176JZ-S based devices. This is a device tree only platform and currently supports interrupt controllers and UARTs.

This series is based off of Grant's devicetree/test branch and also uses Russell's io and gpio cleanup patches to remove the definition of IO_SPACE_LIMIT and trivial gpio definitions.

Changes since v1:

- Cleanup empty headers
- Use of_platform_populate() and the default match table
- Split the VIC's into separate device nodes

Jamie Iles (3):
picoxcell: support for Picochip picoxcell devices
picoxcell: add the DTS for pc3x2 and pc3x3 devices
picoxcell: add the DTS for the PC7302 board

Hi Arnd,

Is there likely to be any chance of getting support for picoxcell merged? This series can now be based on top of Nicolas' static IO mapping patches to remove some more code but I'm not sure what else I can do to make them easier to review!