Skip to contentSkip to conversation

cpufreq: db8500: remove unneeded for loop iteration over freq_table

RFC PATCH Superseded Axel Lin 2 participants 2 messages Sep 27, 2011 CPU frequency scaling framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

RFC PATCH 1/1 cpufreq: db8500: remove unneeded for loop iteration over freq_table

Don't know why to do the loop iteration here. It looks unneeded.

---
 drivers/cpufreq/db8500-cpufreq.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/cpufreq/db8500-cpufreq.c +0 -5
index d90456a..bdb349a 100644
@@ -104,7 +104,6 @@ static unsigned int db8500_cpufreq_getspeed(unsigned int cpu)
 static int __cpuinit db8500_cpufreq_init(struct cpufreq_policy *policy)
 {
 	int res;
-	int i;
 
 	BUILD_BUG_ON(ARRAY_SIZE(idx2opp) + 1 != ARRAY_SIZE(freq_table));
 
@@ -127,10 +126,6 @@ static int __cpuinit db8500_cpufreq_init(struct cpufreq_policy *policy)
 	policy->min = policy->cpuinfo.min_freq;
 	policy->max = policy->cpuinfo.max_freq;
 	policy->cur = db8500_cpufreq_getspeed(policy->cpu);
-
-	for (i = 0; freq_table[i].frequency != policy->cur; i++)
-		;
-
 	policy->governor = CPUFREQ_DEFAULT_GOVERNOR;
 
 	/*
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 1 line · Axel Lin

Don't know why to do the loop iteration here. It looks unneeded.

I'm OK with this going in, however I already have another patch on the CPUfreq driver pending for review that is more crucial and hopefully can go in first?

It sure looks odd. Jonas has some refactorings done on the CPUfreq driver, however they are dependent on the PRCMU update that is pending review for the MFD tree to go in first, so there is some code stacking up cross-subsystemwise right now.

Yours,
Linus Walleij