omap3evm: Pass 'mem' argument to linux kernel
PATCH v2 1/1 omap3evm: Pass 'mem' argument to linux kernel
In absence of this argument, Linux kernel doesn't boot.
Even though many newer boards support 256M, default value has been set to 128M to ensure that default build can boot older EVM variants.
---
Changes since v1:
Removed the string terminators "\0" from
definition of mmcargs and nandargs.
include/configs/omap3_evm.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
include/configs/omap3_evm.h +3 -0
@@ -200,11 +200,14 @@"loadaddr=0x82000000\0" \"usbtty=cdc_acm\0" \"mmcdev=0\0" \ +"memsize=128M\0" \"console=ttyO0,115200n8\0" \"mmcargs=setenv bootargs console=${console} " \ +"mem=${memsize} " \"root=/dev/mmcblk0p2 rw " \"rootfstype=ext3 rootwait\0" \"nandargs=setenv bootargs console=${console} " \ +"mem=${memsize} " \"root=/dev/mtdblock4 rw " \"rootfstype=jffs2\0" \"loadbootscript=fatload mmc ${mmcdev} ${loadaddr} boot.scr\0" \
Signature · 1 line
1.7.0.4
PATCH v2 1/1 omap3evm: Pass 'mem' argument to linux kernel
Quoted 7 lines · Sanjeev Premi
In absence of this argument, Linux kernel doesn't boot.
Even though many newer boards support 256M, default value has been set to 128M to ensure that default build can boot older EVM variants.
Signed-off-by Sanjeev Premi <[email protected]>
But you aren't addressing the fact you just limited everyone to 128M, which is not right. Please make this set the value to what u-boot detects the board to have at runtime at least.
Signature · 1 line
Tom
Premi
PATCH v2 1/1 omap3evm: Pass 'mem' argument to linux kernel
Quoted 15 lines
-----Original Message-----
From: Tom Rini [mailto:tom.rini at gmail.com]
Sent: Tuesday, September 27, 2011 9:29 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv2] omap3evm: Pass 'mem' argument to linux kernelQuoted 6 lines · Sanjeev Premi
In absence of this argument, Linux kernel doesn't boot.
Even though many newer boards support 256M, default value has been set to 128M to ensure that default build can boot older EVM variants.
Quoted 5 lines
Quoted 1 line
Signed-off-by Sanjeev Premi <[email protected]>But you aren't addressing the fact you just limited everyone to 128M, which is not right. Please make this set the value to what u-boot detects the board to have at runtime at least.
This patch changes the static environment string compiled on the host.
These is the default value that gets the board booting up. The environment variable memsize can be overwritten to 256M by the boards that have more memory. So, there is no hard limit.
...which I believe is better than kernel failing to load on old boards; leaving some users clueless about failure.
Detecting the actual memory size and then changing the environment variable can be a feature, but it isn't fool proof, because many applications esp on DM3730, use memory hole and would like their bootargs to be different.
~sanjeev
Quoted 4 lines
Signature · 2 lines
-- Tom
PATCH v2 1/1 omap3evm: Pass 'mem' argument to linux kernel
Quoted 29 lines · Sanjeev
Quoted 15 lines
-----Original Message-----
From: Tom Rini [mailto:tom.rini at gmail.com]
Sent: Tuesday, September 27, 2011 9:29 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv2] omap3evm: Pass 'mem' argument to linux kernelQuoted 6 lines · Sanjeev Premi
In absence of this argument, Linux kernel doesn't boot.
Even though many newer boards support 256M, default value has been set to 128M to ensure that default build can boot older EVM variants.
Quoted 5 lines
Quoted 1 line
Signed-off-by Sanjeev Premi <[email protected]>But you aren't addressing the fact you just limited everyone to 128M, which is not right. ?Please make this set the value to what u-boot detects the board to have at runtime at least.
This patch changes the static environment string compiled on the host.
These is the default value that gets the board booting up. The environment variable memsize can be overwritten to 256M by the boards that have more memory. So, there is no hard limit.
Quoted 7 lines
...which I believe is better than kernel failing to load on old boards; leaving some users clueless about failure.
Detecting the actual memory size and then changing the environment variable can be a feature, but it isn't fool proof, because many applications esp on DM3730, use memory hole and would like their bootargs to be different.
Thanks for explaining. Given that someone else objected to this on the same grounds against v1 please try and add that type of info to the email in the future.
Signature · 1 line
Tom
Premi
PATCH v2 1/1 omap3evm: Pass 'mem' argument to linux kernel
Quoted 39 lines
From: Tom Rini [tom.rini at gmail.com]
Sent: Wednesday, September 28, 2011 12:59 AM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv2] omap3evm: Pass 'mem' argument to linux kernelQuoted 32 lines · Sanjeev
Quoted 15 lines
-----Original Message-----
From: Tom Rini [mailto:tom.rini at gmail.com]
Sent: Tuesday, September 27, 2011 9:29 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCHv2] omap3evm: Pass 'mem' argument to linux kernelQuoted 6 lines · Sanjeev Premi
In absence of this argument, Linux kernel doesn't boot.
Even though many newer boards support 256M, default value has been set to 128M to ensure that default build can boot older EVM variants.
Quoted 5 lines
Quoted 1 line
Signed-off-by Sanjeev Premi <[email protected]>But you aren't addressing the fact you just limited everyone to 128M, which is not right. Please make this set the value to what u-boot detects the board to have at runtime at least.
This patch changes the static environment string compiled on the host.
These is the default value that gets the board booting up. The environment variable memsize can be overwritten to 256M by the boards that have more memory. So, there is no hard limit.
...which I believe is better than kernel failing to load on old boards; leaving some users clueless about failure.
Quoted 8 lines
Quoted 4 lines
Detecting the actual memory size and then changing the environment variable can be a feature, but it isn't fool proof, because many applications esp on DM3730, use memory hole and would like their bootargs to be different.
Thanks for explaining. Given that someone else objected to this on the same grounds against v1 please try and add that type of info to the email in the future.
I did miss the mail from Igor, and responded to him later. The patch describes the reason for choosing 128M - which i considered sufficient. It didn't occur to me that changes to CONFIG_BOOTARGS could/ would be considered as hard limit - else I would have described.
~sanjeev
Quoted 4 lines
--
Tom
PATCH v2 1/1 omap3evm: Pass 'mem' argument to linux kernel
In reply to PremiDear "Premi, Sanjeev",
Quoted 5 lines · In message <[email protected]> you…
These is the default value that gets the board booting up. The environment variable memsize can be overwritten to 256M by the boards that have more memory. So, there is no hard limit.
Why the hell would you ever want to do that? U-Boot is capable of auto-detecting the actual RAM sioze and passing correct information to Linux, so why do you meddle with this?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Here is an Appalachian version of management's answer to those who are concerned with the fate of the project: "Don't worry about the mule. Just load the wagon." - Mike Dennison's hillbilly uncle
PATCH v2 1/1 omap3evm: Pass 'mem' argument to linux kernel
In reply to Sanjeev PremiDear Sanjeev Premi,
Quoted 6 lines · In message <[email protected]> you wrote:
In absence of this argument, Linux kernel doesn't boot.
Even though many newer boards support 256M, default value has been set to 128M to ensure that default build can boot older EVM variants.
Quoted 8 lines
Signed-off-by Sanjeev Premi <[email protected]>---
Changes since v1:
Removed the string terminators "\0" from
definition of mmcargs and nandargs.include/configs/omap3_evm.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
My questions remain: why cannot we simple remove these mem+ settings which cause only harm?
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de In C we had to code our own bugs, in C++ we can inherit them.