Skip to contentSkip to conversation

ASoC: adau1701: Initialize codec->control_data before using it

PATCH In review Axel Lin 2 participants 3 messages Sep 28, 2011

Subsystems (3)
Sound ASoC Analog devices inc ASoC codec drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: adau1701: Initialize codec->control_data before using it

Currently codec->control_data is not initialized before calling process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE).

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/adau1701.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/codecs/adau1701.c +1 -0
index b7e4cc7..8b7e1c5 100644
@@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec)
 	int ret;
 
 	codec->dapm.idle_bias_off = 1;
+	codec->control_data = to_i2c_client(codec->dev);
 
 	ret = adau1701_load_firmware(codec);
 	if (ret)
Signature · 1 line
1.7.4.1
author
#1 lore raw

2011/9/28 Axel Lin <[email protected]>:

Quoted 5 lines

Currently codec->control_data is not initialized before calling process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE).

Signed-off-by Axel Lin <[email protected]>

---

This one is a v2 of original patch.
Sorry, forgot to add v2 in the subject line.

Quoted 21 lines

 sound/soc/codecs/adau1701.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/codecs/adau1701.c +1 -1
index b7e4cc7..8b7e1c5 100644
@@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec)
        int ret;
 
        codec->dapm.idle_bias_off = 1;
+       codec->control_data = to_i2c_client(codec->dev);
 
        ret = adau1701_load_firmware(codec);
        if (ret)
--

1.7.4.1

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Axel Lin
Quoted 4 lines · Axel Lin

Currently codec->control_data is not initialized before calling process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE).

Signed-off-by Axel Lin <[email protected]>
Acked-by Lars-Peter Clausen <[email protected]>

Thanks

Quoted 16 lines
---
 sound/soc/codecs/adau1701.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/codecs/adau1701.c +1 -0
index b7e4cc7..8b7e1c5 100644
@@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec)
 	int ret;
 
 	codec->dapm.idle_bias_off = 1;
+	codec->control_data = to_i2c_client(codec->dev);
 
 	ret = adau1701_load_firmware(codec);
 	if (ret)