backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity
Subsystems (2)
PATCH 1/1 backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity
The rename of corgibl_limit_intensity is missed in commit d00ba726 "backlight: Rename the corgi backlight driver to generic". Let's fix it now.
--- drivers/video/backlight/generic_bl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/backlight/generic_bl.c +2 -2
@@ -56,7 +56,7 @@ static int genericbl_get_intensity(struct backlight_device *bd)* Called when the battery is low to limit the backlight intensity. * If limit==0 clear any limit, otherwise limit the intensity */ -void corgibl_limit_intensity (int limit) +void genericbl_limit_intensity (int limit) {struct backlight_device *bd = generic_backlight_device;
@@ -68,7 +68,7 @@ void corgibl_limit_intensity(int limit)backlight_update_status (generic_backlight_device);mutex_unlock (&bd->ops_lock); } -EXPORT_SYMBOL (corgibl_limit_intensity); +EXPORT_SYMBOL (genericbl_limit_intensity);static const struct backlight_ops genericbl_ops = { .options =BL_CORE_SUSPENDRESUME ,
Signature · 1 line
1.7.4.1
Quoted 24 lines · On Sun, 25 Sep 2011 10:12:33 +0800 Axel Lin <[email protected]> wrote:
The rename of
corgibl_limit_intensityis missed in commitd00ba726"backlight: Rename the corgi backlight driver to generic". Let's fix it now.Signed-off-by Axel Lin <[email protected]>Cc Richard Purdie <[email protected]>--- drivers/video/backlight/generic_bl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/video/backlight/generic_bl.c +1
-1@@ -56,7 +56,7 @@ static int genericbl_get_intensity(struct backlight_device *bd)* Called when the battery is low to limit the backlight intensity. * If limit==0 clear any limit, otherwise limit the intensity */ -void corgibl_limit_intensity (int limit) +void genericbl_limit_intensity (int limit) {struct backlight_device *bd = generic_backlight_device;
drivers/video/backlight/generic_bl.c void corgibl_limit_intensity(int limit) · line 72
Quoted 6 lines
drivers/video/backlight/generic_bl.c +1
-1@@ -68,7 +68,7 @@ void corgibl_limit_intensity(int limit)backlight_update_status (generic_backlight_device);mutex_unlock (&bd->ops_lock); } -EXPORT_SYMBOL (corgibl_limit_intensity); +EXPORT_SYMBOL (genericbl_limit_intensity);
Why does corgibl_limit_intensity/genericbl_limit_intensity exist? Nothing in the tree references it?
Quoted 26 lines · Andrew Morton
Quoted 23 lines · On Sun, 25 Sep 2011 10:12:33 +0800 Axel Lin <[email protected]> wrote:
The rename of
corgibl_limit_intensityis missed in commitd00ba726"backlight: Rename the corgi backlight driver to generic". Let's fix it now.Signed-off-by Axel Lin <[email protected]>Cc Richard Purdie <[email protected]>--- drivers/video/backlight/generic_bl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/video/backlight/generic_bl.c +1
-1@@ -56,7 +56,7 @@ static int genericbl_get_intensity(struct backlight_device *bd)* Called when the battery is low to limit the backlight intensity. * If limit==0 clear any limit, otherwise limit the intensity */ -void corgibl_limit_intensity (int limit) +void genericbl_limit_intensity (int limit) {struct backlight_device *bd = generic_backlight_device;
Quoted 10 lines
drivers/video/backlight/generic_bl.c void corgibl_limit_intensity(int limit) · line 72
Quoted 7 lines
drivers/video/backlight/generic_bl.c +1
-1@@ -68,7 +68,7 @@ void corgibl_limit_intensity(int limit)backlight_update_status (generic_backlight_device);mutex_unlock (&bd->ops_lock); } -EXPORT_SYMBOL (corgibl_limit_intensity); +EXPORT_SYMBOL (genericbl_limit_intensity);Why does corgibl_limit_intensity/genericbl_limit_intensity exist? Nothing in the tree references it?
It sounds like someone has removed the sharpsl battery driver which did use this. If this hook isn't used, low battery with high screen backlight values will reset the device as the wiring isn't up to the current draw.
Richard
Quoted 8 lines
Quoted 2 lines
Why does corgibl_limit_intensity/genericbl_limit_intensity exist? Nothing in the tree references it?
It sounds like someone has removed the sharpsl battery driver which did use this. If this hook isn't used, low battery with high screen backlight values will reset the device as the wiring isn't up to the current draw.
It is removed by commit 13a542475d1c62a12c77abfa83a790245598fc61
Author: Christoph Egger <[email protected]> Date: Sun Jul 4 23:24:52 2010 +0800
[ARM] pxa: removing dead BACKLIGHT_CORGI
BACKLIGHT_CORGI was later renamed to BACKLIGHT_GENERIC and has not been used since then. As it's now safe to completely transition to LCD_CORGI driver, which incorprates both the LCD and backlight device.
So, should we remove corgibl_limit_intensity/genericbl_limit_intensity since now it is not being used?
Quoted 4 lines
Richard
Quoted 18 lines · Axel Lin
Quoted 8 lines
Quoted 2 lines
Why does corgibl_limit_intensity/genericbl_limit_intensity exist? Nothing in the tree references it?
It sounds like someone has removed the sharpsl battery driver which did use this. If this hook isn't used, low battery with high screen backlight values will reset the device as the wiring isn't up to the current draw.
It is removed by commit
13a542475d1c62a12c77abfa83a790245598fc61Author: Christoph Egger <[email protected]> Date: Sun Jul 4 23:24:52 2010 +0800[ARM] pxa: removing dead
BACKLIGHT_CORGI
BACKLIGHT_CORGIwas later renamed toBACKLIGHT_GENERICand has not been used since then. As it's now safe to completely transition toLCD_CORGIdriver, which incorprates both the LCD and backlight device.
Quoted 5 lines
Signed-off-by Christoph Egger <[email protected]>Signed-off-by Eric Miao <[email protected]>So, should we remove corgibl_limit_intensity/genericbl_limit_intensity since now it is not being used?
Does that code workaround the hardware issue I mention? I suspect not. It seems nobody cares about that at this point though...
Cheers,
Richard