Skip to contentSkip to conversation

mtd: r852: make r852_pm_ops static

PATCH Applied Axel Lin 2 participants 2 messages Sep 26, 2011 – Oct 1, 2011

Subsystems (2)
Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH v2 1/1 mtd: r852: make r852_pm_ops static

It is not used outside this driver so no need to make the symbol global. Also make r852_suspend and r852_resume static.

Signed-off-by Axel Lin <[email protected]>

---
v2: Also make r852_suspend and r852_resume static

 drivers/mtd/nand/r852.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/mtd/nand/r852.c +3 -3
index cae2e01..f20f393 100644
@@ -1027,7 +1027,7 @@ void r852_shutdown(struct pci_dev *pci_dev)
 }
 
 #ifdef CONFIG_PM
-int r852_suspend(struct device *device)
+static int r852_suspend(struct device *device)
 {
 	struct r852_device *dev = pci_get_drvdata(to_pci_dev(device));
 

@@ -1048,7 +1048,7 @@ int r852_suspend(struct device *device)
 	return 0;
 }
 
-int r852_resume(struct device *device)
+static int r852_resume(struct device *device)
 {
 	struct r852_device *dev = pci_get_drvdata(to_pci_dev(device));
 

@@ -1092,7 +1092,7 @@ static const struct pci_device_id r852_pci_id_tbl[] = {
 
 MODULE_DEVICE_TABLE(pci, r852_pci_id_tbl);
 
-SIMPLE_DEV_PM_OPS(r852_pm_ops, r852_suspend, r852_resume);
+static SIMPLE_DEV_PM_OPS(r852_pm_ops, r852_suspend, r852_resume);
 
 static struct pci_driver r852_pci_driver = {
 	.name		= DRV_NAME,
Signature · 1 line
1.7.4.1
Applied
#1 lore raw
Quoted 6 lines · Axel Lin

It is not used outside this driver so no need to make the symbol global. Also make r852_suspend and r852_resume static.

Signed-off-by Axel Lin <[email protected]>

---
v2: Also make r852_suspend and r852_resume static

Pushed to l2-mtd-2.6.git, thanks!

Signature · 12 lines
Best Regards,
Artem Bityutskiy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.