ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC

PATCH In review Axel Lin 2 participants 2 messages Oct 2, 2011

Subsystems (3)

Sound ASoC Wolfson microelectronics drivers

lore

Share & tools

lore

Axel Lin

author

2011-10-02 12:41 UTC #0 lore raw

PATCH 1/1 ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC

Current code set update bits for WM8753_LDAC and WM8753_RDAC twice, but missed setting update bits for WM8753_LADC and WM8753_RADC.

I think it is a copy-paste bug in commit 776065 "ASoC: codecs: wm8753: Fix register cache incoherency".

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/codecs/wm8753.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

sound/soc/codecs/wm8753.c +2 -2

index fe04a10..a950471 100644
@@ -1455,8 +1455,8 @@ static int wm8753_probe(struct snd_soc_codec *codec)
 	/* set the update bits */
 	snd_soc_update_bits(codec, WM8753_LDAC, 0x0100, 0x0100);
 	snd_soc_update_bits(codec, WM8753_RDAC, 0x0100, 0x0100);
-	snd_soc_update_bits(codec, WM8753_LDAC, 0x0100, 0x0100);
-	snd_soc_update_bits(codec, WM8753_RDAC, 0x0100, 0x0100);
+	snd_soc_update_bits(codec, WM8753_LADC, 0x0100, 0x0100);
+	snd_soc_update_bits(codec, WM8753_RADC, 0x0100, 0x0100);
 	snd_soc_update_bits(codec, WM8753_LOUT1V, 0x0100, 0x0100);
 	snd_soc_update_bits(codec, WM8753_ROUT1V, 0x0100, 0x0100);
 	snd_soc_update_bits(codec, WM8753_LOUT2V, 0x0100, 0x0100);

Signature · 1 line

1.7.4.1

Mark Brown

2011-10-02 18:56 UTC #1 lore raw

Quoted 5 lines · Axel Lin

Current code set update bits for WM8753_LDAC and WM8753_RDAC twice, but missed setting update bits for WM8753_LADC and WM8753_RADC.
I think it is a copy-paste bug in commit 776065 "ASoC: codecs: wm8753: Fix register cache incoherency".

Looks like it, yes. Applied, thanks.