Skip to contentSkip to conversation

ASoC: Fix setting update bits for WM8741_DACRMSB_ATTENUATION

PATCH Applied Axel Lin 2 participants 2 messages Oct 3, 2011

Subsystems (3)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: Fix setting update bits for WM8741_DACRMSB_ATTENUATION

After checking the code and datasheet, I think what we want in the second snd_soc_update_bits call is to update WM8741_DACRMSB_ATTENUATION register instead of WM8741_DACRLSB_ATTENUATION.

---
I don't have this hardware handy, thus I only check the the code and datasheet. The bug is there since commit 992bee40 "ASoC: Initial WM8741 CODEC driver". I'd appreciate if someone can test this patch.

Regards,
Axel

 sound/soc/codecs/wm8741.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/codecs/wm8741.c +1 -1
index 78c9e5a..a42b282 100644
@@ -462,7 +462,7 @@ static int wm8741_probe(struct snd_soc_codec *codec)
 			    WM8741_UPDATELM, WM8741_UPDATELM);
 	snd_soc_update_bits(codec, WM8741_DACRLSB_ATTENUATION,
 			    WM8741_UPDATERL, WM8741_UPDATERL);
-	snd_soc_update_bits(codec, WM8741_DACRLSB_ATTENUATION,
+	snd_soc_update_bits(codec, WM8741_DACRMSB_ATTENUATION,
 			    WM8741_UPDATERM, WM8741_UPDATERM);
 
 	snd_soc_add_controls(codec, wm8741_snd_controls,
Signature · 1 line
1.7.4.1
Applied
#1 lore raw
Quoted 3 lines · Axel Lin

After checking the code and datasheet, I think what we want in the second snd_soc_update_bits call is to update WM8741_DACRMSB_ATTENUATION register instead of WM8741_DACRLSB_ATTENUATION.

Applied, thanks.