Skip to contentSkip to conversation

ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF

PATCH Applied Axel Lin 3 participants 4 messages Oct 3, 2011 – Oct 4, 2011

Subsystems (3)
Sound ASoC Wolfson microelectronics drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF

This assignment is done by the snd_soc_register_codec so there is no need to redo it in probe function of a codec driver.

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/sn95031.c |    1 -
 sound/soc/codecs/wm5100.c  |    2 --
 sound/soc/codecs/wm8996.c  |    1 -
 3 files changed, 0 insertions(+), 4 deletions(-)
sound/soc/codecs/sn95031.c +0 -1
index adb85bf..09c4593 100644
@@ -827,7 +827,6 @@ static int sn95031_codec_probe(struct snd_soc_codec *codec)
 {
 	pr_debug("codec_probe called\n");
 
-	codec->dapm.bias_level = SND_SOC_BIAS_OFF;
 	codec->dapm.idle_bias_off = 1;
 
 	/* PCM interface config
sound/soc/codecs/wm5100.c +0 -2
index f603989..46afdf86 100644
@@ -2285,8 +2285,6 @@ static int wm5100_probe(struct snd_soc_codec *codec)
 
 	wm5100->codec = codec;
 
-	codec->dapm.bias_level = SND_SOC_BIAS_OFF;
-
 	ret = snd_soc_codec_set_cache_io(codec, 16, 16, SND_SOC_I2C);
 	if (ret != 0) {
 		dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret);
sound/soc/codecs/wm8996.c +0 -1
index b98a8f8..43e46c7 100644
@@ -2706,7 +2706,6 @@ static int wm8996_probe(struct snd_soc_codec *codec)
 	init_completion(&wm8996->fll_lock);
 
 	dapm->idle_bias_off = true;
-	dapm->bias_level = SND_SOC_BIAS_OFF;
 
 	ret = snd_soc_codec_set_cache_io(codec, 16, 16, SND_SOC_I2C);
 	if (ret != 0) {
Signature · 1 line
1.7.4.1
Applied
#1 lore raw
Quoted 2 lines · Axel Lin

This assignment is done by the snd_soc_register_codec so there is no need to redo it in probe function of a codec driver.

Applied, thanks.

#2 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

This assignment is done by the snd_soc_register_codec so there is no need to redo it in probe function of a codec driver.

Axel, please stop CCing Harsha Priya on patches - you should've noticed that his address bounces by now.

#3 lore raw
Quoted 6 lines · Mark Brown
Quoted 2 lines · Axel Lin

This assignment is done by the snd_soc_register_codec so there is no need to redo it in probe function of a codec driver.

Axel, please stop CCing Harsha Priya on patches - you should've noticed that his address bounces by now.

Hmmm, i can send a patch to update her email id. But for now i dont think she will work on kernel

Signature · 1 line
~Vinod