input: wacom - Lower the LED luminance

PATCH In review Ping Cheng 1 participant 2 messages Oct 4, 2011

Subsystems (2)

HID Input drivers

lore

Share & tools

lore

Ping Cheng

author

2011-10-04 00:01 UTC #0 lore raw

PATCH 1/4 input: wacom - Lower the LED luminance

The LED luminance level is normally lower when no button is pressed.

Reviewed-by Eduard Hasenleithner <[email protected]>

Tested-by Eduard Hasenleithner <[email protected]>

Signed-off-by Ping Cheng <[email protected]>

---
 Documentation/ABI/testing/sysfs-driver-wacom |    3 ++-
 drivers/input/tablet/wacom_sys.c             |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

Documentation/ABI/testing/sysfs-driver-wacom +2 -1

index dfe1d46..b1d5c17 100644
@@ -25,7 +25,8 @@ Contact:	[email protected]
 Description:
 		Writing to this file sets the status LED luminance (0..127)
 		when the stylus does not touch the tablet surface, and no
-		button is pressed on the stylus.
+		button is pressed on the stylus. This luminance level is
+		normally lower than the level when a button is pressed.
 
 What:		/sys/bus/usb/devices/<busnum>-<devnum>:<cfg>.<intf>/wacom_led/status1_luminance
 Date:		August 2011

drivers/input/tablet/wacom_sys.c +1 -1

index 0eccf57..7facacc 100644
@@ -678,7 +678,7 @@ static int wacom_initialize_leds(struct wacom *wacom)
 
 		/* Initialize default values */
 		wacom->led.select = 0;
-		wacom->led.llv = 30;
+		wacom->led.llv = 10;
 		wacom->led.hlv = 20;
 		wacom->led.img_lum = 10;
 		wacom_led_control(wacom);

Signature · 1 line

1.7.6

Ping Cheng

author

2011-10-04 15:26 UTC #1 lore raw

All four patches in this set were reviewed-by and signed-off-by Eduard Hasenleithner. Somehow I missed those tags in the other patches.

Ping

Quoted 38 lines · Ping Cheng

The LED luminance level is normally lower when no button is pressed.
Reviewed-by Eduard Hasenleithner <[email protected]>
Tested-by Eduard Hasenleithner <[email protected]>
Signed-off-by Ping Cheng <[email protected]>
---
Documentation/ABI/testing/sysfs-driver-wacom | 3 ++- drivers/input/tablet/wacom_sys.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-driver-wacom +0 -0
index dfe1d46..b1d5c17 100644
@@ -25,7 +25,8 @@ Contact:      [email protected]
Description:
Writing to this file sets the status LED luminance (0..127) when the stylus does not touch the tablet surface, and no
- button is pressed on the stylus.
+ button is pressed on the stylus. This luminance level is
+ normally lower than the level when a button is pressed.
What: /sys/bus/usb/devices/<busnum>-<devnum>:<cfg>.<intf>/wacom_led/status1_luminance
Date: August 2011
drivers/input/tablet/wacom_sys.c +1 -2
index 0eccf57..7facacc 100644
@@ -678,7 +678,7 @@ static int wacom_initialize_leds(struct wacom *wacom)
 
                /* Initialize default values */
                wacom->led.select = 0;
-               wacom->led.llv = 30;
+               wacom->led.llv = 10;
                wacom->led.hlv = 20;
                wacom->led.img_lum = 10;
                wacom_led_control(wacom);
--

Quoted 3 lines

1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html