Skip to contentSkip to conversation

input: wacom - don't expose LED inactive option

PATCH In review Ping Cheng 1 participant 1 message Oct 4, 2011

Subsystems (2)
lore
Share & tools
lore

Ping Cheng

author
#0 lore raw

PATCH 2/4 input: wacom - don't expose LED inactive option

The LED also indicates the status of the tablet. Don't turn it off.

---
 Documentation/ABI/testing/sysfs-driver-wacom |    8 +++-----
 drivers/input/tablet/wacom.h                 |    6 +++---
 2 files changed, 6 insertions(+), 8 deletions(-)
Documentation/ABI/testing/sysfs-driver-wacom +3 -5
index b1d5c17..b560185 100644
@@ -23,7 +23,7 @@ What:		/sys/bus/usb/devices/<busnum>-<devnum>:<cfg>.<intf>/wacom_led/status0_lum
 Date:		August 2011
 Contact:	[email protected]
 Description:
-		Writing to this file sets the status LED luminance (0..127)
+		Writing to this file sets the status LED luminance (1..127)
 		when the stylus does not touch the tablet surface, and no
 		button is pressed on the stylus. This luminance level is
 		normally lower than the level when a button is pressed.
@@ -32,7 +32,7 @@ What:		/sys/bus/usb/devices/<busnum>-<devnum>:<cfg>.<intf>/wacom_led/status1_lum
 Date:		August 2011
 Contact:	[email protected]
 Description:
-		Writing to this file sets the status LED luminance (0..127)
+		Writing to this file sets the status LED luminance (1..127)
 		when the stylus touches the tablet surface, or any button is
 		pressed on the stylus.
 
@@ -41,9 +41,7 @@ Date:		August 2011
 Contact:	[email protected]
 Description:
 		Writing to this file sets which one of the four status LEDs is
-		active (0..3). The other three LEDs are always inactive.  By
-		means of specifying "-1" it is possible to set all status LEDs
-		to inactive.
+		active (0..3). The other three LEDs are always inactive.
 
 What:		/sys/bus/usb/devices/<busnum>-<devnum>:<cfg>.<intf>/wacom_led/buttons_luminance
 Date:		August 2011
drivers/input/tablet/wacom.h +3 -3
index 00332d66..561f107 100644
@@ -115,9 +115,9 @@ struct wacom {
 	bool open;
 	char phys[32];
 	struct wacom_led {
-		u8 select; /* status led selector (0..3, -1=none) */
-		u8 llv;    /* status led brightness no button */
-		u8 hlv;    /* status led brightness button pressed */
+		u8 select; /* status led selector (0..3) */
+		u8 llv;    /* status led brightness no button (1..127) */
+		u8 hlv;    /* status led brightness button pressed (1..127) */
 		u8 img_lum;   /* OLED matrix display brightness */
 	} led;
 };
Signature · 1 line
1.7.6