Skip to contentSkip to conversation

leds: leds-lm3530: Add __devexit_p at necessary place

PATCH In review Axel Lin 2 participants 2 messages Oct 5, 2011 LED

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 leds: leds-lm3530: Add __devexit_p at necessary place

According to the comments in include/linux/init.h:

"Pointers to __devexit functions must use __devexit_p(function_name), the wrapper will insert either the function_name or NULL, depending on the config options."

We have __devexit annotation for lm3530_remove(), thus add __devexit_p at necessary place.

---
 drivers/leds/leds-lm3530.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/leds-lm3530.c +1 -1
index 15c1733..0630e4f 100644
@@ -449,7 +449,7 @@ MODULE_DEVICE_TABLE(i2c, lm3530_id);
 
 static struct i2c_driver lm3530_i2c_driver = {
 	.probe = lm3530_probe,
-	.remove = lm3530_remove,
+	.remove = __devexit_p(lm3530_remove),
 	.id_table = lm3530_id,
 	.driver = {
 		.name = LM3530_NAME,
Signature · 1 line
1.7.4.1
Acked-by on v1 1/1
#1 lore raw

2011/10/5 Axel Lin <[email protected]>:

Quoted 10 lines

According to the comments in include/linux/init.h:

"Pointers to __devexit functions must use __devexit_p(function_name), the wrapper will insert either the function_name or NULL, depending on the config options."

We have __devexit annotation for lm3530_remove(), thus add __devexit_p at necessary place.

Thanks Axel,
Linus Walleij