Skip to contentSkip to conversation

intel_reg_checker: New tool to accumulate checks for HW workarounds.

PATCH In review Eric Anholt 4 participants 7 messages Oct 13, 2011 – Oct 18, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 intel_reg_checker: New tool to accumulate checks for HW workarounds.

---

I kept reviewing the B-Spec on systems with weird issues and hand-decoding each interesting register (for example, is everything still sane after resume?), so here's a tool to do so automatically.

 tools/Makefile.am         |    1 +
 tools/intel_reg_checker.c |  399 +++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 400 insertions(+), 0 deletions(-)
 create mode 100644 tools/intel_reg_checker.c
tools/Makefile.am +1 -0
index 3dc5603..bc7fe3a 100644
@@ -9,6 +9,7 @@ bin_PROGRAMS = \
 	intel_gpu_time \
 	intel_gtt \
 	intel_stepping \
+	intel_reg_checker \
 	intel_reg_dumper \
 	intel_reg_snapshot \
 	intel_reg_write \
tools/intel_reg_checker.c new file +399 -0

399 lines not on this page · raw message

Signature · 6 lines
1.7.6.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 5 lines · On Thu, 13 Oct 2011 16:07:57 -0700 Eric Anholt <[email protected]> wrote:

---

I kept reviewing the B-Spec on systems with weird issues and hand-decoding each interesting register (for example, is everything still sane after resume?), so here's a tool to do so automatically.

I was really hoping we could use the bxml to automate something like this. Has anyone looked into doing that?

#2 lore raw
Quoted 12 lines · Ben Widawsky
Quoted 5 lines · On Thu, 13 Oct 2011 16:07:57 -0700 Eric Anholt <[email protected]> wrote:

---

I kept reviewing the B-Spec on systems with weird issues and hand-decoding each interesting register (for example, is everything still sane after resume?), so here's a tool to do so automatically.

I was really hoping we could use the bxml to automate something like this. Has anyone looked into doing that?

I did, but I probably won't come up with something useable in nearby future.

So I like this tool, simple yet very functional, amazing job Eric!

Signature · 2 lines
Eugeni Dodonov
<http://eugeni.dodonov.net/>

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Ben Widawsky
Quoted 11 lines · Ben Widawsky
Quoted 5 lines · On Thu, 13 Oct 2011 16:07:57 -0700 Eric Anholt <[email protected]> wrote:

---

I kept reviewing the B-Spec on systems with weird issues and hand-decoding each interesting register (for example, is everything still sane after resume?), so here's a tool to do so automatically.

I was really hoping we could use the bxml to automate something like this. Has anyone looked into doing that?

How are you going to parse the english text in the xml to decide what the correct value is? That's the useful part of this tool, not just decoding bitfields like intel_reg_dumper.

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Eric Anholt

2011/10/13 Eric Anholt <[email protected]>:

Quoted 10 lines

---

I kept reviewing the B-Spec on systems with weird issues and hand-decoding each interesting register (for example, is everything still sane after resume?), so here's a tool to do so automatically.

 tools/Makefile.am         |    1 +
 tools/intel_reg_checker.c |  399 +++++++++++++++++++++++++++++++++++++++++++++

 2 files changed, 400 insertions(+), 0 deletions(-)

 create mode 100644 tools/intel_reg_checker.c

Excellent!

Maybe we should move it to tests/ and run automatically on "make check"?

Signature · 1 line
Paulo Zanoni
#5 lore raw
Quoted 7 lines · Paulo Zanoni

2011/10/13 Eric Anholt <[email protected]>:

Quoted 6 lines

---

I kept reviewing the B-Spec on systems with weird issues and hand-decoding each interesting register (for example, is everything still sane after resume?), so here's a tool to do so automatically.

Quoted 8 lines
Quoted 4 lines

 tools/Makefile.am         |    1 +
 tools/intel_reg_checker.c |  399 +++++++++++++++++++++++++++++++++++++++++++++

 2 files changed, 400 insertions(+), 0 deletions(-)

 create mode 100644 tools/intel_reg_checker.c

Excellent!

Maybe we should move it to tests/ and run automatically on "make check"?

It might be usable from make check, but I do see this as an installed tool like intel_reg_dumper.

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by
#6 lore raw
Quoted 15 lines · Eric Anholt
Quoted 9 lines · Paulo Zanoni

2011/10/13 Eric Anholt <[email protected]>:

Quoted 8 lines

---

I kept reviewing the B-Spec on systems with weird issues and hand-decoding each interesting register (for example, is everything still sane after resume?), so here's a tool to do so automatically.

 tools/Makefile.am         |    1 +
 tools/intel_reg_checker.c |  399

+++++++++++++++++++++++++++++++++++++++++++++

Quoted 3 lines
Quoted 2 lines
 2 files changed, 400 insertions(+), 0 deletions(-)
 create mode 100644 tools/intel_reg_checker.c
Quoted 7 lines
Quoted 3 lines

Excellent!

Maybe we should move it to tests/ and run automatically on "make check"?

It might be usable from make check, but I do see this as an installed tool like intel_reg_dumper.

It works nicely for me, so:

Signature · 2 lines
Eugeni Dodonov
 <http://eugeni.dodonov.net/>

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx