Skip to contentSkip to conversation

mesa-dri: Enable swrast only by default and intel drivers only on IA platform

PATCH In review Richard Purdie 5 participants 10 messages Oct 14, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mesa-dri: Enable swrast only by default and intel drivers only on IA platform

---

meta/recipes-graphics/mesa/mesa-dri.inc +5 -1
index 603438e..795144a 100644
@@ -4,7 +4,11 @@ LIB_DEPS += "libdrm expat"
 # most of our targets do not have DRI so will use mesa-xlib
 DEFAULT_PREFERENCE = "-1"
 
-EXTRA_OECONF += "--with-driver=dri --disable-egl --disable-gallium --without-gallium-drivers"
+DRIDRIVERS = "swrast"
+DRIDRIVERS_x86 = "swrast,i915,i965"
+DRIDRIVERS_x86-64 = "swrast,i915,i965"
+
+EXTRA_OECONF += "--with-driver=dri --disable-egl --disable-gallium --without-gallium-drivers --with-dri-drivers=${DRIDRIVERS}"
 
 python populate_packages_prepend() {
 	import os.path
meta/recipes-graphics/mesa/mesa-dri_7.11.bb +0 -4
index 6a4f9a9..5d25127 100644
@@ -2,7 +2,3 @@ include mesa-common.inc
 include mesa-${PV}.inc
 include mesa-dri.inc
 PR = "${INC_PR}.0"
-
-EXTRA_OECONF += "--with-dri-drivers=swrast,i915,i965"
-
-COMPATIBLE_HOST = '(i.86.*-linux|x86_64.*-linux)'
meta/recipes-graphics/mesa/mesa-dri_git.bb +0 -2
index 15cde60..a0e1945 100644
@@ -7,5 +7,3 @@ DEFAULT_PREFERENCE = "-2"
 
 PR = "${INC_PR}.0"
 
-COMPATIBLE_HOST = '(i.86|x86_64).*-linux'
-
#1 lore raw

+1

Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can override it.

Quoted 49 lines · Richard Purdie

---

meta/recipes-graphics/mesa/mesa-dri.inc +0 -0
index 603438e..795144a 100644
@@ -4,7 +4,11 @@ LIB_DEPS += "libdrm expat"
  # most of our targets do not have DRI so will use mesa-xlib

 DEFAULT_PREFERENCE = "-1"

meta/recipes-graphics/mesa/mesa-dri.inc +5 -1
-EXTRA_OECONF += "--with-driver=dri --disable-egl --disable-gallium --without-gallium-drivers"
+DRIDRIVERS = "swrast"
+DRIDRIVERS_x86 = "swrast,i915,i965"
+DRIDRIVERS_x86-64 = "swrast,i915,i965"
+
+EXTRA_OECONF += "--with-driver=dri --disable-egl --disable-gallium --without-gallium-drivers --with-dri-drivers=${DRIDRIVERS}"

 python populate_packages_prepend() {
       import os.path

meta/recipes-graphics/mesa/mesa-dri_7.11.bb +0 -0
index 6a4f9a9..5d25127 100644
@@ -2,7 +2,3 @@ include mesa-common.inc

 include mesa-${PV}.inc
 include mesa-dri.inc
 PR = "${INC_PR}.0"

meta/recipes-graphics/mesa/mesa-dri_7.11.bb +0 -4
-
-EXTRA_OECONF += "--with-dri-drivers=swrast,i915,i965"
-
-COMPATIBLE_HOST = '(i.86.*-linux|x86_64.*-linux)'
meta/recipes-graphics/mesa/mesa-dri_git.bb +0 -0
index 15cde60..a0e1945 100644
@@ -7,5 +7,3 @@ DEFAULT_PREFERENCE = "-2"
 

 PR = "${INC_PR}.0"

meta/recipes-graphics/mesa/mesa-dri_git.bb +0 -2
-COMPATIBLE_HOST = '(i.86|x86_64).*-linux'
-

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#2 lore raw
Quoted 4 lines · Otavio Salvador

+1

Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can override it.

I really wouldn't recommend overriding this on a per machine basis, it needs to be on a per arch basis. This is because the recipe is not machine specific (nor should it be).

Configuration therefore falls to the distro, not machine.

Cheers,

Richard

#3 lore raw
Quoted 11 lines · Richard Purdie
Quoted 4 lines · Otavio Salvador

+1

Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can override it.

I really wouldn't recommend overriding this on a per machine basis, it needs to be on a per arch basis. This is because the recipe is not machine specific (nor should it be).

Configuration therefore falls to the distro, not machine.

Why not make it machine specific only when machine provides own module (like the case with glamo on om-gta02)?

Or recipe cannot change PACKAGE_ARCH in some special cases (like $MACHINE in path to some file in SRC_URI) anymore?

Regards,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw

Op 14 okt. 2011, om 17:30 heeft Martin Jansa het volgende geschreven:

Quoted 11 lines · Richard Purdie
Quoted 10 lines · Otavio Salvador
Quoted 4 lines

+1

Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can override it.

I really wouldn't recommend overriding this on a per machine basis, it needs to be on a per arch basis. This is because the recipe is not machine specific (nor should it be).

Quoted 7 lines
Quoted 1 line

Configuration therefore falls to the distro, not machine.

Why not make it machine specific only when machine provides own module (like the case with glamo on om-gta02)?

Or recipe cannot change PACKAGE_ARCH in some special cases (like $MACHINE in path to some file in SRC_URI) anymore?

Kinda like the wpa-supplicant and mplayer trick in OE classic?

Quoted 9 lines

Regards,

Signature · 5 lines
Martin 'JaMa' Jansa     jabber: [email protected]
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
#5 lore raw
In reply to Martin Jansa
Quoted 11 lines · Martin Jansa
Quoted 10 lines · Richard Purdie
Quoted 4 lines · Otavio Salvador

+1

Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can override it.

I really wouldn't recommend overriding this on a per machine basis, it needs to be on a per arch basis. This is because the recipe is not machine specific (nor should it be).

Quoted 7 lines
Quoted 1 line

Configuration therefore falls to the distro, not machine.

Why not make it machine specific only when machine provides own module (like the case with glamo on om-gta02)?

Or recipe cannot change PACKAGE_ARCH in some special cases (like $MACHINE in path to some file in SRC_URI) anymore?

It works just fine but its not nice practise in my opinion for a library like this and I don't see there is any need in this case. Certainly I don't see it as something OE-Core should be recommending.

Cheers,

Richard

#6 lore raw
Quoted 17 lines · Richard Purdie
Quoted 16 lines · Martin Jansa
Quoted 11 lines · Richard Purdie
Quoted 4 lines · Otavio Salvador

+1

Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can override it.

I really wouldn't recommend overriding this on a per machine basis, it needs to be on a per arch basis. This is because the recipe is not machine specific (nor should it be).

Configuration therefore falls to the distro, not machine.

Why not make it machine specific only when machine provides own module (like the case with glamo on om-gta02)?

Quoted 6 lines
Quoted 2 lines

Or recipe cannot change PACKAGE_ARCH in some special cases (like $MACHINE in path to some file in SRC_URI) anymore?

It works just fine but its not nice practise in my opinion for a library like this and I don't see there is any need in this case. Certainly I don't see it as something OE-Core should be recommending.

So can I send patches adding my glamo.patch to libdrm and mesa-dri so we can add glamo to
DRIDRIVERS_armv4t ?

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#7 lore raw
Quoted 21 lines · Martin Jansa
Quoted 20 lines · Richard Purdie
Quoted 18 lines · Martin Jansa
Quoted 11 lines · Richard Purdie
Quoted 4 lines · Otavio Salvador

+1

Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can override it.

I really wouldn't recommend overriding this on a per machine basis, it needs to be on a per arch basis. This is because the recipe is not machine specific (nor should it be).

Configuration therefore falls to the distro, not machine.

Why not make it machine specific only when machine provides own module (like the case with glamo on om-gta02)?

Or recipe cannot change PACKAGE_ARCH in some special cases (like $MACHINE in path to some file in SRC_URI) anymore?

Quoted 7 lines
Quoted 3 lines

It works just fine but its not nice practise in my opinion for a library like this and I don't see there is any need in this case. Certainly I don't see it as something OE-Core should be recommending.

So can I send patches adding my glamo.patch to libdrm and mesa-dri so we can add glamo to
DRIDRIVERS_armv4t ?

No, what I mean is if the layer containing that machine appends those patches for arm in general (or armv4t), you can then enable the dri drivers for armv4t in general to.

It means you would have to keep the layer enabled whenever generating armv4t feeds but I think that is ok as long as you know about it?

Cheers,

Richard

#8 lore raw
Quoted 26 lines · Richard Purdie
Quoted 25 lines · Martin Jansa
Quoted 23 lines · Richard Purdie
Quoted 11 lines · Martin Jansa
Quoted 10 lines · Richard Purdie
Quoted 4 lines · Otavio Salvador

+1

Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can override it.

I really wouldn't recommend overriding this on a per machine basis, it needs to be on a per arch basis. This is because the recipe is not machine specific (nor should it be).

Quoted 7 lines
Quoted 1 line

Configuration therefore falls to the distro, not machine.

Why not make it machine specific only when machine provides own module (like the case with glamo on om-gta02)?

Or recipe cannot change PACKAGE_ARCH in some special cases (like $MACHINE in path to some file in SRC_URI) anymore?

It works just fine but its not nice practise in my opinion for a library like this and I don't see there is any need in this case. Certainly I don't see it as something OE-Core should be recommending.

Quoted 7 lines
Quoted 3 lines

So can I send patches adding my glamo.patch to libdrm and mesa-dri so we can add glamo to
DRIDRIVERS_armv4t ?

No, what I mean is if the layer containing that machine appends those patches for arm in general (or armv4t), you can then enable the dri drivers for armv4t in general to.

but there can be more than 1 armv4t machines in different layers.

Quoted 14 lines

It means you would have to keep the layer enabled whenever generating armv4t feeds but I think that is ok as long as you know about it?

Cheers,

Richard

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

#9 lore raw
Quoted 32 lines · Khem Raj
Quoted 30 lines · Richard Purdie
Quoted 28 lines · Martin Jansa
Quoted 17 lines · Richard Purdie
Quoted 16 lines · Martin Jansa
Quoted 11 lines · Richard Purdie
Quoted 4 lines · Otavio Salvador

+1

Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can override it.

I really wouldn't recommend overriding this on a per machine basis, it needs to be on a per arch basis. This is because the recipe is not machine specific (nor should it be).

Configuration therefore falls to the distro, not machine.

Why not make it machine specific only when machine provides own module (like the case with glamo on om-gta02)?

Quoted 6 lines
Quoted 2 lines

Or recipe cannot change PACKAGE_ARCH in some special cases (like $MACHINE in path to some file in SRC_URI) anymore?

It works just fine but its not nice practise in my opinion for a library like this and I don't see there is any need in this case. Certainly I don't see it as something OE-Core should be recommending.

So can I send patches adding my glamo.patch to libdrm and mesa-dri so we can add glamo to
DRIDRIVERS_armv4t ?

Quoted 5 lines
Quoted 3 lines

No, what I mean is if the layer containing that machine appends those patches for arm in general (or armv4t), you can then enable the dri drivers for armv4t in general to.

but there can be more than 1 armv4t machines in different layers.

Yes, I know. We established earlier that this will compile on other arm machines. Obviously those machines would not include the module in their rootfs, gta02 would. Building it shouldn't make much difference to them.

Cheers,

Richard