Skip to contentSkip to conversation

Add TAINT_FIRMWARE_WORKAROUND on MTRR fixup

PATCH In review Prarit Bhargava 2 participants 3 messages Oct 18, 2011 – Dec 5, 2011 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add TAINT_FIRMWARE_WORKAROUND on MTRR fixup

TAINT_FIRMWARE_WORKAROUND should be set when an MTRR fixup is done.

---
 arch/x86/kernel/cpu/mtrr/generic.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/mtrr/generic.c +1 -0
index a71efcd..e1fe7f4 100644
@@ -547,6 +547,7 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base,
 
 		if (tmp != mask_lo) {
 			printk(KERN_WARNING "mtrr: your BIOS has configured an incorrect mask, fixing it.\n");
+			add_taint(TAINT_FIRMWARE_WORKAROUND);
 			mask_lo = tmp;
 		}
 	}
Signature · 1 line
1.7.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Prarit Bhargava

TAINT_FIRMWARE_WORKAROUND should be set when an MTRR fixup is done.

Adding the x86 maintainers to the cc, not sure if [email protected] is silently failing (or is it just an alias to them that is already back up working)?

Quoted 16 lines
---
 arch/x86/kernel/cpu/mtrr/generic.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/mtrr/generic.c +1 -0
index a71efcd..e1fe7f4 100644
@@ -547,6 +547,7 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base,
 
 		if (tmp != mask_lo) {
 			printk(KERN_WARNING "mtrr: your BIOS has configured an incorrect mask, fixing it.\n");
+			add_taint(TAINT_FIRMWARE_WORKAROUND);
 			mask_lo = tmp;
 		}
 	}
#2 lore raw
In reply to Prarit Bhargava
Commit-ID:  644ddf588f5dba34df483a6ea8abe639cc102289
Gitweb:     http://git.kernel.org/tip/644ddf588f5dba34df483a6ea8abe639cc102289
Author:     Prarit Bhargava <[email protected]>
AuthorDate: Tue, 18 Oct 2011 13:24:10 -0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 5 Dec 2011 13:48:50 +0100

Add TAINT_FIRMWARE_WORKAROUND on MTRR fixup

TAINT_FIRMWARE_WORKAROUND should be set when an MTRR fixup is done.

---
 arch/x86/kernel/cpu/mtrr/generic.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/mtrr/generic.c +1 -0
index a71efcdb..e1fe7f4 100644
@@ -547,6 +547,7 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base,
 
 		if (tmp != mask_lo) {
 			printk(KERN_WARNING "mtrr: your BIOS has configured an incorrect mask, fixing it.\n");
+			add_taint(TAINT_FIRMWARE_WORKAROUND);
 			mask_lo = tmp;
 		}
 	}