Skip to contentSkip to conversation

mfd: da903x: Ensure setting bits if new value is different from the old value

PATCH New Axel Lin 1 participant 2 messages Oct 31, 2011

Subsystems (2)
Multifunction devices (MFD) Dialog semiconductor drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 mfd: da903x: Ensure setting bits if new value is different from the old value

It does not make sense to write new value only when all the bit_mask bits are zero.
We need to write new value if the bit mask fields of new value is not equal to old value.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/da903x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/da903x.c +1 -1
index 62ce685..1924b85 100644
@@ -182,7 +182,7 @@ int da903x_set_bits(struct device *dev, int reg, uint8_t bit_mask)
 	if (ret)
 		goto out;
 
-	if ((reg_val & bit_mask) == 0) {
+	if ((reg_val & bit_mask) != bit_mask) {
 		reg_val |= bit_mask;
 		ret = __da903x_write(chip->client, reg, reg_val);
 	}
Signature · 1 line
1.7.5.4
author
#1 lore raw

PATCH 2/2 mfd: tps6586x: Ensure setting bits if new value is different from the old value

It does not make sense to write new value only when all the bit_mask bits are zero.
We need to write new value if the bit mask fields of new value is not equal to old value.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/tps6586x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/tps6586x.c +1 -1
index bba26d9..a5ddf31 100644
@@ -197,7 +197,7 @@ int tps6586x_set_bits(struct device *dev, int reg, uint8_t bit_mask)
 	if (ret)
 		goto out;
 
-	if ((reg_val & bit_mask) == 0) {
+	if ((reg_val & bit_mask) != bit_mask) {
 		reg_val |= bit_mask;
 		ret = __tps6586x_write(to_i2c_client(dev), reg, reg_val);
 	}
Signature · 1 line
1.7.5.4