ASoC: Fix return value of wm5100_gpio_direction_out()
Subsystems (3)
PATCH 1/1 ASoC: Fix return value of wm5100_gpio_direction_out()
We can't just pass back the return value of snd_soc_update_bits() as it will be 1 if a bit changed rather than zero.
Signed-off-by Mark Brown <[email protected]>
--- sound/soc/codecs/wm5100.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-)
sound/soc/codecs/wm5100.c +8 -4
@@ -2366,13 +2366,17 @@ static int wm5100_gpio_direction_out(struct gpio_chip *chip, {struct wm5100_priv *wm5100 =gpio_to_wm5100 (chip);struct snd_soc_codec *codec = wm5100->codec; -int val; +int val, ret; val = (1 <<WM5100_GP1_FN_SHIFT ) | (!!value <<WM5100_GP1_LVL_SHIFT ); -return snd_soc_update_bits (codec,WM5100_GPIO_CTRL_1 + offset, -WM5100_GP1_FN_MASK |WM5100_GP1_DIR | -WM5100_GP1_LVL , val); + ret =snd_soc_update_bits (codec,WM5100_GPIO_CTRL_1 + offset, +WM5100_GP1_FN_MASK |WM5100_GP1_DIR | +WM5100_GP1_LVL , val); +if (ret <0 ) +return ret; +else +return 0 ; }static int wm5100_gpio_get (struct gpio_chip *chip,unsigned offset)
Signature · 1 line
1.7.7.1