Skip to contentSkip to conversation

Staging: line6: Use kmemdup rather than duplicating its implementation

PATCH New Thomas Meyer 1 participant 1 message Nov 8, 2011 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: line6: Use kmemdup rather than duplicating its implementation

From: Thomas Meyer <[email protected]>

Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

---

drivers/staging/line6/midi.c 2011-11-08 10:52:27.890730177 +0100 renamed from drivers/staging/line6/midi.c 2011-11-07 19:38:11.240305613 +0100 +1 -2
diff -u -p a/drivers/staging/line6/midi.c b/drivers/staging/line6/midi.c
@@ -135,7 +135,7 @@ static int send_midi_async(struct usb_li
 	line6_write_hexdump(line6, 'S', data, length);
 #endif
 
-	transfer_buffer = kmalloc(length, GFP_ATOMIC);
+	transfer_buffer = kmemdup(data, length, GFP_ATOMIC);
 
 	if (transfer_buffer == NULL) {
 		usb_free_urb(urb);
@@ -143,7 +143,6 @@ static int send_midi_async(struct usb_li
 		return -ENOMEM;
 	}
 
-	memcpy(transfer_buffer, data, length);
 	usb_fill_int_urb(urb, line6->usbdev,
 			 usb_sndbulkpipe(line6->usbdev,
 					 line6->ep_control_write),