Skip to contentSkip to conversation

Fix : [Bug 887516] [NEW] VFP support reported for the PXA270

PATCH Superseded Benoît Canet 3 participants 7 messages Nov 9, 2011

v1 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix : [Bug 887516] [NEW] VFP support reported for the PXA270

A VFP was detected for pxa270 causing an "Illegal instruction" exception.
The eglibc was not receiving the right AT_HWCAP from elfloader.c.

Benoît Canet (1):
arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features.

 linux-user/elfload.c |   31 +++++++++++++++++++++++++++----
 1 files changed, 27 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features.

The cpu capabilities passed by the elf loader in AT_HWCAP where a constant.
Make AT_HWCAP reflect the emulated cpu features in order to give correct clues to eglibc.

Fix : [Bug 887516] [NEW] VFP support reported for the PXA270

---
 linux-user/elfload.c |   31 +++++++++++++++++++++++++++----
 1 files changed, 27 insertions(+), 4 deletions(-)
linux-user/elfload.c +27 -4
index a413976..5d81ec1 100644
@@ -375,10 +375,33 @@ bool guest_validate_base(unsigned long guest_base)
     return 1; /* All good */
 }
 
-#define ELF_HWCAP (ARM_HWCAP_ARM_SWP | ARM_HWCAP_ARM_HALF               \
-                   | ARM_HWCAP_ARM_THUMB | ARM_HWCAP_ARM_FAST_MULT      \
-                   | ARM_HWCAP_ARM_FPA | ARM_HWCAP_ARM_VFP              \
-                   | ARM_HWCAP_ARM_NEON | ARM_HWCAP_ARM_VFPv3 )
+
+#define ELF_HWCAP get_elf_hwcap()
+
+static uint32_t get_elf_hwcap(void)
+{
+    CPUState *e = thread_env;
+    uint32_t hwcaps = 0;
+
+    hwcaps |= ARM_HWCAP_ARM_SWP;
+    hwcaps |= ARM_HWCAP_ARM_HALF;
+    hwcaps |= ARM_HWCAP_ARM_THUMB;
+    hwcaps |= ARM_HWCAP_ARM_FAST_MULT;
+    hwcaps |= ARM_HWCAP_ARM_FPA;
+
+    /* prove for the extra features */
+#define GET_FEATURE(feat, hwcap) \
+    do {if (arm_feature(e, feat)) { hwcaps |= hwcap; } } while (0)
+    GET_FEATURE(ARM_FEATURE_VFP, ARM_HWCAP_ARM_VFP);
+    GET_FEATURE(ARM_FEATURE_IWMMXT, ARM_HWCAP_ARM_IWMMXT);
+    GET_FEATURE(ARM_FEATURE_THUMB2EE, ARM_HWCAP_ARM_THUMBEE);
+    GET_FEATURE(ARM_FEATURE_NEON, ARM_HWCAP_ARM_NEON);
+    GET_FEATURE(ARM_FEATURE_VFP3, ARM_HWCAP_ARM_VFPv3);
+    GET_FEATURE(ARM_FEATURE_VFP_FP16, ARM_HWCAP_ARM_VFPv3D16);
+#undef GET_FEATURE
+
+    return hwcaps;
+}
 
 #endif
 
Signature · 1 line
1.7.5.4
#2 lore raw

Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features.

Am 09.11.2011 14:04, schrieb Benoît Canet:

Quoted 17 lines

The cpu capabilities passed by the elf loader in AT_HWCAP where a constant.
Make AT_HWCAP reflect the emulated cpu features in order to give correct clues to eglibc.

Fix : [Bug 887516] [NEW] VFP support reported for the PXA270

---
 linux-user/elfload.c |   31 +++++++++++++++++++++++++++----
 1 files changed, 27 insertions(+), 4 deletions(-)
linux-user/elfload.c +0 -0
index a413976..5d81ec1 100644

linux-user/elfload.c bool guest_validate_base(unsigned long guest_base) · line 379

Quoted 9 lines
linux-user/elfload.c +2 -4
@@ -375,10 +375,33 @@ bool guest_validate_base(unsigned long guest_base)
     return 1; /* All good */
 }
 
-#define ELF_HWCAP (ARM_HWCAP_ARM_SWP | ARM_HWCAP_ARM_HALF               \
-                   | ARM_HWCAP_ARM_THUMB | ARM_HWCAP_ARM_FAST_MULT      \
-                   | ARM_HWCAP_ARM_FPA | ARM_HWCAP_ARM_VFP              \
-                   | ARM_HWCAP_ARM_NEON | ARM_HWCAP_ARM_VFPv3 )
+
+#define ELF_HWCAP get_elf_hwcap()

I assume ELF_HWCAP is being used in architecture-independent code? Or would it be feasible to replace all occurrences with the function call?

linux-user/elfload.c bool guest_validate_base(unsigned long guest_base) · line 392

Quoted 13 lines
linux-user/elfload.c +13 -0
+
+static uint32_t get_elf_hwcap(void)
+{
+    CPUState *e = thread_env;
+    uint32_t hwcaps = 0;
+
+    hwcaps |= ARM_HWCAP_ARM_SWP;
+    hwcaps |= ARM_HWCAP_ARM_HALF;
+    hwcaps |= ARM_HWCAP_ARM_THUMB;
+    hwcaps |= ARM_HWCAP_ARM_FAST_MULT;
+    hwcaps |= ARM_HWCAP_ARM_FPA;
+
+    /* prove for the extra features */

probe?

linux-user/elfload.c bool guest_validate_base(unsigned long guest_base) · line 394

Quoted 2 lines
linux-user/elfload.c +2 -0
+#define GET_FEATURE(feat, hwcap) \
+    do {if (arm_feature(e, feat)) { hwcaps |= hwcap; } } while (0)

This doesn't return anything, it sets the hwcap flag. SET_HWCAP maybe?

linux-user/elfload.c bool guest_validate_base(unsigned long guest_base) · line 400

Quoted 6 lines
linux-user/elfload.c +6 -0
+    GET_FEATURE(ARM_FEATURE_VFP, ARM_HWCAP_ARM_VFP);
+    GET_FEATURE(ARM_FEATURE_IWMMXT, ARM_HWCAP_ARM_IWMMXT);
+    GET_FEATURE(ARM_FEATURE_THUMB2EE, ARM_HWCAP_ARM_THUMBEE);
+    GET_FEATURE(ARM_FEATURE_NEON, ARM_HWCAP_ARM_NEON);
+    GET_FEATURE(ARM_FEATURE_VFP3, ARM_HWCAP_ARM_VFPv3);
+    GET_FEATURE(ARM_FEATURE_VFP_FP16, ARM_HWCAP_ARM_VFPv3D16);

I'm wondering if this translation table were better placed in target-arm/helper.c where we fiddle with the features in the first place. We could loop through all features here and call a function that returns the hwcap or 0 and |= it. Me and others will be adding new features and we'll risk adapting this here.

I was told that VFP_FP16 is *not* VFPv3-D16. Please remove that for now.

linux-user/elfload.c bool guest_validate_base(unsigned long guest_base) · line 407

Quoted 7 lines
linux-user/elfload.c +4 -0
+#undef GET_FEATURE
+
+    return hwcaps;
+}
 
 #endif
 

Andreas

Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
#3 lore raw

Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features.

Quoted 2 lines

I assume ELF_HWCAP is being used in architecture-independent code? Or would it be feasible to replace all occurrences with the function call?

Many architecture in elfloader.c hardcode ELF_HWCAP before putting into the AT_HWCAP elf field which is used by glibc to guess the cpu capabilities. I don't feel it so arch independant.

Quoted 7 lines

I'm wondering if this translation table were better placed in target-arm/helper.c where we fiddle with the features in the first place. We could loop through all features here and call a function that returns the hwcap or 0 and |= it. Me and others will be adding new features and we'll risk adapting this here.

I modeled this patch by looking at PPC behavior. However I can rewrite it

if needed but pcc will need a rewrite too.

#4 lore raw

Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features.

In reply to Andreas Färber

2011/11/9 Andreas Färber <[email protected]>:

Quoted 5 lines

I'm wondering if this translation table were better placed in target-arm/helper.c where we fiddle with the features in the first place. We could loop through all features here and call a function that returns the hwcap or 0 and |= it. Me and others will be adding new features and we'll risk adapting this here.

Hmm. It's really linux-specific so there's a good argument for leaving it in linux-user. On the other hand I did just add some extra features (arm div, vfpv4) without fixing the hwcaps so I see your point...

Maybe we should just have a comment in cpu.h next to the arm_features enum?

-- PMM

#5 lore raw

Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features.

Am 09.11.2011 15:06, schrieb Peter Maydell:

Quoted 7 lines

2011/11/9 Andreas Färber <[email protected]>:

Quoted 5 lines

I'm wondering if this translation table were better placed in target-arm/helper.c where we fiddle with the features in the first place. We could loop through all features here and call a function that returns the hwcap or 0 and |= it. Me and others will be adding new features and we'll risk adapting this here.

Quoted 7 lines

Hmm. It's really linux-specific so there's a good argument for leaving it in linux-user. On the other hand I did just add some extra features (arm div, vfpv4) without fixing the hwcaps so I see your point...

Maybe we should just have a comment in cpu.h next to the arm_features enum?

That might do, too.

Andreas

Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
#6 lore raw

Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features.

In reply to Benoît Canet

2011/11/9 Benoît Canet <[email protected]>:

linux-user/elfload.c bool guest_validate_base(unsigned long guest_base) · line 390

Quoted 10 lines
linux-user/elfload.c +10 -0
+static uint32_t get_elf_hwcap(void)
+{
+    CPUState *e = thread_env;
+    uint32_t hwcaps = 0;
+
+    hwcaps |= ARM_HWCAP_ARM_SWP;
+    hwcaps |= ARM_HWCAP_ARM_HALF;
+    hwcaps |= ARM_HWCAP_ARM_THUMB;
+    hwcaps |= ARM_HWCAP_ARM_FAST_MULT;
+    hwcaps |= ARM_HWCAP_ARM_FPA;

After looking at the Linux kernel code I've changed my mind on this one:
we shouldn't set the FPA hwcap, because we don't model any CPU with FPA hardware and the kernel doesn't set this hwcap even if it is providing emulated FPA via nwfpe, so we shouldn't either.

Quoted 9 lines

+    /* prove for the extra features */
+#define GET_FEATURE(feat, hwcap) \
+    do {if (arm_feature(e, feat)) { hwcaps |= hwcap; } } while (0)
+    GET_FEATURE(ARM_FEATURE_VFP, ARM_HWCAP_ARM_VFP);
+    GET_FEATURE(ARM_FEATURE_IWMMXT, ARM_HWCAP_ARM_IWMMXT);
+    GET_FEATURE(ARM_FEATURE_THUMB2EE, ARM_HWCAP_ARM_THUMBEE);
+    GET_FEATURE(ARM_FEATURE_NEON, ARM_HWCAP_ARM_NEON);
+    GET_FEATURE(ARM_FEATURE_VFP3, ARM_HWCAP_ARM_VFPv3);
+    GET_FEATURE(ARM_FEATURE_VFP_FP16, ARM_HWCAP_ARM_VFPv3D16);

As Andreas says, this one's wrong. We don't currently implement any CPUs with VFPv3D16 (ie only 16 double registers) so we never need to set this hwcap. (ARM_FEATURE_VP_FP16 means "we implement half-precision VFP".)

Missing:
/* Strictly should be ARM_FEATURE_V5TE but we don't distinguish
* as all our v5 cores are v5TE at the moment
*/
GET_FEATURE(ARM_FEATURE_V5, ARM_HWCAP_ARM_EDSP);

(although maybe we should just bite the bullet and define the feature bit...)

linux-user/elfload.c bool guest_validate_base(unsigned long guest_base) · line 404

Quoted 4 lines
linux-user/elfload.c +4 -0
+#undef GET_FEATURE
+
+    return hwcaps;
+}

While we're here we might as well update the hwcaps list based on the most recent kernel:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=arch/arm/kernel/setup.c;h=7e7977ab994ff92ee4ded30ee728d92ed6c3a520;hb=HEAD#l986

So that's

    ARM_HWCAP_ARM_TLS       = 1 << 14,
    ARM_HWCAP_ARM_VFPv4     = 1 << 15,
    ARM_HWCAP_ARM_IDIVA     = 1 << 16,
    ARM_HWCAP_ARM_IDIVT     = 1 << 17,

and

    GET_FEATURE(ARM_FEATURE_V6K, ARM_HWCAP_ARM_TLS);
    GET_FEATURE(ARM_FEATURE_VFP4, ARM_HWCAP_ARM_VFPv4);
    GET_FEATURE(ARM_FEATURE_ARM_DIV, ARM_HWCAP_ARM_IDIVA);
    GET_FEATURE(ARM_FEATURE_THUMB_DIV, ARM_HWCAP_ARM_IDIVT);

-- PMM