Skip to contentSkip to conversation

ASoC: Remove unused control_data and mutex fields from struct alc5632_priv

PATCH Applied Axel Lin 3 participants 5 messages Nov 13, 2011 – Nov 14, 2011

Subsystems (2)
Sound ASoC
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: Remove unused control_data and mutex fields from struct alc5632_priv

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/alc5632.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
sound/soc/codecs/alc5632.c +0 -4
index ee6a497..bfb48ba 100644
@@ -68,8 +68,6 @@ static const u16 alc5632_reg_defaults[] = {
 /* codec private data */
 struct alc5632_priv {
 	enum snd_soc_control_type control_type;
-	void *control_data;
-	struct mutex mutex;
 	u8 id;
 	unsigned int sysclk;
 };

@@ -1092,9 +1090,7 @@ static int alc5632_i2c_probe(struct i2c_client *client,
 	}
 
 	i2c_set_clientdata(client, alc5632);
-	alc5632->control_data = client;
 	alc5632->control_type = SND_SOC_I2C;
-	mutex_init(&alc5632->mutex);
 
 	ret =  snd_soc_register_codec(&client->dev,
 		&soc_codec_device_alc5632, &alc5632_dai, 1);
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 29 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/codecs/alc5632.c |    4 ----

 1 files changed, 0 insertions(+), 4 deletions(-)
sound/soc/codecs/alc5632.c +0 -5
index ee6a497..bfb48ba 100644
@@ -68,8 +68,6 @@ static const u16 alc5632_reg_defaults[] = {
  /* codec private data */
  struct alc5632_priv {
        enum snd_soc_control_type control_type;
-       void *control_data;
-       struct mutex mutex;
        u8 id;
        unsigned int sysclk;
  };

@@ -1092,9 +1090,7 @@ static int alc5632_i2c_probe(struct i2c_client *client,
        }
 
        i2c_set_clientdata(client, alc5632);
-       alc5632->control_data = client;
        alc5632->control_type = SND_SOC_I2C;
-       mutex_init(&alc5632->mutex);
 
        ret =  snd_soc_register_codec(&client->dev,
                &soc_codec_device_alc5632, &alc5632_dai, 1);
--
Quoted 1 line

1.7.5.4

Thanks,

Mark, Liam do I need to sign Acked-Off-By on this type of patch?

Signature · 6 lines
Leon Romanovsky | Independent Linux Consultant
        www.leon.nu | [email protected]
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
#2 lore raw
Quoted 1 line · Leon Romanovsky

Mark, Liam do I need to sign Acked-Off-By on this type of patch?

You don't have to but if you've reviewed patches that haven't yet been applied it's always helpful to say so.

#3 lore raw
Quoted 6 lines · Mark Brown
Quoted 1 line · Leon Romanovsky

Mark, Liam do I need to sign Acked-Off-By on this type of patch?

You don't have to but if you've reviewed patches that haven't yet been applied it's always helpful to say so.

Ok, in this case, I reviewed it and tested :)

Acked-off-by Leon Romanovsky <[email protected]>
Signature · 6 lines
Leon Romanovsky | Independent Linux Consultant
        www.leon.nu | [email protected]
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel