Skip to contentSkip to conversation

lockdep: Don't disable lockdep for out of tree modules

PATCH In review Aneesh Kumar K.V 2 participants 3 messages Nov 16, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lockdep: Don't disable lockdep for out of tree modules

From: "Aneesh Kumar K.V" <[email protected]>

I guess it would be nice to get lockdep enabled for out of tree GPL modules

---
 kernel/panic.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/panic.c +2 -1
index b2659360..3bd7088 100644
@@ -240,7 +240,8 @@ void add_taint(unsigned flag)
 	 * Also we want to keep up lockdep for staging development and
 	 * post-warning case.
 	 */
-	if (flag != TAINT_CRAP && flag != TAINT_WARN && __debug_locks_off())
+	if (flag != TAINT_CRAP && flag != TAINT_WARN &&
+	    flag != TAINT_OOT_MODULE && __debug_locks_off())
 		printk(KERN_WARNING "Disabling lock debugging due to kernel taint\n");
 
 	set_bit(flag, &tainted_mask);
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 3 lines · Aneesh Kumar K.V

From: "Aneesh Kumar K.V" <[email protected]>

I guess it would be nice to get lockdep enabled for out of tree GPL modules

How about you get them in staging instead?

#2 lore raw
Quoted 7 lines · Peter Zijlstra
Quoted 3 lines · Aneesh Kumar K.V

From: "Aneesh Kumar K.V" <[email protected]>

I guess it would be nice to get lockdep enabled for out of tree GPL modules

How about you get them in staging instead?

I actually wanted to do a sample module to demo lockdep in one of the presentation i am doing and that is when i hit the issue. I don't have a kernel module that i would like to keep out of tree. I am not sure there is any value in disabling lockdep if one load an out of tree GPL kernel module.

-aneesh