Skip to contentSkip to conversation

bbc_i2c: Remove unneeded err variable

PATCH Applied Axel Lin 2 participants 2 messages Nov 22, 2011 – Dec 4, 2011 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 bbc_i2c: Remove unneeded err variable

Signed-off-by Axel Lin <[email protected]>
---
 drivers/sbus/char/bbc_i2c.c |   14 ++++----------
 1 files changed, 4 insertions(+), 10 deletions(-)
drivers/sbus/char/bbc_i2c.c +4 -10
index 5f94d22..a0d1399 100644
@@ -233,13 +233,9 @@ int bbc_i2c_write_buf(struct bbc_i2c_client *client,
 	int ret = 0;
 
 	while (len > 0) {
-		int err = bbc_i2c_writeb(client, *buf, off);
-
-		if (err < 0) {
-			ret = err;
+		ret = bbc_i2c_writeb(client, *buf, off);
+		if (ret < 0)
 			break;
-		}
-
 		len--;
 		buf++;
 		off++;

@@ -253,11 +249,9 @@ int bbc_i2c_read_buf(struct bbc_i2c_client *client,
 	int ret = 0;
 
 	while (len > 0) {
-		int err = bbc_i2c_readb(client, buf, off);
-		if (err < 0) {
-			ret = err;
+		ret = bbc_i2c_readb(client, buf, off);
+		if (ret < 0)
 			break;
-		}
 		len--;
 		buf++;
 		off++;
Signature · 1 line
1.7.5.4