xserver-xorg support to VESA driver
cover xserver-xorg support to VESA driver
The following changes since commit 5f1dc1991f97037692193572298eb7f7a5640760:
staging.bbclass: Add BB_SETSCENE_VERIFY_FUNCTION function (2011-11-22 13:04:31 +0000)
are available in the git repository at:
git://github.com/OSSystems/oe-core master
https://github.com/OSSystems/oe-core/tree/HEAD
Otavio Salvador (1):
xserver-xorg: do not disable-dga as VESA driver requires it
.../xorg-xserver/xserver-xorg-1.11.1.inc | 2 +- .../xorg-xserver/xserver-xorg-common.inc | 1 - 2 files changed, 1 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.2.5
PATCH 1/1 xserver-xorg: do not disable-dga as VESA driver requires it
Xorg VESA driver calls DGAInit enforcing this symbol to be available to the driver to work.
--- .../xorg-xserver/xserver-xorg-1.11.1.inc | 2 +- .../xorg-xserver/xserver-xorg-common.inc | 1 - 2 files changed, 1 insertions(+), 2 deletions(-)
meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.1.inc +1 -1
@@ -3,7 +3,7 @@ SRC_URI += "file://crosscompile.patch" # Misc build failure for master HEAD SRC_URI += "file://fix_open_max_preprocessor_error.patch" -PR = "r1" +PR = "r2" SRC_URI[md5sum] = "4cdf54dc569b6a5548257c93a45dcd3d" SRC_URI[sha256sum] = "c069c177d9a80bca2ee1d49aa1af6d9f996c83e4ff12393cab2ca3f8817276f6"
meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc +0 -1
@@ -100,7 +100,6 @@ EXTRA_OECONF += "--with-fop=no \ --disable-acfb \ --disable-ccfb \ --disable-mcfb \ - --disable-dga \ --disable-xinerama \ --disable-xf86misc \ --disable-xorgcfg \
Signature · 1 line
1.7.2.5
Re: [PATCH 1/1] xserver-xorg: do not disable-dga as VESA driver requires it
Quoted 2 lines · Otavio Salvador
Xorg VESA driver calls DGAInit enforcing this symbol to be available to the driver to work.
Maybe it would be better to patch vesa.c to not require this symbol rather than forcing it on in the server for everyone. Or alternatively, if you genuinely want DGA, maybe make it a PACKAGECONFIG option.
p.
Re: [PATCH 1/1] xserver-xorg: do not disable-dga as VESA driver requires it
Quoted 8 lines · Phil Blundell
Quoted 2 lines · Otavio Salvador
Xorg VESA driver calls DGAInit enforcing this symbol to be available to the driver to work.
Maybe it would be better to patch
vesa.cto not require this symbol rather than forcing it on in the server for everyone. Or alternatively, if you genuinely want DGA, maybe make it a PACKAGECONFIG option.
What worries me is that this changed lately as it were working fine.
When xserver-xorg were update to 1.11 this has changed behind the scenes. This used to be disabled on lite flavour only.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Re: [PATCH 1/1] xserver-xorg: do not disable-dga as VESA driver requires it
Quoted 13 lines · Otavio Salvador
On Tue, Nov 22, 2011 at 15:14, Phil Blundell <[email protected]> wrote:
On Tue, 2011-11-22 at 13:47 +0000, Otavio Salvador wrote:
> Xorg VESA driver calls DGAInit enforcing this symbol to be available
> to the driver to work.Maybe it would be better to patch
vesa.cto not require this symbol
rather than forcing it on in the server for everyone. Or alternatively,
if you genuinely want DGA, maybe make it a PACKAGECONFIG option.
Quoted 4 lines
What worries me is that this changed lately as it were working fine.
When xserver-xorg were update to 1.11 this has changed behind the scenes. This used to be disabled on lite flavour only.
Looking at vesa.c, there is quite a chunk of code in there depending on DGA.
Is there any harm to building DGA apart from an extra package? Its a self contained module isn't it?
If so, we should just be able to turn it on, package it separately and forget about it?
Of course the ideal solution would be for someone to convert the vesa driver to use the xrandr API...
Cheers,
Richard
Re: [PATCH 1/1] xserver-xorg: do not disable-dga as VESA driver requires it
Quoted 2 lines · Richard Purdie
...
Looking at vesa.c, there is quite a chunk of code in there depending on
Quoted 2 lines
DGA.
Yes.
Quoted 3 lines
Is there any harm to building DGA apart from an extra package? Its a self contained module isn't it?
AFAIK no. It seems to be a blob static linked onto the Xorg.
Quoted 1 line
...
Of course the ideal solution would be for someone to convert the vesa
Quoted 2 lines
driver to use the xrandr API...
Well, yes. But I cannot work on that now.
In meanwhile I sent another patch proposing to disable it for lite flavor only, as it was before the update to 1.11 Xorg Xserver.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Re: [PATCH 1/1] xserver-xorg: do not disable-dga as VESA driver requires it
In reply to Richard PurdieQuoted 2 lines · Richard Purdie
Looking at
vesa.c, there is quite a chunk of code in there depending on DGA.
I guess the question is, is this chunk of code actually doing anything useful/important, or is it just there to support DGA on VESA? If the latter then people who don't need/want DGA (which is probably everybody, nowadays) can just take it out.
All that said, I would have thought that the VESA driver itself was pretty much a fringe interest in this day and age. Is anybody really using that on a shipping system? If it's just for qemux86 test harness purposes then maybe we could turn on the vesafb driver in the kernel and use the straight framebuffer driver in Xorg rather than the VESA one.
Quoted 2 lines
Is there any harm to building DGA apart from an extra package? Its a self contained module isn't it?
I don't think it's that self-contained. Admittedly it isn't all that big either, but still.
Quoted 5 lines
If so, we should just be able to turn it on, package it separately and forget about it?
Of course the ideal solution would be for someone to convert the vesa driver to use the xrandr API...
I don't quite understand what xrandr has to do with that. How does this relate to DGA?
p.
Re: [PATCH 1/1] xserver-xorg: do not disable-dga as VESA driver requires it
Quoted 21 lines · Phil Blundell
Quoted 2 lines · Richard Purdie
Looking at
vesa.c, there is quite a chunk of code in there depending on DGA.I guess the question is, is this chunk of code actually doing anything useful/important, or is it just there to support DGA on VESA? If the latter then people who don't need/want DGA (which is probably everybody, nowadays) can just take it out.
All that said, I would have thought that the VESA driver itself was pretty much a fringe interest in this day and age. Is anybody really using that on a shipping system? If it's just for qemux86 test harness purposes then maybe we could turn on the vesafb driver in the kernel and use the straight framebuffer driver in Xorg rather than the VESA one.
Quoted 2 lines
Is there any harm to building DGA apart from an extra package? Its a self contained module isn't it?
I don't think it's that self-contained. Admittedly it isn't all that big either, but still.
Quoted 8 lines
Quoted 5 lines
If so, we should just be able to turn it on, package it separately and forget about it?
Of course the ideal solution would be for someone to convert the vesa driver to use the xrandr API...
I don't quite understand what xrandr has to do with that. How does this relate to DGA?
The vesa driver looks like its using DGA APIs to expose mode setting. A comment to that end is also in a TODO list at the top of the file.
Cheers,
Richard
Re: [PATCH 1/1] xserver-xorg: do not disable-dga as VESA driver requires it
Quoted 2 lines · Richard Purdie
The vesa driver looks like its using DGA APIs to expose mode setting. A comment to that end is also in a TODO list at the top of the file.
Ah, I see. I guess that can just be turned off for non-DGA builds then. As you say, making it use Xrandr would be a better solution in the long term but it doesn't seem all that likely that anybody is going to have much enthusiasm for enhancing the VESA driver at this point.
p.
Re: [PATCH 1/1] xserver-xorg: do not disable-dga as VESA driver requires it
In reply to Phil BlundellQuoted 9 lines · Phil Blundell
Quoted 2 lines · Richard Purdie
Looking at
vesa.c, there is quite a chunk of code in there depending on DGA.I guess the question is, is this chunk of code actually doing anything useful/important, or is it just there to support DGA on VESA? If the latter then people who don't need/want DGA (which is probably everybody, nowadays) can just take it out.
Quoted 5 lines
All that said, I would have thought that the VESA driver itself was pretty much a fringe interest in this day and age. Is anybody really using that on a shipping system? If it's just for qemux86 test harness purposes then maybe we could turn on the vesafb driver in the kernel and use the straight framebuffer driver in Xorg rather than the VESA one.
I do. I use it a lot and that's why I found it was broken.
For me, having it on xserver-xorg and it disabled for xserver-xorg-lite works for me for now.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br