Skip to contentSkip to conversation

ALSA: asihp: Use kcalloc instead of kzalloc to allocate array

PATCH New Thomas Meyer 1 participant 1 message Nov 29, 2011 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: asihp: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read.

The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107

---

sound/pci/asihpi/hpicmn.c 2011-11-28 20:15:05.524701909 +0100 renamed from sound/pci/asihpi/hpicmn.c 2011-11-13 11:08:14.997586936 +0100 +1 -1
diff -u -p a/sound/pci/asihpi/hpicmn.c b/sound/pci/asihpi/hpicmn.c
@@ -631,7 +631,7 @@ struct hpi_control_cache *hpi_alloc_cont
 	if (!p_cache)
 		return NULL;
 
-	p_cache->p_info = kzalloc(sizeof(*p_cache->p_info) * control_count,
+	p_cache->p_info = kcalloc(control_count, sizeof(*p_cache->p_info),
 				  GFP_KERNEL);
 	if (!p_cache->p_info) {
 		kfree(p_cache);