Skip to contentSkip to conversation

mpt2sas: Remove unused duplicate diag_buffer_enable param

PATCH In review Roland Dreier 2 participants 2 messages Nov 30, 2011 – Dec 2, 2011 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpt2sas: Remove unused duplicate diag_buffer_enable param

From: Roland Dreier <[email protected]>

Commit 921cd8024b90 ("[SCSI] mpt2sas: New feature - Fast Load Support") moved handling of the diag_buffer_enable module parameter from mpt2sas_base.c to mpt2sas_scsih.c, but it left an old copy of the parameter in mpt2sas_base.c. Remove the unused stub.

---
 drivers/scsi/mpt2sas/mpt2sas_base.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)
drivers/scsi/mpt2sas/mpt2sas_base.c +0 -13
index beda04a..b3ad90e 100644
@@ -89,19 +89,6 @@ static int disable_discovery = -1;
 module_param(disable_discovery, int, 0);
 MODULE_PARM_DESC(disable_discovery, " disable discovery ");
 
-
-/* diag_buffer_enable is bitwise
- * bit 0 set = TRACE
- * bit 1 set = SNAPSHOT
- * bit 2 set = EXTENDED
- *
- * Either bit can be set, or both
- */
-static int diag_buffer_enable;
-module_param(diag_buffer_enable, int, 0);
-MODULE_PARM_DESC(diag_buffer_enable, " post diag buffers "
-    "(TRACE=1/SNAPSHOT=2/EXTENDED=4/default=0)");
-
 /**
  * _scsih_set_fwfault_debug - global setting of ioc->fwfault_debug.
  *
Signature · 1 line
1.7.5.4
#1 lore raw

This patch seem to be fine.
Please consider this patch as acked by me.

Regards,
Nagalakshmi

-----Original Message-----
From: Roland Dreier [mailto:[email protected]] On Behalf Of Roland Dreier
Sent: Wednesday, November 30, 2011 11:36 PM
To: James E.J. Bottomley
Cc: Nandigama, Nagalakshmi; [email protected]
Subject: [PATCH] [SCSI] mpt2sas: Remove unused duplicate diag_buffer_enable param

From: Roland Dreier <[email protected]>

Commit 921cd8024b90 ("[SCSI] mpt2sas: New feature - Fast Load Support") moved handling of the diag_buffer_enable module parameter from mpt2sas_base.c to mpt2sas_scsih.c, but it left an old copy of the parameter in mpt2sas_base.c. Remove the unused stub.

---
 drivers/scsi/mpt2sas/mpt2sas_base.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)
drivers/scsi/mpt2sas/mpt2sas_base.c +0 -13
index beda04a..b3ad90e 100644
@@ -89,19 +89,6 @@ static int disable_discovery = -1;
 module_param(disable_discovery, int, 0);
 MODULE_PARM_DESC(disable_discovery, " disable discovery ");
 
-
-/* diag_buffer_enable is bitwise
- * bit 0 set = TRACE
- * bit 1 set = SNAPSHOT
- * bit 2 set = EXTENDED
- *
- * Either bit can be set, or both
- */
-static int diag_buffer_enable;
-module_param(diag_buffer_enable, int, 0);
-MODULE_PARM_DESC(diag_buffer_enable, " post diag buffers "
-    "(TRACE=1/SNAPSHOT=2/EXTENDED=4/default=0)");
-
 /**
  * _scsih_set_fwfault_debug - global setting of ioc->fwfault_debug.
  *
Signature · 1 line
1.7.5.4