Skip to contentSkip to conversation

mfd: Return an error on failed wm831x register writes

PATCH In review Mark Brown 2 participants 2 messages Dec 5, 2011 – Dec 19, 2011

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 mfd: Return an error on failed wm831x register writes

Got dropped in the regmap conversion.

---
 drivers/mfd/wm831x-core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mfd/wm831x-core.c +2 -0
index 3b76189..f5e54fa 100644
@@ -559,6 +559,8 @@ static int wm831x_write(struct wm831x *wm831x, unsigned short reg,
 		dev_vdbg(wm831x->dev, "Write %04x to R%d(0x%x)\n",
 			 buf[i], reg + i, reg + i);
 		ret = regmap_write(wm831x->regmap, reg + i, buf[i]);
+		if (ret != 0)
+			return ret;
 	}
 
 	return 0;
Signature · 1 line
1.7.7.3
#1 lore raw

Hi Mark,

Quoted 1 line · Mark Brown

Got dropped in the regmap conversion.

I'll take this one, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/