Skip to contentSkip to conversation

ASoC: Don't fail if we can't read the IRQ type in WM8903

PATCH In review Mark Brown 2 participants 2 messages Dec 6, 2011

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Don't fail if we can't read the IRQ type in WM8903

If we fail to read the IRQ type from the interrupt controller don't fail, just assume a value and solider on - we may fail later when we try to request the IRQ but it's possible we'll succeed.

---
 sound/soc/codecs/wm8903.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)
sound/soc/codecs/wm8903.c +1 -5
index adfbefa..21b9fdc 100644
@@ -2049,6 +2049,7 @@ static int wm8903_set_pdata_irq_trigger(struct i2c_client *i2c,
 
 	switch (irqd_get_trigger_type(irq_data)) {
 	case IRQ_TYPE_NONE:
+	default:
 		/*
 		* We assume the controller imposes no restrictions,
 		* so we are able to select active-high
@@ -2060,11 +2061,6 @@ static int wm8903_set_pdata_irq_trigger(struct i2c_client *i2c,
 	case IRQ_TYPE_LEVEL_LOW:
 		pdata->irq_active_low = true;
 		break;
-	default:
-		dev_err(&i2c->dev,
-			"Unsupported IRQ_TYPE %x\n",
-			irqd_get_trigger_type(irq_data));
-		return -EINVAL;
 	}
 
 	return 0;
Signature · 1 line
1.7.7.3
Acked-by on v1 1/1
#1 lore raw

Mark Brown wrote at Tuesday, December 06, 2011 3:48 AM:

Quoted 5 lines

If we fail to read the IRQ type from the interrupt controller don't fail, just assume a value and solider on - we may fail later when we try to request the IRQ but it's possible we'll succeed.

Thanks.

Signature · 1 line
nvpublic