mfd: Store wm8350 struct in core device driver data
Subsystems (2)
PATCH 1/2 mfd: Store wm8350 struct in core device driver data
This will allow us to move to a more idiomatic MFD model as drivers will be able to get the struct by looking at their parent device.
Signed-off-by Mark Brown <[email protected]>
--- drivers/mfd/wm8350-core.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mfd/wm8350-core.c +2 -0
@@ -573,6 +573,8 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,u16 id1, id2, mask_rev;u16 cust_id, mode, chip_rev; +dev_set_drvdata (wm8350->dev, wm8350); +/* get WM8350 revision and config mode */ ret = wm8350->read_dev (wm8350,WM8350_RESET_ID ,sizeof (id1), &id1);if (ret !=0 ) {
Signature · 1 line
1.7.7.3
PATCH 2/2 mfd: Convert WM8350 to devm_kzalloc()
Signed-off-by Mark Brown <[email protected]>
--- drivers/mfd/wm8350-i2c.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/mfd/wm8350-i2c.c +1 -3
@@ -63,7 +63,7 @@ static int wm8350_i2c_probe(struct i2c_client *i2c,struct wm8350 *wm8350;int ret =0 ; - wm8350 =kzalloc (sizeof (struct wm8350 ),GFP_KERNEL ); + wm8350 =devm_kzalloc (&i2c->dev,sizeof (struct wm8350 ),GFP_KERNEL );if (wm8350 ==NULL )return -ENOMEM ;
@@ -80,7 +80,6 @@ static int wm8350_i2c_probe(struct i2c_client *i2c,return ret; err: -kfree (wm8350);return ret; }
@@ -89,7 +88,6 @@ static int wm8350_i2c_remove(struct i2c_client *i2c)struct wm8350 *wm8350 =i2c_get_clientdata (i2c);wm8350_device_exit (wm8350); -kfree (wm8350);return 0 ; }
Signature · 1 line
1.7.7.3
Samuel Ortiz
AppliedRe: [PATCH 2/2] mfd: Convert WM8350 to devm_kzalloc()
Hi Mark,
Quoted 1 line · Mark Brown
Signed-off-by Mark Brown <[email protected]>
Applied as well, many thanks.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/
Hi Mark,
Quoted 2 lines · Mark Brown
This will allow us to move to a more idiomatic MFD model as drivers will be able to get the struct by looking at their parent device.
Patch applied, thanks.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/