hwmon: jz4740: fix signedness bug

wait_for_completion_interruptible_timeout() may return negative value. In this case, checking if (t > 0) will return true if t is unsigned.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/power/jz4740-battery.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/power/jz4740-battery.c +1 -1

index 763f894..5bb1ddd 100644
@@ -67,7 +67,7 @@ static irqreturn_t jz_battery_irq_handler(int irq, void *devid)
 
 static long jz_battery_read_voltage(struct jz_battery *battery)
 {
-	unsigned long t;
+	long t;
 	unsigned long val;
 	long voltage;
 

Quoted 4 lines · Axel Lin

wait_for_completion_interruptible_timeout() may return negative value. In this case, checking if (t > 0) will return true if t is unsigned.

Signed-off-by Axel Lin <[email protected]>

Acked-by Lars-Peter Clausen <[email protected]>

wait_for_completion_interruptible_timeout() may return negative value. In this case, checking if (t > 0) will return true if t is unsigned.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/hwmon/jz4740-hwmon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/hwmon/jz4740-hwmon.c +1 -1

index 7a48b1e..3d7e590 100644
@@ -59,7 +59,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev,
 {
 	struct jz4740_hwmon *hwmon = dev_get_drvdata(dev);
 	struct completion *completion = &hwmon->read_completion;
-	unsigned long t;
+	long t;
 	unsigned long val;
 	int ret;
 

wait_for_completion_interruptible_timeout() may return negative value. In this case, checking if (t > 0) will return true if t is unsigned.

Signed-off-by Axel Lin <[email protected]>