ftplib: add initial version of recipe
PATCH 1/1 ftplib: add initial version of recipe
From: Vitaly Perov <[email protected]>
--- recipes/ftplib/ftplib_3.1.bb | 38 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 38 insertions(+), 0 deletions(-) create mode 100644 recipes/ftplib/ftplib_3.1.bb
recipes/ftplib/ftplib_3.1.bb new file +38 -0
@@ -0,0 +1,38 @@ +#! /bin/sh + +DESCRIPTION = "A set of routines that implement the FTP protocol" +HOMEPAGE = "http://nbpfaus.net/~pfau/ftplib/" +LICENSE = "LGPLv2" + +PR = "r1" + +###################################################################################### + +TARGET_CC_ARCH += "${LDFLAGS}" + +SRC_URI = "http://nbpfaus.net/~pfau/ftplib/ftplib-${PV}-src.tar.gz" + +S = "${WORKDIR}/ftplib-${PV}" + +###################################################################################### + +SRC_URI[md5sum] = "c6af758ccbf806b28f022a587a41d9c5" +SRC_URI[sha256sum] = "be524e1086cfe9d86afa832e1413dde79a4e88ee8ea5325a87ffaaf6620a0a2b" + +###################################################################################### +do_compile() { + cd linux && make +} + +do_install() { + install -d ${D}/${libdir} + install -d ${D}/${includedir} + install -d ${D}/${bindir} + install -m 755 ${S}/linux/libftp.so.3.1 ${D}/${libdir} + install -m 755 ${S}/linux/libftp.a ${D}/${libdir} + install -m 644 ${S}/linux/ftplib.h ${D}/${includedir} + install -m 755 ${S}/linux/qftp ${D}/${bindir} + (cd ${D}/${libdir} && \ + ln -sf libftp.so.3.1 libftp.so.3 && \ + ln -sf libftp.so.3 libftp.so) +}
Signature · 1 line
1.7.6
Dear Vitaly,
thank you for your patch.
Am Sonntag, den 11.12.2011, 00:10 +0400 schrieb Vitaly Perov:
Quoted 1 line
From: Vitaly Perov <[email protected]>
Please add the recipe version to the commit summary (subject) and follow our commit policy [1][2][3].
Especially your Signed-off-by line is missing. Please also add information how you tested that recipe.
recipes/ftplib/ftplib_3.1.bb line 2
Quoted 13 lines
--- recipes/ftplib/ftplib_3.1.bb | 38 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 38 insertions(+), 0 deletions(-) create mode 100644 recipes/ftplib/ftplib_3.1.bbrecipes/ftplib/ftplib_3.1.bb new file +2
-0@@ -0,0 +1,38 @@ +#! /bin/sh +
The shebang is not needed.
recipes/ftplib/ftplib_3.1.bb line 7
Quoted 5 lines
recipes/ftplib/ftplib_3.1.bb new file +5
-0+DESCRIPTION = "A set of routines that implement the FTP protocol" +HOMEPAGE = "http://nbpfaus.net/~pfau/ftplib/" +LICENSE = "LGPLv2" + +PR = "r1"
Please start with r0 when submitting.
recipes/ftplib/ftplib_3.1.bb line 9
Quoted 2 lines
recipes/ftplib/ftplib_3.1.bb new file +2
-0+ +######################################################################################
Please remove these “style” lines. They are not common. [4]
recipes/ftplib/ftplib_3.1.bb line 11
Quoted 2 lines
recipes/ftplib/ftplib_3.1.bb new file +2
-0+ +TARGET_CC_ARCH += "${LDFLAGS}"
Why is that needed. Please add a comment and explain it in the commit message.
recipes/ftplib/ftplib_3.1.bb line 13
Quoted 2 lines
recipes/ftplib/ftplib_3.1.bb new file +2
-0+ +SRC_URI = "http://nbpfaus.net/~pfau/ftplib/ftplib-${PV}-src.tar.gz"
Can you talk with upstream, that they release versioned tarballs otherwise that will become a mess when upgraded.
recipes/ftplib/ftplib_3.1.bb line 24
Quoted 11 lines
recipes/ftplib/ftplib_3.1.bb new file +11
-0+ +S = "${WORKDIR}/ftplib-${PV}" + +###################################################################################### + +SRC_URI[md5sum] = "c6af758ccbf806b28f022a587a41d9c5" +SRC_URI[sha256sum] = "be524e1086cfe9d86afa832e1413dde79a4e88ee8ea5325a87ffaaf6620a0a2b" + +###################################################################################### +do_compile() { + cd linux && make
Are you sure that works? At least oe-runmake should be used. This way you should get not the correct target architecture since the build host make is used. (I could be mistaken and maybe the Makefile figures it out nevertheless.)
Quoted 4 lines
recipes/ftplib/ftplib_3.1.bb new file +4
-0+} + +do_install() { + install -d ${D}/${libdir}
recipes/ftplib/ftplib_3.1.bb line 38
Quoted 10 lines
recipes/ftplib/ftplib_3.1.bb new file +10
-0+ install -d ${D}/${includedir} + install -d ${D}/${bindir} + install -m 755 ${S}/linux/libftp.so.3.1 ${D}/${libdir} + install -m 755 ${S}/linux/libftp.a ${D}/${libdir} + install -m 644 ${S}/linux/ftplib.h ${D}/${includedir} + install -m 755 ${S}/linux/qftp ${D}/${bindir} + (cd ${D}/${libdir} && \ + ln -sf libftp.so.3.1 libftp.so.3 && \ + ln -sf libftp.so.3 libftp.so) +}
I do not know if the last three lines are common. But if it works, great!
Thanks,
Paul
[1] http://www.openembedded.org/wiki/Category:Policy
[2] http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
[3] http://www.openembedded.org/wiki/Commit_Policy
[4] http://www.openembedded.org/wiki/Styleguide
Dear Paul,
Thank you very much for your comments.
Quoted 106 lines · Paul Menzel
Dear Vitaly,
thank you for your patch.
Am Sonntag, den 11.12.2011, 00:10 +0400 schrieb Vitaly Perov:
Quoted 1 line
From: Vitaly Perov <[email protected]>
Please add the recipe version to the commit summary (subject) and follow our commit policy [1][2][3].
Especially your Signed-off-by line is missing. Please also add information how you tested that recipe.
recipes/ftplib/ftplib_3.1.bb line 2
Quoted 13 lines
---
recipes/ftplib/ftplib_3.1.bb | 38 ++++++++++++++++++++++++++++++++++++++1 files changed, 38 insertions(+), 0 deletions(-)create mode 100644 recipes/ftplib/ftplib_3.1.bb
recipes/ftplib/ftplib_3.1.bb new file +2
-0@@ -0,0 +1,38 @@ +#! /bin/sh +The shebang is not needed.
recipes/ftplib/ftplib_3.1.bb line 7
Quoted 5 lines
recipes/ftplib/ftplib_3.1.bb new file +5
-0+DESCRIPTION = "A set of routines that implement the FTP protocol" +HOMEPAGE = "http://nbpfaus.net/~pfau/ftplib/" +LICENSE = "LGPLv2" + +PR = "r1"Please start with
r0when submitting.recipes/ftplib/ftplib_3.1.bb line 9
Quoted 2 lines
recipes/ftplib/ftplib_3.1.bb new file +2
-0+ +######################################################################################Please remove these “style” lines. They are not common. [4]
recipes/ftplib/ftplib_3.1.bb line 11
Quoted 2 lines
recipes/ftplib/ftplib_3.1.bb new file +2
-0+ +TARGET_CC_ARCH += "${LDFLAGS}"Why is that needed. Please add a comment and explain it in the commit message.
recipes/ftplib/ftplib_3.1.bb line 13
Quoted 2 lines
recipes/ftplib/ftplib_3.1.bb new file +2
-0+ +SRC_URI = "http://nbpfaus.net/~pfau/ftplib/ftplib-${PV}-src.tar.gz"Can you talk with upstream, that they release versioned tarballs otherwise that will become a mess when upgraded.
recipes/ftplib/ftplib_3.1.bb line 24
Quoted 11 lines
recipes/ftplib/ftplib_3.1.bb new file +11
-0+ +S = "${WORKDIR}/ftplib-${PV}" + +###################################################################################### + +SRC_URI[md5sum] = "c6af758ccbf806b28f022a587a41d9c5" +SRC_URI[sha256sum] = "be524e1086cfe9d86afa832e1413dde79a4e88ee8ea5325a87ffaaf6620a0a2b" + +###################################################################################### +do_compile() { + cd linux && makeAre you sure that works? At least
oe-runmakeshould be used. This way you should get not the correct target architecture since the build host make is used. (I could be mistaken and maybe theMakefilefigures it out nevertheless.)Quoted 4 lines
recipes/ftplib/ftplib_3.1.bb new file +4
-0+} + +do_install() { + install -d ${D}/${libdir}recipes/ftplib/ftplib_3.1.bb line 38
Quoted 10 lines
recipes/ftplib/ftplib_3.1.bb new file +10
-0+ install -d ${D}/${includedir} + install -d ${D}/${bindir} + install -m 755 ${S}/linux/libftp.so.3.1 ${D}/${libdir} + install -m 755 ${S}/linux/libftp.a ${D}/${libdir} + install -m 644 ${S}/linux/ftplib.h ${D}/${includedir} + install -m 755 ${S}/linux/qftp ${D}/${bindir} + (cd ${D}/${libdir} && \ + ln -sf libftp.so.3.1 libftp.so.3 && \ + ln -sf libftp.so.3 libftp.so) +}I do not know if the last three lines are common. But if it works, great!
Thanks,
Paul
[1] http://www.openembedded.org/wiki/Category:Policy
[2] http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
[3] http://www.openembedded.org/wiki/Commit_Policy
[4] http://www.openembedded.org/wiki/Styleguide_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel