video: omap: Staticise non-exported symbols

PATCH Applied Axel Lin 7 participants 8 messages Dec 9, 2011 – Dec 12, 2011

Subsystems (3)

HID Framebuffer layer Input drivers

lore

Share & tools

lore

Axel Lin

author

2011-12-09 01:37 UTC #0 lore raw

PATCH 1/2 video: omap: Staticise non-exported symbols

These symbols are not used outside it's driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/video/omap/lcd_ams_delta.c |    2 +-
 drivers/video/omap/lcd_h3.c        |    2 +-
 drivers/video/omap/lcd_htcherald.c |    2 +-
 drivers/video/omap/lcd_inn1510.c   |    2 +-
 drivers/video/omap/lcd_inn1610.c   |    2 +-
 drivers/video/omap/lcd_osk.c       |    2 +-
 drivers/video/omap/lcd_palmte.c    |    2 +-
 drivers/video/omap/lcd_palmtt.c    |    2 +-
 drivers/video/omap/lcd_palmz71.c   |    2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

drivers/video/omap/lcd_ams_delta.c +1 -1

index 6978ae4..eb50a95 100644
@@ -198,7 +198,7 @@ static int ams_delta_panel_resume(struct platform_device *pdev)
 	return 0;
 }
 
-struct platform_driver ams_delta_panel_driver = {
+static struct platform_driver ams_delta_panel_driver = {
 	.probe		= ams_delta_panel_probe,
 	.remove		= ams_delta_panel_remove,
 	.suspend	= ams_delta_panel_suspend,

drivers/video/omap/lcd_h3.c +1 -1

index 622ad83..baec34e 100644
@@ -113,7 +113,7 @@ static int h3_panel_resume(struct platform_device *pdev)
 	return 0;
 }
 
-struct platform_driver h3_panel_driver = {
+static struct platform_driver h3_panel_driver = {
 	.probe		= h3_panel_probe,
 	.remove		= h3_panel_remove,
 	.suspend	= h3_panel_suspend,

drivers/video/omap/lcd_htcherald.c +1 -1

index 4802419..b1a022f 100644
@@ -104,7 +104,7 @@ static int htcherald_panel_resume(struct platform_device *pdev)
 	return 0;
 }
 
-struct platform_driver htcherald_panel_driver = {
+static struct platform_driver htcherald_panel_driver = {
 	.probe		= htcherald_panel_probe,
 	.remove		= htcherald_panel_remove,
 	.suspend	= htcherald_panel_suspend,

drivers/video/omap/lcd_inn1510.c +1 -1

index 3271f16..d129946 100644
@@ -98,7 +98,7 @@ static int innovator1510_panel_resume(struct platform_device *pdev)
 	return 0;
 }
 
-struct platform_driver innovator1510_panel_driver = {
+static struct platform_driver innovator1510_panel_driver = {
 	.probe		= innovator1510_panel_probe,
 	.remove		= innovator1510_panel_remove,
 	.suspend	= innovator1510_panel_suspend,

drivers/video/omap/lcd_inn1610.c +1 -1

index 12cc52a..a95756b 100644
@@ -122,7 +122,7 @@ static int innovator1610_panel_resume(struct platform_device *pdev)
 	return 0;
 }
 
-struct platform_driver innovator1610_panel_driver = {
+static struct platform_driver innovator1610_panel_driver = {
 	.probe		= innovator1610_panel_probe,
 	.remove		= innovator1610_panel_remove,
 	.suspend	= innovator1610_panel_suspend,

drivers/video/omap/lcd_osk.c +1 -1

index 6f8d13c..b985997 100644
@@ -116,7 +116,7 @@ static int osk_panel_resume(struct platform_device *pdev)
 	return 0;
 }
 
-struct platform_driver osk_panel_driver = {
+static struct platform_driver osk_panel_driver = {
 	.probe		= osk_panel_probe,
 	.remove		= osk_panel_remove,
 	.suspend	= osk_panel_suspend,

drivers/video/omap/lcd_palmte.c +1 -1

index 4cb3017..d79f436 100644
@@ -97,7 +97,7 @@ static int palmte_panel_resume(struct platform_device *pdev)
 	return 0;
 }
 
-struct platform_driver palmte_panel_driver = {
+static struct platform_driver palmte_panel_driver = {
 	.probe		= palmte_panel_probe,
 	.remove		= palmte_panel_remove,
 	.suspend	= palmte_panel_suspend,

drivers/video/omap/lcd_palmtt.c +1 -1

index b51b332..c2e96a7 100644
@@ -102,7 +102,7 @@ static int palmtt_panel_resume(struct platform_device *pdev)
 	return 0;
 }
 
-struct platform_driver palmtt_panel_driver = {
+static struct platform_driver palmtt_panel_driver = {
 	.probe		= palmtt_panel_probe,
 	.remove		= palmtt_panel_remove,
 	.suspend	= palmtt_panel_suspend,

drivers/video/omap/lcd_palmz71.c +1 -1

index 2334e56..1ab4847 100644
@@ -98,7 +98,7 @@ static int palmz71_panel_resume(struct platform_device *pdev)
 	return 0;
 }
 
-struct platform_driver palmz71_panel_driver = {
+static struct platform_driver palmz71_panel_driver = {
 	.probe		= palmz71_panel_probe,
 	.remove		= palmz71_panel_remove,
 	.suspend	= palmz71_panel_suspend,

Signature · 1 line

1.7.5.4

Axel Lin

author

2011-12-09 01:39 UTC #1 lore raw

PATCH 2/2 Input: keyboard: Staticise non-exported symbols

These symbols are not used outside it's driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/input/keyboard/bf54x-keys.c         |    2 +-
 drivers/input/keyboard/nomadik-ske-keypad.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/input/keyboard/bf54x-keys.c +1 -1

index 683e314..8eb9116 100644
@@ -384,7 +384,7 @@ static int bfin_kpad_resume(struct platform_device *pdev)
 # define bfin_kpad_resume  NULL
 #endif
 
-struct platform_driver bfin_kpad_device_driver = {
+static struct platform_driver bfin_kpad_device_driver = {
 	.driver		= {
 		.name	= DRV_NAME,
 		.owner	= THIS_MODULE,

drivers/input/keyboard/nomadik-ske-keypad.c +1 -1

index 6c4828f..5a71e55 100644
@@ -379,7 +379,7 @@ static const struct dev_pm_ops ske_keypad_dev_pm_ops = {
 };
 #endif
 
-struct platform_driver ske_keypad_driver = {
+static struct platform_driver ske_keypad_driver = {
 	.driver = {
 		.name = "nmk-ske-keypad",
 		.owner  = THIS_MODULE,

Signature · 1 line

1.7.5.4

Michael Hennerich

Acked-by on v1 2/2

2011-12-09 08:25 UTC #2 lore raw

Re: [PATCH 2/2] Input: keyboard: Staticise non-exported symbols

Quoted 4 lines · Axel Lin

These symbols are not used outside it's driver so no need to make the symbol global.
Signed-off-by Axel Lin<[email protected]>

Acked-by Michael Hennerich <[email protected]>

Quoted 31 lines

---
  drivers/input/keyboard/bf54x-keys.c         |    2 +-
  drivers/input/keyboard/nomadik-ske-keypad.c |    2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

drivers/input/keyboard/bf54x-keys.c +1 -1

index 683e314..8eb9116 100644
@@ -384,7 +384,7 @@ static int bfin_kpad_resume(struct platform_device *pdev)
  # define bfin_kpad_resume  NULL
  #endif
 
-struct platform_driver bfin_kpad_device_driver = {
+static struct platform_driver bfin_kpad_device_driver = {
  	.driver		= {
  		.name	= DRV_NAME,
  		.owner	= THIS_MODULE,

drivers/input/keyboard/nomadik-ske-keypad.c +1 -1

index 6c4828f..5a71e55 100644
@@ -379,7 +379,7 @@ static const struct dev_pm_ops ske_keypad_dev_pm_ops = {
  };
  #endif
 
-struct platform_driver ske_keypad_driver = {
+static struct platform_driver ske_keypad_driver = {
  	.driver = {
  		.name = "nmk-ske-keypad",
  		.owner  = THIS_MODULE,

Signature · 8 lines

Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif

Linus Walleij

Acked-by on v1 2/2

2011-12-09 12:01 UTC #3 lore raw

Re: [PATCH 2/2] Input: keyboard: Staticise non-exported symbols

In reply to Axel Lin

Quoted 4 lines · Axel Lin

These symbols are not used outside it's driver so no need to make the symbol global.
Signed-off-by Axel Lin <[email protected]>

Acked-by Linus Walleij <[email protected]>

For SKE.

Linus Walleij

Dmitry Torokhov

maintainer Applied

2011-12-12 07:45 UTC #4 lore raw

Re: [PATCH 2/2] Input: keyboard: Staticise non-exported symbols

In reply to Axel Lin

Quoted 3 lines · Axel Lin

These symbols are not used outside it's driver so no need to make the symbol global.

Applied, thank you Axel.

Signature · 1 line

Dmitry

Marek Vasut

Acked-by on v1 1/2

2011-12-09 08:23 UTC #5 lore raw

In reply to Axel Lin

Quoted 125 lines

These symbols are not used outside it's driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/video/omap/lcd_ams_delta.c |    2 +-
 drivers/video/omap/lcd_h3.c        |    2 +-
 drivers/video/omap/lcd_htcherald.c |    2 +-
 drivers/video/omap/lcd_inn1510.c   |    2 +-
 drivers/video/omap/lcd_inn1610.c   |    2 +-
 drivers/video/omap/lcd_osk.c       |    2 +-
 drivers/video/omap/lcd_palmte.c    |    2 +-
 drivers/video/omap/lcd_palmtt.c    |    2 +-
 drivers/video/omap/lcd_palmz71.c   |    2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

(quoted diff) +0 -0

b/drivers/video/omap/lcd_ams_delta.c index 6978ae4..eb50a95 100644

drivers/video/omap/lcd_ams_delta.c +1 -1

@@ -198,7 +198,7 @@ static int ams_delta_panel_resume(struct
 platform_device *pdev) return 0;
 }
 
-struct platform_driver ams_delta_panel_driver = {
+static struct platform_driver ams_delta_panel_driver = {
 	.probe		= ams_delta_panel_probe,
 	.remove		= ams_delta_panel_remove,
 	.suspend	= ams_delta_panel_suspend,

drivers/video/omap/lcd_h3.c +1 -1

index 622ad83..baec34e 100644
@@ -113,7 +113,7 @@ static int h3_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver h3_panel_driver = {
+static struct platform_driver h3_panel_driver = {
 	.probe		= h3_panel_probe,
 	.remove		= h3_panel_remove,
 	.suspend	= h3_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_htcherald.c index 4802419..b1a022f 100644

drivers/video/omap/lcd_htcherald.c +1 -1

@@ -104,7 +104,7 @@ static int htcherald_panel_resume(struct
 platform_device *pdev) return 0;
 }
 
-struct platform_driver htcherald_panel_driver = {
+static struct platform_driver htcherald_panel_driver = {
 	.probe		= htcherald_panel_probe,
 	.remove		= htcherald_panel_remove,
 	.suspend	= htcherald_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_inn1510.c index 3271f16..d129946 100644

drivers/video/omap/lcd_inn1510.c +1 -1

@@ -98,7 +98,7 @@ static int innovator1510_panel_resume(struct
 platform_device *pdev) return 0;
 }
 
-struct platform_driver innovator1510_panel_driver = {
+static struct platform_driver innovator1510_panel_driver = {
 	.probe		= innovator1510_panel_probe,
 	.remove		= innovator1510_panel_remove,
 	.suspend	= innovator1510_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_inn1610.c index 12cc52a..a95756b 100644

drivers/video/omap/lcd_inn1610.c +1 -1

@@ -122,7 +122,7 @@ static int innovator1610_panel_resume(struct
 platform_device *pdev) return 0;
 }
 
-struct platform_driver innovator1610_panel_driver = {
+static struct platform_driver innovator1610_panel_driver = {
 	.probe		= innovator1610_panel_probe,
 	.remove		= innovator1610_panel_remove,
 	.suspend	= innovator1610_panel_suspend,

drivers/video/omap/lcd_osk.c +1 -1

index 6f8d13c..b985997 100644
@@ -116,7 +116,7 @@ static int osk_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver osk_panel_driver = {
+static struct platform_driver osk_panel_driver = {
 	.probe		= osk_panel_probe,
 	.remove		= osk_panel_remove,
 	.suspend	= osk_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_palmte.c index 4cb3017..d79f436 100644

drivers/video/omap/lcd_palmte.c +1 -1

@@ -97,7 +97,7 @@ static int palmte_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver palmte_panel_driver = {
+static struct platform_driver palmte_panel_driver = {
 	.probe		= palmte_panel_probe,
 	.remove		= palmte_panel_remove,
 	.suspend	= palmte_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_palmtt.c index b51b332..c2e96a7 100644

drivers/video/omap/lcd_palmtt.c +1 -1

@@ -102,7 +102,7 @@ static int palmtt_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver palmtt_panel_driver = {
+static struct platform_driver palmtt_panel_driver = {
 	.probe		= palmtt_panel_probe,
 	.remove		= palmtt_panel_remove,
 	.suspend	= palmtt_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_palmz71.c index 2334e56..1ab4847 100644

drivers/video/omap/lcd_palmz71.c static int palmz71_panel_resume(struct platform_device · line 104

Quoted 8 lines

drivers/video/omap/lcd_palmz71.c +1 -1

@@ -98,7 +98,7 @@ static int palmz71_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver palmz71_panel_driver = {
+static struct platform_driver palmz71_panel_driver = {
 	.probe		= palmz71_panel_probe,
 	.remove		= palmz71_panel_remove,
 	.suspend	= palmz71_panel_suspend,

I can speak for palmtt and palmz71,

Acked-by Marek Vasut <[email protected]>

Jonathan McDowell

Acked-by

2011-12-09 21:59 UTC #6 lore raw

Quoted 136 lines · Marek Vasut

Quoted 125 lines

These symbols are not used outside it's driver so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/video/omap/lcd_ams_delta.c |    2 +-
 drivers/video/omap/lcd_h3.c        |    2 +-
 drivers/video/omap/lcd_htcherald.c |    2 +-
 drivers/video/omap/lcd_inn1510.c   |    2 +-
 drivers/video/omap/lcd_inn1610.c   |    2 +-
 drivers/video/omap/lcd_osk.c       |    2 +-
 drivers/video/omap/lcd_palmte.c    |    2 +-
 drivers/video/omap/lcd_palmtt.c    |    2 +-
 drivers/video/omap/lcd_palmz71.c   |    2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

(quoted diff) +0 -0

b/drivers/video/omap/lcd_ams_delta.c index 6978ae4..eb50a95 100644

drivers/video/omap/lcd_ams_delta.c +1 -1

@@ -198,7 +198,7 @@ static int ams_delta_panel_resume(struct
 platform_device *pdev) return 0;
 }
 
-struct platform_driver ams_delta_panel_driver = {
+static struct platform_driver ams_delta_panel_driver = {
 	.probe		= ams_delta_panel_probe,
 	.remove		= ams_delta_panel_remove,
 	.suspend	= ams_delta_panel_suspend,

drivers/video/omap/lcd_h3.c +1 -1

index 622ad83..baec34e 100644
@@ -113,7 +113,7 @@ static int h3_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver h3_panel_driver = {
+static struct platform_driver h3_panel_driver = {
 	.probe		= h3_panel_probe,
 	.remove		= h3_panel_remove,
 	.suspend	= h3_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_htcherald.c index 4802419..b1a022f 100644

drivers/video/omap/lcd_htcherald.c +1 -1

@@ -104,7 +104,7 @@ static int htcherald_panel_resume(struct
 platform_device *pdev) return 0;
 }
 
-struct platform_driver htcherald_panel_driver = {
+static struct platform_driver htcherald_panel_driver = {
 	.probe		= htcherald_panel_probe,
 	.remove		= htcherald_panel_remove,
 	.suspend	= htcherald_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_inn1510.c index 3271f16..d129946 100644

drivers/video/omap/lcd_inn1510.c +1 -1

@@ -98,7 +98,7 @@ static int innovator1510_panel_resume(struct
 platform_device *pdev) return 0;
 }
 
-struct platform_driver innovator1510_panel_driver = {
+static struct platform_driver innovator1510_panel_driver = {
 	.probe		= innovator1510_panel_probe,
 	.remove		= innovator1510_panel_remove,
 	.suspend	= innovator1510_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_inn1610.c index 12cc52a..a95756b 100644

drivers/video/omap/lcd_inn1610.c +1 -1

@@ -122,7 +122,7 @@ static int innovator1610_panel_resume(struct
 platform_device *pdev) return 0;
 }
 
-struct platform_driver innovator1610_panel_driver = {
+static struct platform_driver innovator1610_panel_driver = {
 	.probe		= innovator1610_panel_probe,
 	.remove		= innovator1610_panel_remove,
 	.suspend	= innovator1610_panel_suspend,

drivers/video/omap/lcd_osk.c +1 -1

index 6f8d13c..b985997 100644
@@ -116,7 +116,7 @@ static int osk_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver osk_panel_driver = {
+static struct platform_driver osk_panel_driver = {
 	.probe		= osk_panel_probe,
 	.remove		= osk_panel_remove,
 	.suspend	= osk_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_palmte.c index 4cb3017..d79f436 100644

drivers/video/omap/lcd_palmte.c +1 -1

@@ -97,7 +97,7 @@ static int palmte_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver palmte_panel_driver = {
+static struct platform_driver palmte_panel_driver = {
 	.probe		= palmte_panel_probe,
 	.remove		= palmte_panel_remove,
 	.suspend	= palmte_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_palmtt.c index b51b332..c2e96a7 100644

drivers/video/omap/lcd_palmtt.c +1 -1

@@ -102,7 +102,7 @@ static int palmtt_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver palmtt_panel_driver = {
+static struct platform_driver palmtt_panel_driver = {
 	.probe		= palmtt_panel_probe,
 	.remove		= palmtt_panel_remove,
 	.suspend	= palmtt_panel_suspend,

(quoted diff) +0 -0

b/drivers/video/omap/lcd_palmz71.c index 2334e56..1ab4847 100644

drivers/video/omap/lcd_palmz71.c static int palmz71_panel_resume(struct platform_device · line 104

Quoted 8 lines

drivers/video/omap/lcd_palmz71.c +1 -1

@@ -98,7 +98,7 @@ static int palmz71_panel_resume(struct platform_device
 *pdev) return 0;
 }
 
-struct platform_driver palmz71_panel_driver = {
+static struct platform_driver palmz71_panel_driver = {
 	.probe		= palmz71_panel_probe,
 	.remove		= palmz71_panel_remove,
 	.suspend	= palmz71_panel_suspend,

I can speak for palmtt and palmz71,

Quoted 1 line

Acked-by Marek Vasut <[email protected]>

Likewise, for ams-delta,

Acked-by Jonathan McDowell <[email protected]>

Signature · 3 lines

Generally, all generalizations are false..
This .sig brought to you by the letter Z and the number 26
Product of the Republic of HuggieTag

Tomi Valkeinen

Applied

2011-12-12 10:45 UTC #7 lore raw

In reply to Axel Lin

Quoted 4 lines · Axel Lin

These symbols are not used outside it's driver so no need to make the symbol global.
Signed-off-by Axel Lin <[email protected]>

Thanks, applied to DSS tree.

Tomi