Skip to contentSkip to conversation

Only warn about non-tackled IPv6 packets once

PATCH Applied David Sommerseth 3 participants 3 messages Dec 13, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Only warn about non-tackled IPv6 packets once

When using OpenVPN 2.2 on clients and server with Windows based clients, it will try to push IPv6 packets through the tunnel. This causes the server log to be filled up with log entries like this:

Wed Jun 29 22:12:51 2011 username/1.2.3.4:56990 Need IPv6 code in mroute_extract_addr_from_packet

This patch modifies this message to state that IPv6 packets are not tackled in tun mode, and prints it only once.

Trac: 147

---
 mroute.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
mroute.c +6 -1
index 3debd80..1b3488f 100644
@@ -131,6 +131,8 @@ mroute_extract_addr_ipv4 (struct mroute_addr *src,
 			  const struct buffer *buf)
 {
   unsigned int ret = 0;
+  static bool ipv6warned = false;
+
   if (BLEN (buf) >= 1)
     {
       switch (OPENVPN_IPH_GET_VER (*BPTR(buf)))
@@ -156,7 +158,10 @@ mroute_extract_addr_ipv4 (struct mroute_addr *src,
 	  break;
 	case 6:
 	  {
-	    msg (M_WARN, "Need IPv6 code in mroute_extract_addr_from_packet"); 
+            if( !ipv6warned ) {
+              msg (M_WARN, "IPv6 in tun mode is not supported in OpenVPN 2.2");
+              ipv6warned = true;
+            }
 	    break;
 	  }
 	}
Signature · 1 line
1.7.4.4
#1 lore raw

Hi,

Quoted 8 lines · David Sommerseth

When using OpenVPN 2.2 on clients and server with Windows based clients, it will try to push IPv6 packets through the tunnel. This causes the server log to be filled up with log entries like this:

Wed Jun 29 22:12:51 2011 username/1.2.3.4:56990 Need IPv6 code in mroute_extract_addr_from_packet

This patch modifies this message to state that IPv6 packets are not tackled in tun mode, and prints it only once.

ACK. I thought this was on my work plate, but I'm fine with your patch, and that leaves me more time to work on other issues :)

thanks,

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
#2 lore raw
In reply to David Sommerseth

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 7 lines · David Sommerseth

When using OpenVPN 2.2 on clients and server with Windows based clients, it will try to push IPv6 packets through the tunnel. This causes the server log to be filled up with log entries like this:

Wed Jun 29 22:12:51 2011 username/1.2.3.4:56990 Need IPv6 code in mroute_extract_addr_from_packet

Quoted 7 lines

This patch modifies this message to state that IPv6 packets are not tackled in tun mode, and prints it only once.

Trac: 147 Signed-off-by: David Sommerseth <[email protected]...> ---
mroute.c | 7 ++++++- 1 files changed, 6 insertions(+), 1
deletions(-)

Applied to the release/2.2 branch on -stable.

commit b7bbe47a7fcfa74297ff04a50982b70113f28f96

Author: David Sommerseth <[email protected]...>
Date:   Tue Dec 13 18:08:24 2011 +0100
    Trac: 147
    Signed-off-by: David Sommerseth <[email protected]...>
    Acked-by: Gert Doering <[email protected]...>

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7nszsACgkQDC186MBRfrrNwgCfeoFmvRVlo2FHfPdAbIFTyKSO //0An0C09d33Oo0FhwrDsr3M1ax6GxV7
=irRp
-----END PGP SIGNATURE-----