opkg: Update svn 625 -> 633 and fix preinst issues

PATCH New Richard Purdie 4 participants 15 messages Dec 15, 2011 – Dec 19, 2011

Share & tools

Richard Purdie

author

2011-12-15 21:15 UTC #0 lore raw

There is a major issue with opkg images at the moment as preinst functions are not being executed before their dependencies are installed and this is leading to corruption of images containing avahi/dbus in particular.

There are various changes in upstream opkg in the last 8 revisions which make changes in this area but sadly these aren't enough to get things working for us. I've updated to the latest svn revision with this patch since it makes sense to pull in those changes first and then supplement them with the attached patches.

There is a full description of the patches in the patch headers but in summary they:

a) Ensure preinst functions execute with their dependencies installed. This is a pretty invasive change as it changes the package install ordering in general.
b) Ensure opkg sets $D, not $PKG_ROOT which we don't use
c) Change opkg to allow execution of postinstall functions which fail resulting in execution on the target device as rootfs_ipk.bbclass currently does manually.

The remaining changes interface this with the rest of the OE build infrastructure, adding in the option to tell opkg to run the preinst and postinst functions, ensure the correct environment is present for the postinst scripts and removing the now unneeded rootfs_ipk class code which opkg now does itself.

[YOCTO #1711]

Signed-off-by Richard Purdie <[email protected]>

meta/classes/package_ipk.bbclass +1 -1

index 1633aff..aeabc11 100644
@@ -133,7 +133,7 @@ package_install_internal_ipk() {
 
 	mkdir -p ${target_rootfs}${localstatedir}/lib/opkg/
 
-	local ipkg_args="-f ${conffile} -o ${target_rootfs} --force-overwrite"
+	local ipkg_args="-f ${conffile} -o ${target_rootfs} --force-overwrite --force_postinstall"
 
 	opkg-cl ${ipkg_args} update

meta/classes/rootfs_ipk.bbclass +3 ~~-23~~

index ec01951..b5556fa 100644
@@ -60,14 +60,14 @@ fakeroot rootfs_ipk_do_rootfs () {
 	export INSTALL_CONF_IPK="${IPKGCONF_TARGET}"
 	export INSTALL_PACKAGES_IPK="${PACKAGE_INSTALL}"
 
-	package_install_internal_ipk
-
 	#post install
 	export D=${IMAGE_ROOTFS}
 	export OFFLINE_ROOT=${IMAGE_ROOTFS}
 	export IPKG_OFFLINE_ROOT=${IMAGE_ROOTFS}
 	export OPKG_OFFLINE_ROOT=${IPKG_OFFLINE_ROOT}
 
+	package_install_internal_ipk
+
 	# Distro specific packages should create this
 	#mkdir -p ${IMAGE_ROOTFS}/etc/opkg/
 	#grep "^arch" ${IPKGCONF_TARGET} >${IMAGE_ROOTFS}/etc/opkg/arch.conf

@@ -75,28 +75,8 @@ fakeroot rootfs_ipk_do_rootfs () {
 	${OPKG_POSTPROCESS_COMMANDS}
 	${ROOTFS_POSTINSTALL_COMMAND}
 	
-	runtime_script_required=0
-
-	# Base-passwd needs to run first to install /etc/passwd and friends
-	if [ -e ${IMAGE_ROOTFS}${opkglibdir}/info/base-passwd.preinst ] ; then
-		sh ${IMAGE_ROOTFS}${opkglibdir}/info/base-passwd.preinst
-	fi
-
-	for i in ${IMAGE_ROOTFS}${opkglibdir}/info/*.preinst; do
-		if [ -f $i ] && ! sh $i; then
-		     	runtime_script_required=1
-			opkg-cl ${IPKG_ARGS} flag unpacked `basename $i .preinst`
-		fi
-	done
-	for i in ${IMAGE_ROOTFS}${opkglibdir}/info/*.postinst; do
-		if [ -f $i ] && ! sh $i configure; then
-		     	runtime_script_required=1
-			opkg-cl ${IPKG_ARGS} flag unpacked `basename $i .postinst`
-		fi
-	done
-
 	if ${@base_contains("IMAGE_FEATURES", "read-only-rootfs", "true", "false" ,d)}; then
-		if [ $runtime_script_required -eq 1 ]; then
+		if grep Status:.install.ok.unpacked ${IMAGE_ROOTFS}${opkglibdir}status; then
 			echo "Some packages could not be configured offline and rootfs is read-only."
 			exit 1
 		fi

meta/recipes-devtools/opkg/opkg/fix_installorder.patch new file +174 -0

174 lines not on this page · raw message

meta/recipes-devtools/opkg/opkg/offline_postinstall.patch new file +57 -0

57 lines not on this page · raw message

meta/recipes-devtools/opkg/opkg/offlineroot_varname.patch new file +20 -0

new file mode 100644
index 0000000..a67f389
@@ -0,0 +1,20 @@
+OE uses D as the offline install directory in its scripts, not PKG_ROOT.
+
+Upstream-Status: Inappropriate [OE specific usage]
+
+RP 2011/12/15
+
+Index: trunk/libopkg/pkg.c
+===================================================================
+--- trunk.orig/libopkg/pkg.c	2011-12-15 15:58:39.000000000 +0000
++++ trunk/libopkg/pkg.c	2011-12-15 20:04:50.109992736 +0000
+@@ -1280,7 +1280,7 @@
+ 
+      opkg_msg(INFO, "Running script %s.\n", path);
+ 
+-     setenv("PKG_ROOT",
++     setenv("D",
+ 	    pkg->dest ? pkg->dest->root_dir : conf->default_dest->root_dir, 1);
+ 
+      if (! file_exists(path)) {
+

meta/recipes-devtools/opkg/opkg_svn.bb +5 -2

index acb21f2..2645d52 100644
@@ -12,13 +12,16 @@ RREPLACES_${PN} = "opkg-nogpg"
 SRC_URI = "svn://opkg.googlecode.com/svn;module=trunk;proto=http \
            file://add_vercmp.patch \
            file://add_uname_support.patch \
+           file://fix_installorder.patch \
+           file://offline_postinstall.patch\
+           file://offlineroot_varname.patch \
 "
 
 S = "${WORKDIR}/trunk"
 
-SRCREV = "625"
+SRCREV = "633"
 PV = "0.1.8+svnr${SRCPV}"
-PR = "r4"
+PR = "r2"
 
 PACKAGES =+ "libopkg${PKGSUFFIX}-dev libopkg${PKGSUFFIX} update-alternatives-cworth${PKGSUFFIX}"

Martin Jansa

2011-12-17 01:24 UTC #1 lore raw

Quoted 22 lines · Richard Purdie

There is a major issue with opkg images at the moment as preinst functions are not being executed before their dependencies are installed and this is leading to corruption of images containing avahi/dbus in particular.
There are various changes in upstream opkg in the last 8 revisions which make changes in this area but sadly these aren't enough to get things working for us. I've updated to the latest svn revision with this patch since it makes sense to pull in those changes first and then supplement them with the attached patches.
There is a full description of the patches in the patch headers but in summary they:
a) Ensure preinst functions execute with their dependencies installed. This is a pretty invasive change as it changes the package install ordering in general.
b) Ensure opkg sets $D, not $PKG_ROOT which we don't use
c) Change opkg to allow execution of postinstall functions which fail resulting in execution on the target device as rootfs_ipk.bbclass currently does manually.

Quoted 7 lines

The remaining changes interface this with the rest of the OE build infrastructure, adding in the option to tell opkg to run the preinst and postinst functions, ensure the correct environment is present for the postinst scripts and removing the now unneeded rootfs_ipk class code which opkg now does itself.
[YOCTO #1711]

Hi,

today I got image build failing with this and it seems like some kind of circular dependency or something.

In fsogsmd_git.bb we have:
PACKAGES =+ "${PN}-connman ${PN}-connman-dev ${PN}-connman-dbg" RDEPENDS_${PN} += "${PN}-connman"

and there is also fsogsmd-connman dependency on fsogsmd (because of shlibs), so it's really circular dependency between runtime packages and new opkg cannot deal with it.

Then in log.do_rootfs
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
and then this last 2 lines 1794/2 times
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing task-core-ssh-openssh (1.0-r0) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/armv5te/task-core-ssh-openssh_1.0-r0_armv5te.ipk.
...
and in the end:
ERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-lite-image/2.0-r20/temp/log.do_rootfs.20387 for further information) Collected errors:
* gz_close: Unzip process killed by signal 11.

* pkg_get_installed_files: Error extracting file list from /tmp/opkg-T7G08e/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk.
* opkg_install_cmd: Cannot install package task-shr-minimal-apps.

Reverting this patch and rebuilding opkg before running image build helps.

I'll try to upgrade only opkg without your patches first, but I guess it's because of fix_installorder.patch, can we teach it to break circular dependencies or should I fix it in metadata? It seem that longer cycles like

fsogsmd-config -> fsogsmd-module-modem-ti-calypso -> fsogsmd -> fsogsmd-config

does work.

Regards,

Quoted 365 lines

Signed-off-by Richard Purdie <[email protected]>

meta/classes/package_ipk.bbclass +1 -1

index 1633aff..aeabc11 100644
@@ -133,7 +133,7 @@ package_install_internal_ipk() {
 
 	mkdir -p ${target_rootfs}${localstatedir}/lib/opkg/
 
-	local ipkg_args="-f ${conffile} -o ${target_rootfs} --force-overwrite"
+	local ipkg_args="-f ${conffile} -o ${target_rootfs} --force-overwrite --force_postinstall"
 
 	opkg-cl ${ipkg_args} update

meta/classes/rootfs_ipk.bbclass +3 ~~-23~~

index ec01951..b5556fa 100644
@@ -60,14 +60,14 @@ fakeroot rootfs_ipk_do_rootfs () {
 	export INSTALL_CONF_IPK="${IPKGCONF_TARGET}"
 	export INSTALL_PACKAGES_IPK="${PACKAGE_INSTALL}"
 
-	package_install_internal_ipk
-
 	#post install
 	export D=${IMAGE_ROOTFS}
 	export OFFLINE_ROOT=${IMAGE_ROOTFS}
 	export IPKG_OFFLINE_ROOT=${IMAGE_ROOTFS}
 	export OPKG_OFFLINE_ROOT=${IPKG_OFFLINE_ROOT}
 
+	package_install_internal_ipk
+
 	# Distro specific packages should create this
 	#mkdir -p ${IMAGE_ROOTFS}/etc/opkg/
 	#grep "^arch" ${IPKGCONF_TARGET} >${IMAGE_ROOTFS}/etc/opkg/arch.conf

@@ -75,28 +75,8 @@ fakeroot rootfs_ipk_do_rootfs () {
 	${OPKG_POSTPROCESS_COMMANDS}
 	${ROOTFS_POSTINSTALL_COMMAND}
 
-	runtime_script_required=0
-
-	# Base-passwd needs to run first to install /etc/passwd and friends
-	if [ -e ${IMAGE_ROOTFS}${opkglibdir}/info/base-passwd.preinst ] ; then
-		sh ${IMAGE_ROOTFS}${opkglibdir}/info/base-passwd.preinst
-	fi
-
-	for i in ${IMAGE_ROOTFS}${opkglibdir}/info/*.preinst; do
-		if [ -f $i ] && ! sh $i; then
-		     	runtime_script_required=1
-			opkg-cl ${IPKG_ARGS} flag unpacked `basename $i .preinst`
-		fi
-	done
-	for i in ${IMAGE_ROOTFS}${opkglibdir}/info/*.postinst; do
-		if [ -f $i ] && ! sh $i configure; then
-		     	runtime_script_required=1
-			opkg-cl ${IPKG_ARGS} flag unpacked `basename $i .postinst`
-		fi
-	done
-
 	if ${@base_contains("IMAGE_FEATURES", "read-only-rootfs", "true", "false" ,d)}; then
-		if [ $runtime_script_required -eq 1 ]; then
+		if grep Status:.install.ok.unpacked ${IMAGE_ROOTFS}${opkglibdir}status; then
 			echo "Some packages could not be configured offline and rootfs is read-only."
 			exit 1
 		fi

meta/recipes-devtools/opkg/opkg/fix_installorder.patch new file +174 -0

new file mode 100644
index 0000000..e782ce7
@@ -0,0 +1,174 @@
+There is a problem with dependency order when installing packages. The key 
+problem revolves around the satisfy_dependencies_for() function which is 
+called from opkg_install_pkg just before the installation (and preinst)
+happens.
+
+The satisfy_dependencies_for() function calls pkg_hash_fetch_unsatisfied_dependencies()
+which will only return packages which were previously not marked as 
+*going* to be installed at some point. For the purposes of 
+opkg_install_pkg() we really need to know which dependencies haven't been 
+installed yet.
+
+This patch adds pkg_hash_fetch_satisfied_dependencies() which returns a 
+list of package dependencies. We can then directly check the status of 
+these and ensure any hard dependencies (not suggestions or recommendations)
+are installed before returning.
+
+Consider the situation (where -> means 'depends on'):
+
+X -> A,E
+A -> B,E
+E -> B
+B -> C
+
+Currently X would install A and E. When installing A the packages B, E 
+and C would be marked as "to install". When the package B is considered
+the second time (as a dependency of E rather than A), it would install 
+straight away even though C was not currently installed, just marked
+as needing to be installed.
+
+The patch changes the behaviour so B can't install until C really is installed.
+
+This change is required to run the postinst scripts in the correct order.
+
+Upstream-Status: Pending
+
+RP 2011/12/15
+
+Index: trunk/libopkg/opkg_install.c
+===================================================================
+--- trunk.orig/libopkg/opkg_install.c	2011-12-15 15:58:39.000000000 +0000
++++ trunk/libopkg/opkg_install.c	2011-12-15 15:58:41.838334788 +0000
+@@ -76,6 +77,27 @@
+      }
+ 
+      if (ndepends <= 0) {
++	  pkg_vec_free(depends);      
++	  depends = pkg_hash_fetch_satisfied_dependencies(pkg);
++
++	  for (i = 0; i < depends->len; i++) {
++	       dep = depends->pkgs[i];
++	       /* The package was uninstalled when we started, but another
++	          dep earlier in this loop may have depended on it and pulled
++	          it in, so check first. */
++	       if ((dep->state_status != SS_INSTALLED) && (dep->state_status != SS_UNPACKED)) {
++		    opkg_msg(DEBUG2,"Calling opkg_install_pkg.\n");
++		    err = opkg_install_pkg(dep, 0);
++		    /* mark this package as having been automatically installed to
++		     * satisfy a dependancy */
++		    dep->auto_installed = 1;
++		    if (err) {
++			 pkg_vec_free(depends);
++			 return err;
++		    }
++	       }
++	  }
++
+ 	  pkg_vec_free(depends);
+ 	  return 0;
+      }
+Index: trunk/libopkg/pkg_depends.c
+===================================================================
+--- trunk.orig/libopkg/pkg_depends.c	2010-12-22 16:04:43.000000000 +0000
++++ trunk/libopkg/pkg_depends.c	2011-12-15 15:58:41.838334788 +0000
+@@ -259,6 +259,88 @@
+      return unsatisfied->len;
+ }
+ 
++
++pkg_vec_t *
++pkg_hash_fetch_satisfied_dependencies(pkg_t * pkg)
++{
++     pkg_vec_t *satisfiers;
++     int i, j, k;
++     int count;
++     abstract_pkg_t * ab_pkg;
++
++     satisfiers = pkg_vec_alloc();
++
++     /*
++      * this is a setup to check for redundant/cyclic dependency checks,
++      * which are marked at the abstract_pkg level
++      */
++     if (!(ab_pkg = pkg->parent)) {
++	  opkg_msg(ERROR, "Internal error, with pkg %s.\n", pkg->name);
++	  return satisfiers;
++     }
++
++     count = pkg->pre_depends_count + pkg->depends_count + pkg->recommends_count + pkg->suggests_count;
++     if (!count)
++	  return satisfiers;
++
++     /* foreach dependency */
++     for (i = 0; i < count; i++) {
++	  compound_depend_t * compound_depend = &pkg->depends[i];
++	  depend_t ** possible_satisfiers = compound_depend->possibilities;;
++
++          if (compound_depend->type == RECOMMEND || compound_depend->type == SUGGEST)
++              continue;
++
++	  if (compound_depend->type == GREEDY_DEPEND) {
++	       /* foreach possible satisfier */
++	       for (j = 0; j < compound_depend->possibility_count; j++) {
++		    /* foreach provided_by, which includes the abstract_pkg itself */
++		    abstract_pkg_t *abpkg = possible_satisfiers[j]->pkg;
++		    abstract_pkg_vec_t *ab_provider_vec = abpkg->provided_by;
++		    int nposs = ab_provider_vec->len;
++		    abstract_pkg_t **ab_providers = ab_provider_vec->pkgs;
++		    int l;
++		    for (l = 0; l < nposs; l++) {
++			 pkg_vec_t *test_vec = ab_providers[l]->pkgs;
++			 /* if no depends on this one, try the first package that Provides this one */
++			 if (!test_vec){   /* no pkg_vec hooked up to the abstract_pkg!  (need another feed?) */
++			      continue;
++			 }
++
++			 /* cruise this possiblity's pkg_vec looking for an installed version */
++			 for (k = 0; k < test_vec->len; k++) {
++			      pkg_t *pkg_scout = test_vec->pkgs[k];
++			      /* not installed, and not already known about? */
++			      if (pkg_scout->state_want == SW_INSTALL && pkg_scout != pkg)
++      			          pkg_vec_insert(satisfiers, pkg_scout);
++			 }
++		    }
++	       }
++
++	       continue;
++	  }
++
++	  /* foreach possible satisfier, look for installed package  */
++	  for (j = 0; j < compound_depend->possibility_count; j++) {
++	       /* foreach provided_by, which includes the abstract_pkg itself */
++	       depend_t *dependence_to_satisfy = possible_satisfiers[j];
++	       abstract_pkg_t *satisfying_apkg = possible_satisfiers[j]->pkg;
++	       pkg_t *satisfying_pkg =
++		    pkg_hash_fetch_best_installation_candidate(satisfying_apkg,
++							       pkg_installed_and_constraint_satisfied,
++							       dependence_to_satisfy, 1);
++               /* Being that I can't test constraing in pkg_hash, I will test it here */
++	       if (satisfying_pkg != NULL && satisfying_pkg != pkg) {
++                  if (pkg_constraint_satisfied(satisfying_pkg, dependence_to_satisfy) && satisfying_pkg->state_want == SW_INSTALL)
++	              pkg_vec_insert(satisfiers, satisfying_pkg);
++               }
++
++	  }
++     }
++     return satisfiers;
++}
++
++
+ /*checking for conflicts !in replaces
+   If a packages conflicts with another but is also replacing it, I should not consider it a
+   really conflicts
+Index: trunk/libopkg/pkg_depends.h
+===================================================================
+--- trunk.orig/libopkg/pkg_depends.h	2010-12-22 16:04:43.000000000 +0000
++++ trunk/libopkg/pkg_depends.h	2011-12-15 15:58:41.838334788 +0000
+@@ -82,6 +82,7 @@
+ void buildDependedUponBy(pkg_t * pkg, abstract_pkg_t * ab_pkg);
+ int version_constraints_satisfied(depend_t * depends, pkg_t * pkg);
+ int pkg_hash_fetch_unsatisfied_dependencies(pkg_t * pkg, pkg_vec_t *depends, char *** unresolved);
++pkg_vec_t * pkg_hash_fetch_satisfied_dependencies(pkg_t * pkg);
+ pkg_vec_t * pkg_hash_fetch_conflicts(pkg_t * pkg);
+ int pkg_dependence_satisfiable(depend_t *depend);
+ int pkg_dependence_satisfied(depend_t *depend);

meta/recipes-devtools/opkg/opkg/offline_postinstall.patch new file +57 -0

new file mode 100644
index 0000000..b197f6b
@@ -0,0 +1,57 @@
+When we have an offline root and have specified force-postinstall, 
+attempt to run the postinstall but if it fails, just leave it in the
+status file as neeing to run. We can issue a NOTICE this is happened
+but supress errors. This means the OE class doesn't have to do any
+further post processing of the postinstalls itself.
+
+Upstream-Status: Pending
+
+RP 2011/12/15
+
+
+Index: trunk/libopkg/pkg.c
+===================================================================
+--- trunk.orig/libopkg/pkg.c	2011-12-15 15:58:39.000000000 +0000
++++ trunk/libopkg/pkg.c	2011-12-15 20:04:50.109992736 +0000
+@@ -1297,8 +1297,9 @@
+      free(cmd);
+ 
+      if (err) {
+-	  opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n", 
+-               pkg->name, script, err);
++          if (!conf->offline_root)
++	       opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n", 
++                    pkg->name, script, err);
+ 	  return err;
+      }
+ 
+Index: trunk/libopkg/opkg_cmd.c
+===================================================================
+--- trunk.orig/libopkg/opkg_cmd.c	2011-12-15 19:49:25.826014150 +0000
++++ trunk/libopkg/opkg_cmd.c	2011-12-15 19:50:52.346012148 +0000
+@@ -453,7 +453,8 @@
+ 		    pkg->state_flag &= ~SF_PREFER;
+ 		    opkg_state_changed++;
+ 	       } else {
+-		    err = -1;
++                    if (!conf->offline_root)
++		         err = -1;
+ 	       }
+ 	  }
+      }
+Index: trunk/libopkg/opkg_configure.c
+===================================================================
+--- trunk.orig/libopkg/opkg_configure.c	2011-12-15 19:50:11.586013081 +0000
++++ trunk/libopkg/opkg_configure.c	2011-12-15 19:52:15.082010347 +0000
+@@ -35,7 +35,10 @@
+ 
+     err = pkg_run_script(pkg, "postinst", "configure");
+     if (err) {
+-	opkg_msg(ERROR, "%s.postinst returned %d.\n", pkg->name, err);
++        if (!conf->offline_root)
++	     opkg_msg(ERROR, "%s.postinst returned %d.\n", pkg->name, err);
++        else
++	     opkg_msg(NOTICE, "%s.postinst returned %d, marking as unpacked only, configuration required on target.\n", pkg->name, err);
+ 	return err;
+     }
+

meta/recipes-devtools/opkg/opkg/offlineroot_varname.patch new file +20 -0

new file mode 100644
index 0000000..a67f389
@@ -0,0 +1,20 @@
+OE uses D as the offline install directory in its scripts, not PKG_ROOT.
+
+Upstream-Status: Inappropriate [OE specific usage]
+
+RP 2011/12/15
+
+Index: trunk/libopkg/pkg.c
+===================================================================
+--- trunk.orig/libopkg/pkg.c	2011-12-15 15:58:39.000000000 +0000
++++ trunk/libopkg/pkg.c	2011-12-15 20:04:50.109992736 +0000
+@@ -1280,7 +1280,7 @@
+ 
+      opkg_msg(INFO, "Running script %s.\n", path);
+ 
+-     setenv("PKG_ROOT",
++     setenv("D",
+ 	    pkg->dest ? pkg->dest->root_dir : conf->default_dest->root_dir, 1);
+ 
+      if (! file_exists(path)) {
+

meta/recipes-devtools/opkg/opkg_svn.bb +5 -2

index acb21f2..2645d52 100644
@@ -12,13 +12,16 @@ RREPLACES_${PN} = "opkg-nogpg"
 SRC_URI = "svn://opkg.googlecode.com/svn;module=trunk;proto=http \
            file://add_vercmp.patch \
            file://add_uname_support.patch \
+           file://fix_installorder.patch \
+           file://offline_postinstall.patch\
+           file://offlineroot_varname.patch \
 "
 
 S = "${WORKDIR}/trunk"
 
-SRCREV = "625"
+SRCREV = "633"
 PV = "0.1.8+svnr${SRCPV}"
-PR = "r4"
+PR = "r2"
 
 PACKAGES =+ "libopkg${PKGSUFFIX}-dev libopkg${PKGSUFFIX} update-alternatives-cworth${PKGSUFFIX}"

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Richard Purdie

author

2011-12-17 01:39 UTC #2 lore raw

Quoted 67 lines · Martin Jansa

Quoted 22 lines · Richard Purdie
There is a major issue with opkg images at the moment as preinst functions are not being executed before their dependencies are installed and this is leading to corruption of images containing avahi/dbus in particular.
There are various changes in upstream opkg in the last 8 revisions which make changes in this area but sadly these aren't enough to get things working for us. I've updated to the latest svn revision with this patch since it makes sense to pull in those changes first and then supplement them with the attached patches.
There is a full description of the patches in the patch headers but in summary they:
a) Ensure preinst functions execute with their dependencies installed. This is a pretty invasive change as it changes the package install ordering in general.
b) Ensure opkg sets $D, not $PKG_ROOT which we don't use
c) Change opkg to allow execution of postinstall functions which fail resulting in execution on the target device as rootfs_ipk.bbclass currently does manually.
Quoted 7 lines
The remaining changes interface this with the rest of the OE build infrastructure, adding in the option to tell opkg to run the preinst and postinst functions, ensure the correct environment is present for the postinst scripts and removing the now unneeded rootfs_ipk class code which opkg now does itself.
[YOCTO #1711]
Hi,
today I got image build failing with this and it seems like some kind of circular dependency or something.
In fsogsmd_git.bb we have:
PACKAGES =+ "${PN}-connman ${PN}-connman-dev ${PN}-connman-dbg" RDEPENDS_${PN} += "${PN}-connman"
and there is also fsogsmd-connman dependency on fsogsmd (because of shlibs), so it's really circular dependency between runtime packages and new opkg cannot deal with it.
Then in log.do_rootfs
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
and then this last 2 lines 1794/2 times
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing task-core-ssh-openssh (1.0-r0) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/armv5te/task-core-ssh-openssh_1.0-r0_armv5te.ipk.
...
and in the end:
ERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-lite-image/2.0-r20/temp/log.do_rootfs.20387 for further information) Collected errors:
* gz_close: Unzip process killed by signal 11.
* pkg_get_installed_files: Error extracting file list from /tmp/opkg-T7G08e/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk.
* opkg_install_cmd: Cannot install package task-shr-minimal-apps.
Reverting this patch and rebuilding opkg before running image build helps.

Quoted 7 lines

I'll try to upgrade only opkg without your patches first, but I guess it's because of fix_installorder.patch, can we teach it to break circular dependencies or should I fix it in metadata? It seem that longer cycles like
fsogsmd-config -> fsogsmd-module-modem-ti-calypso -> fsogsmd -> fsogsmd-config
does work.

This is likely as a result of the installorder patch :/. Sadly if we want the postinstalls to be installed in order we do need that patch.

The question is whether circular depends are something opkg should support or not? What's debian's behaviour in that regard?

Cheers,

Richard

Martin Jansa

2011-12-17 09:27 UTC #3 lore raw

Quoted 72 lines · Richard Purdie

Quoted 71 lines · Martin Jansa
Quoted 22 lines · Richard Purdie
There is a major issue with opkg images at the moment as preinst functions are not being executed before their dependencies are installed and this is leading to corruption of images containing avahi/dbus in particular.
There are various changes in upstream opkg in the last 8 revisions which make changes in this area but sadly these aren't enough to get things working for us. I've updated to the latest svn revision with this patch since it makes sense to pull in those changes first and then supplement them with the attached patches.
There is a full description of the patches in the patch headers but in summary they:
a) Ensure preinst functions execute with their dependencies installed. This is a pretty invasive change as it changes the package install ordering in general.
b) Ensure opkg sets $D, not $PKG_ROOT which we don't use
c) Change opkg to allow execution of postinstall functions which fail resulting in execution on the target device as rootfs_ipk.bbclass currently does manually.
Quoted 7 lines
The remaining changes interface this with the rest of the OE build infrastructure, adding in the option to tell opkg to run the preinst and postinst functions, ensure the correct environment is present for the postinst scripts and removing the now unneeded rootfs_ipk class code which opkg now does itself.
[YOCTO #1711]
Hi,
today I got image build failing with this and it seems like some kind of circular dependency or something.
In fsogsmd_git.bb we have:
PACKAGES =+ "${PN}-connman ${PN}-connman-dev ${PN}-connman-dbg" RDEPENDS_${PN} += "${PN}-connman"
and there is also fsogsmd-connman dependency on fsogsmd (because of shlibs), so it's really circular dependency between runtime packages and new opkg cannot deal with it.
Then in log.do_rootfs
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
and then this last 2 lines 1794/2 times
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing task-core-ssh-openssh (1.0-r0) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/armv5te/task-core-ssh-openssh_1.0-r0_armv5te.ipk.
...
and in the end:
ERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-lite-image/2.0-r20/temp/log.do_rootfs.20387 for further information) Collected errors:
* gz_close: Unzip process killed by signal 11.
* pkg_get_installed_files: Error extracting file list from /tmp/opkg-T7G08e/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk.
* opkg_install_cmd: Cannot install package task-shr-minimal-apps.
Reverting this patch and rebuilding opkg before running image build helps.
I'll try to upgrade only opkg without your patches first, but I guess it's because of fix_installorder.patch, can we teach it to break circular dependencies or should I fix it in metadata? It seem that longer cycles like

Quoted 6 lines

Quoted 3 lines
fsogsmd-config -> fsogsmd-module-modem-ti-calypso -> fsogsmd -> fsogsmd-config
does work.
This is likely as a result of the installorder patch :/. Sadly if we want the postinstalls to be installed in order we do need that patch.

I've tried to build image with SRCREV=633 and it built image fine then I tried to apply your patch but without installorder.patch to confirm that the issue with circular depending packages is really cause by that only and then try to fix installorder.patch to work even with such packages, but I got many postinst errors :(.

From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.

| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script returned status 1.
|  * opkg_configure: pam-plugin-unix.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-x.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-fc" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script returned status 1.
|  * opkg_configure: update-modules.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
|  * pkg_run_script: package "liberation-fonts" postinst script returned status 1.
|  * opkg_configure: liberation-fonts.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
|  * pkg_run_script: package "ppp" postinst script returned status 1.
|  * opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-common.postinst returned 127.
|  * pkg_run_script: package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127.
|  * pkg_run_script: package "ffalarms" postinst script returned status 127.
|  * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned status 1.
|  * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans-mono.postinst returned 127.
|  * pkg_run_script: package "matchbox-keyboard-im" postinst script returned status 1.
|  * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
|  * opkg_configure: hicolor-icon-theme.postinst returned 1.
|  * pkg_run_script: packaERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script returned status 1.
|  * opkg_configure: gtk-immodule-xim.postinst returned 1.
|  * pkg_run_script: package "ca-certificates" postinst script returned status 1.
|  * opkg_configure: ca-certificates.postinst returned 1.

NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite-image.bb, do_rootfs) failed with exit code ' 1'

Quoted 2 lines

The question is whether circular depends are something opkg should support or not? What's debian's behaviour in that regard?

Well, it did work before and from quick search it looks that such circular dependencies are quite common in our metadata. So I agree that this patch is really needed to fix dbus owner, but in case there is circular dependency we shouldn't be so strict about order of installs.

Regards,

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Richard Purdie

author

2011-12-17 10:29 UTC #4 lore raw

Quoted 133 lines · Martin Jansa

Quoted 72 lines · Richard Purdie
Quoted 71 lines · Martin Jansa
Quoted 22 lines · Richard Purdie
There is a major issue with opkg images at the moment as preinst functions are not being executed before their dependencies are installed and this is leading to corruption of images containing avahi/dbus in particular.
There are various changes in upstream opkg in the last 8 revisions which make changes in this area but sadly these aren't enough to get things working for us. I've updated to the latest svn revision with this patch since it makes sense to pull in those changes first and then supplement them with the attached patches.
There is a full description of the patches in the patch headers but in summary they:
a) Ensure preinst functions execute with their dependencies installed. This is a pretty invasive change as it changes the package install ordering in general.
b) Ensure opkg sets $D, not $PKG_ROOT which we don't use
c) Change opkg to allow execution of postinstall functions which fail resulting in execution on the target device as rootfs_ipk.bbclass currently does manually.
Quoted 7 lines
The remaining changes interface this with the rest of the OE build infrastructure, adding in the option to tell opkg to run the preinst and postinst functions, ensure the correct environment is present for the postinst scripts and removing the now unneeded rootfs_ipk class code which opkg now does itself.
[YOCTO #1711]
Hi,
today I got image build failing with this and it seems like some kind of circular dependency or something.
In fsogsmd_git.bb we have:
PACKAGES =+ "${PN}-connman ${PN}-connman-dev ${PN}-connman-dbg" RDEPENDS_${PN} += "${PN}-connman"
and there is also fsogsmd-connman dependency on fsogsmd (because of shlibs), so it's really circular dependency between runtime packages and new opkg cannot deal with it.
Then in log.do_rootfs
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
and then this last 2 lines 1794/2 times
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing task-core-ssh-openssh (1.0-r0) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/armv5te/task-core-ssh-openssh_1.0-r0_armv5te.ipk.
...
and in the end:
ERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-lite-image/2.0-r20/temp/log.do_rootfs.20387 for further information) Collected errors:
* gz_close: Unzip process killed by signal 11.
* pkg_get_installed_files: Error extracting file list from /tmp/opkg-T7G08e/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk.
* opkg_install_cmd: Cannot install package task-shr-minimal-apps.
Reverting this patch and rebuilding opkg before running image build helps.
I'll try to upgrade only opkg without your patches first, but I guess it's because of fix_installorder.patch, can we teach it to break circular dependencies or should I fix it in metadata? It seem that longer cycles like
Quoted 6 lines
Quoted 3 lines
fsogsmd-config -> fsogsmd-module-modem-ti-calypso -> fsogsmd -> fsogsmd-config
does work.
This is likely as a result of the installorder patch :/. Sadly if we want the postinstalls to be installed in order we do need that patch.
I've tried to build image with SRCREV=633 and it built image fine then I tried to apply your patch but without installorder.patch to confirm that the issue with circular depending packages is really cause by that only and then try to fix installorder.patch to work even with such packages, but I got many postinst errors :(.
From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.
| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script returned status 1.
|  * opkg_configure: pam-plugin-unix.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-x.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-fc" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script returned status 1.
|  * opkg_configure: update-modules.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
|  * pkg_run_script: package "liberation-fonts" postinst script returned status 1.
|  * opkg_configure: liberation-fonts.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
|  * pkg_run_script: package "ppp" postinst script returned status 1.
|  * opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-common.postinst returned 127.
|  * pkg_run_script: package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127.
|  * pkg_run_script: package "ffalarms" postinst script returned status 127.
|  * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned status 1.
|  * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans-mono.postinst returned 127.
|  * pkg_run_script: package "matchbox-keyboard-im" postinst script returned status 1.
|  * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
|  * opkg_configure: hicolor-icon-theme.postinst returned 1.
|  * pkg_run_script: packaERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script returned status 1.
|  * opkg_configure: gtk-immodule-xim.postinst returned 1.
|  * pkg_run_script: package "ca-certificates" postinst script returned status 1.
|  * opkg_configure: ca-certificates.postinst returned 1.

Quoted 3 lines

NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite-image.bb, do_rootfs) failed with exit code ' 1'

This looks like you don't have the offline_postinstall patch applied?

opkg revision 633 will not build correct metadata without the patches included.

Quoted 5 lines

Quoted 2 lines
The question is whether circular depends are something opkg should support or not? What's debian's behaviour in that regard?
Well, it did work before and from quick search it looks that such circular dependencies are quite common in our metadata.

Do you have some examples? I couldn't find any in OE-Core?

Quoted 2 lines

So I agree that this patch is really needed to fix dbus owner,
but in case there is circular dependency we shouldn't be so strict about order of installs.

So how you you handle A depends on B which depends on A and be strict about dependency order?

Cheers,

Richard

Martin Jansa

2011-12-17 10:41 UTC #5 lore raw

Quoted 138 lines · Richard Purdie

Quoted 133 lines · Martin Jansa
Quoted 72 lines · Richard Purdie
Quoted 71 lines · Martin Jansa
Quoted 22 lines · Richard Purdie
There is a major issue with opkg images at the moment as preinst functions are not being executed before their dependencies are installed and this is leading to corruption of images containing avahi/dbus in particular.
There are various changes in upstream opkg in the last 8 revisions which make changes in this area but sadly these aren't enough to get things working for us. I've updated to the latest svn revision with this patch since it makes sense to pull in those changes first and then supplement them with the attached patches.
There is a full description of the patches in the patch headers but in summary they:
a) Ensure preinst functions execute with their dependencies installed. This is a pretty invasive change as it changes the package install ordering in general.
b) Ensure opkg sets $D, not $PKG_ROOT which we don't use
c) Change opkg to allow execution of postinstall functions which fail resulting in execution on the target device as rootfs_ipk.bbclass currently does manually.
Quoted 7 lines
The remaining changes interface this with the rest of the OE build infrastructure, adding in the option to tell opkg to run the preinst and postinst functions, ensure the correct environment is present for the postinst scripts and removing the now unneeded rootfs_ipk class code which opkg now does itself.
[YOCTO #1711]
Hi,
today I got image build failing with this and it seems like some kind of circular dependency or something.
In fsogsmd_git.bb we have:
PACKAGES =+ "${PN}-connman ${PN}-connman-dev ${PN}-connman-dbg" RDEPENDS_${PN} += "${PN}-connman"
and there is also fsogsmd-connman dependency on fsogsmd (because of shlibs), so it's really circular dependency between runtime packages and new opkg cannot deal with it.
Then in log.do_rootfs
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/qemuarm/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk. Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
and then this last 2 lines 1794/2 times
Installing fsogsmd (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing fsogsmd-connman (1:0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7) to root...
Installing task-core-ssh-openssh (1.0-r0) to root...
Downloading file:/OE/shr-core/tmp-eglibc/deploy/ipk/armv5te/task-core-ssh-openssh_1.0-r0_armv5te.ipk.
...
and in the end:
ERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-lite-image/2.0-r20/temp/log.do_rootfs.20387 for further information) Collected errors:
* gz_close: Unzip process killed by signal 11.
* pkg_get_installed_files: Error extracting file list from /tmp/opkg-T7G08e/fsogsmd-connman_0.5.0+gitr20+96698077b6ccd5fc1222e0b2b9fc56d087c6c528-r6.7_qemuarm.ipk.
* opkg_install_cmd: Cannot install package task-shr-minimal-apps.
Reverting this patch and rebuilding opkg before running image build helps.
I'll try to upgrade only opkg without your patches first, but I guess it's because of fix_installorder.patch, can we teach it to break circular dependencies or should I fix it in metadata? It seem that longer cycles like
Quoted 6 lines
Quoted 3 lines
fsogsmd-config -> fsogsmd-module-modem-ti-calypso -> fsogsmd -> fsogsmd-config
does work.
This is likely as a result of the installorder patch :/. Sadly if we want the postinstalls to be installed in order we do need that patch.
I've tried to build image with SRCREV=633 and it built image fine then I tried to apply your patch but without installorder.patch to confirm that the issue with circular depending packages is really cause by that only and then try to fix installorder.patch to work even with such packages, but I got many postinst errors :(.
From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.
| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script returned status 1.
|  * opkg_configure: pam-plugin-unix.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-x.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-fc" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script returned status 1.
|  * opkg_configure: update-modules.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
|  * pkg_run_script: package "liberation-fonts" postinst script returned status 1.
|  * opkg_configure: liberation-fonts.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
|  * pkg_run_script: package "ppp" postinst script returned status 1.
|  * opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-common.postinst returned 127.
|  * pkg_run_script: package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127.
|  * pkg_run_script: package "ffalarms" postinst script returned status 127.
|  * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned status 1.
|  * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans-mono.postinst returned 127.
|  * pkg_run_script: package "matchbox-keyboard-im" postinst script returned status 1.
|  * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
|  * opkg_configure: hicolor-icon-theme.postinst returned 1.
|  * pkg_run_script: packaERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script returned status 1.
|  * opkg_configure: gtk-immodule-xim.postinst returned 1.
|  * pkg_run_script: package "ca-certificates" postinst script returned status 1.
|  * opkg_configure: ca-certificates.postinst returned 1.
Quoted 3 lines
NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite-image.bb, do_rootfs) failed with exit code ' 1'

Quoted 1 line

This looks like you don't have the offline_postinstall patch applied?

I have

Quoted 3 lines

opkg revision 633 will not build correct metadata without the patches included.

Only patch not included in my opkg build was the installorder one.

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
The question is whether circular depends are something opkg should support or not? What's debian's behaviour in that regard?
Well, it did work before and from quick search it looks that such circular dependencies are quite common in our metadata.
Do you have some examples? I couldn't find any in OE-Core?

I'll try.

Quoted 5 lines

Quoted 2 lines
So I agree that this patch is really needed to fix dbus owner,
but in case there is circular dependency we shouldn't be so strict about order of installs.
So how you you handle A depends on B which depends on A and be strict about dependency order?

The problem with dbus/base-passwd can be fixed by this patch, but for fsogsmd* modules the order is not so important, so I think that when there is circular dependency detected the order _shouldn't_ be so strict and maybe warning can be shown, but it shouldn't be fatal.

Quoted 9 lines

Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Richard Purdie

author

2011-12-17 11:59 UTC #6 lore raw

Quoted 60 lines · Martin Jansa

Quoted 59 lines · Richard Purdie

Quoted 57 lines · Martin Jansa

On Sat, Dec 17, 2011 at 01:32:28AM +0000, Richard Purdie wrote:
I've tried to build image with SRCREV=633 and it built image fine then I tried to apply your patch but without installorder.patch to confirm that the issue with circular depending packages is really cause by that only and then try to fix installorder.patch to work even with such packages, but I got many postinst errors :(.

From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.

| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script returned status 1.
|  * opkg_configure: pam-plugin-unix.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-x.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-fc" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script returned status 1.
|  * opkg_configure: update-modules.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
|  * pkg_run_script: package "liberation-fonts" postinst script returned status 1.
|  * opkg_configure: liberation-fonts.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
|  * pkg_run_script: package "ppp" postinst script returned status 1.
|  * opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-common.postinst returned 127.
|  * pkg_run_script: package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127.
|  * pkg_run_script: package "ffalarms" postinst script returned status 127.
|  * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned status 1.
|  * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans-mono.postinst returned 127.
|  * pkg_run_script: package "matchbox-keyboard-im" postinst script returned status 1.
|  * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
|  * opkg_configure: hicolor-icon-theme.postinst returned 1.
|  * pkg_run_script: packaERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script returned status 1.
|  * opkg_configure: gtk-immodule-xim.postinst returned 1.
|  * pkg_run_script: package "ca-certificates" postinst script returned status 1.
|  * opkg_configure: ca-certificates.postinst returned 1.

NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite-image.bb, do_rootfs) failed with exit code ' 1'

Quoted 3 lines

Quoted 1 line
This looks like you don't have the offline_postinstall patch applied?
I have

Please double check. That patch does things like:

libopkg/pkg.c +3 -2

Index: trunk/libopkg/pkg.c
===================================================================
@@ -1297,8 +1297,9 @@
      free(cmd);
 
      if (err) {
-	  opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n", 
-               pkg->name, script, err);
+          if (!conf->offline_root)
+	       opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n", 
+                    pkg->name, script, err);
 	  return err;
      }

and these are clearly showing up as ERRORs above. This means that:

a) offline_root isn't set (extremely unlikely for do_rootfs to work)
b) the patch isn't applied

Quoted 4 lines

Quoted 2 lines
opkg revision 633 will not build correct metadata without the patches included.
Only patch not included in my opkg build was the installorder one.

I have my doubts about this, sorry...

Quoted 13 lines

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
The question is whether circular depends are something opkg should support or not? What's debian's behaviour in that regard?
Well, it did work before and from quick search it looks that such circular dependencies are quite common in our metadata.
Do you have some examples? I couldn't find any in OE-Core?
I'll try.
Quoted 3 lines
Quoted 2 lines
So I agree that this patch is really needed to fix dbus owner,
but in case there is circular dependency we shouldn't be so strict about order of installs.

Quoted 7 lines

Quoted 2 lines
So how you you handle A depends on B which depends on A and be strict about dependency order?
The problem with dbus/base-passwd can be fixed by this patch, but for fsogsmd* modules the order is not so important, so I think that when there is circular dependency detected the order _shouldn't_ be so strict and maybe warning can be shown, but it shouldn't be fatal.

Looking at fsogsmd, that specific packages split doesn't really make sense. fsogsmd depends on fsogsmd-connman and fsogsmd-connman depends on fsogsmd. This means that both or neither can be installed but never either of them singly so the split is just a waste of space.

I agree we need to improve that patch to detect loops but I'm not sure a warning makes sense as we can't tell the difference between a case where we don't care and a case where the resulting image is corrupt...

Cheers,

Richard

Martin Jansa

2011-12-17 15:54 UTC #7 lore raw

Quoted 116 lines · Richard Purdie

Quoted 60 lines · Martin Jansa
Quoted 59 lines · Richard Purdie
Quoted 57 lines · Martin Jansa
On Sat, Dec 17, 2011 at 01:32:28AM +0000, Richard Purdie wrote:
I've tried to build image with SRCREV=633 and it built image fine then I tried to apply your patch but without installorder.patch to confirm that the issue with circular depending packages is really cause by that only and then try to fix installorder.patch to work even with such packages, but I got many postinst errors :(.
From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.
| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script returned status 1.
|  * opkg_configure: pam-plugin-unix.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-x.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-fc" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script returned status 1.
|  * opkg_configure: update-modules.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
|  * pkg_run_script: package "liberation-fonts" postinst script returned status 1.
|  * opkg_configure: liberation-fonts.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
|  * pkg_run_script: package "ppp" postinst script returned status 1.
|  * opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-common.postinst returned 127.
|  * pkg_run_script: package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127.
|  * pkg_run_script: package "ffalarms" postinst script returned status 127.
|  * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned status 1.
|  * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans-mono.postinst returned 127.
|  * pkg_run_script: package "matchbox-keyboard-im" postinst script returned status 1.
|  * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
|  * opkg_configure: hicolor-icon-theme.postinst returned 1.
|  * pkg_run_script: packaERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script returned status 1.
|  * opkg_configure: gtk-immodule-xim.postinst returned 1.
|  * pkg_run_script: package "ca-certificates" postinst script returned status 1.
|  * opkg_configure: ca-certificates.postinst returned 1.
NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite-image.bb, do_rootfs) failed with exit code ' 1'
Quoted 3 lines
Quoted 1 line
This looks like you don't have the offline_postinstall patch applied?
I have
Please double check. That patch does things like:
Index: trunk/libopkg/pkg.c
===================================================================
libopkg/pkg.c +3 -2
@@ -1297,8 +1297,9 @@
      free(cmd);
 
      if (err) {
-	  opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n", 
-               pkg->name, script, err);
+          if (!conf->offline_root)
+	       opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n", 
+                    pkg->name, script, err);
 	  return err;
      }
 
and these are clearly showing up as ERRORs above. This means that:
a) offline_root isn't set (extremely unlikely for do_rootfs to work)
b) the patch isn't applied
Quoted 4 lines
Quoted 2 lines
opkg revision 633 will not build correct metadata without the patches included.
Only patch not included in my opkg build was the installorder one.
I have my doubts about this, sorry...
Quoted 13 lines
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
The question is whether circular depends are something opkg should support or not? What's debian's behaviour in that regard?
Well, it did work before and from quick search it looks that such circular dependencies are quite common in our metadata.
Do you have some examples? I couldn't find any in OE-Core?
I'll try.
Quoted 3 lines
Quoted 2 lines
So I agree that this patch is really needed to fix dbus owner,
but in case there is circular dependency we shouldn't be so strict about order of installs.
Quoted 7 lines
Quoted 2 lines
So how you you handle A depends on B which depends on A and be strict about dependency order?
The problem with dbus/base-passwd can be fixed by this patch, but for fsogsmd* modules the order is not so important, so I think that when there is circular dependency detected the order _shouldn't_ be so strict and maybe warning can be shown, but it shouldn't be fatal.

Quoted 8 lines

Looking at fsogsmd, that specific packages split doesn't really make sense. fsogsmd depends on fsogsmd-connman and fsogsmd-connman depends on fsogsmd. This means that both or neither can be installed but never either of them singly so the split is just a waste of space.
I agree we need to improve that patch to detect loops but I'm not sure a warning makes sense as we can't tell the difference between a case where we don't care and a case where the resulting image is corrupt...

You're right, it doesn't make much sense in this case (maybe fsogsmd-connman wasn't linked to libfsogsmd before so it didn't had circular dependency before), but for example fsogsmd-config is machine specific and pulls only right set of modules for each device. So it cannot be merged together as easy as this.

I'm changing RDEPENDS to RRECOMMENDS to break this hard dependency and build image.

Cheers,

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Martin Jansa

2011-12-18 11:07 UTC #8 lore raw

In reply to Richard Purdie

Quoted 88 lines · Richard Purdie

Quoted 60 lines · Martin Jansa

Quoted 59 lines · Richard Purdie

Quoted 57 lines · Martin Jansa

From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.

| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script returned status 1.
|  * opkg_configure: pam-plugin-unix.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-x.postinst returned 1.
|  * pkg_run_script: package "pango-module-basic-fc" postinst script returned status 1.
|  * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script returned status 1.
|  * opkg_configure: update-modules.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
|  * pkg_run_script: package "liberation-fonts" postinst script returned status 1.
|  * opkg_configure: liberation-fonts.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script returned status 1.
|  * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.
|  * pkg_run_script: package "ppp" postinst script returned status 1.
|  * opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-common.postinst returned 127.
|  * pkg_run_script: package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127.
|  * pkg_run_script: package "ffalarms" postinst script returned status 127.
|  * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned status 1.
|  * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans-mono.postinst returned 127.
|  * pkg_run_script: package "matchbox-keyboard-im" postinst script returned status 1.
|  * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
|  * opkg_configure: hicolor-icon-theme.postinst returned 1.
|  * pkg_run_script: packaERROR: Function 'do_rootfs' failed (see /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script returned status 1.
|  * opkg_configure: gtk-immodule-xim.postinst returned 1.
|  * pkg_run_script: package "ca-certificates" postinst script returned status 1.
|  * opkg_configure: ca-certificates.postinst returned 1.

NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite-image.bb, do_rootfs) failed with exit code ' 1'

Quoted 3 lines

Quoted 1 line
This looks like you don't have the offline_postinstall patch applied?
I have

Please double check. That patch does things like:

Index: trunk/libopkg/pkg.c
===================================================================

libopkg/pkg.c +3 -2

@@ -1297,8 +1297,9 @@
      free(cmd);
 
      if (err) {
-	  opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n", 
-               pkg->name, script, err);
+          if (!conf->offline_root)
+	       opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n", 
+                    pkg->name, script, err);
 	  return err;
      }

and these are clearly showing up as ERRORs above. This means that:

a) offline_root isn't set (extremely unlikely for do_rootfs to work)
b) the patch isn't applied

Quoted 6 lines

Quoted 4 lines
Quoted 2 lines
opkg revision 633 will not build correct metadata without the patches included.
Only patch not included in my opkg build was the installorder one.
I have my doubts about this, sorry...

With runtime circular dependencies broken by RRECOMMENDS I managed to build an image, but there is problem in target opkg

$D is not empty anymore (it's set to /), so all postinst scripts are executing the variant for do_rootfs not for target, e.g.

Configuring opkg.
//var/lib/opkg/info/opkg.postinst: line 3: install: command not found
update-alternatives: Linking //usr/bin/opkg to /usr/bin/opkg-cl
Configuring kernel-module-fat.
//var/lib/opkg/info/kernel-module-fat.postinst: line 3: arm-oe-linux-gnueabi-depmod: command not found

Quoted 41 lines

Quoted 14 lines
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
The question is whether circular depends are something opkg should support or not? What's debian's behaviour in that regard?
Well, it did work before and from quick search it looks that such circular dependencies are quite common in our metadata.
Do you have some examples? I couldn't find any in OE-Core?
I'll try.
Quoted 3 lines
Quoted 2 lines
So I agree that this patch is really needed to fix dbus owner,
but in case there is circular dependency we shouldn't be so strict about order of installs.
Quoted 7 lines
Quoted 2 lines
So how you you handle A depends on B which depends on A and be strict about dependency order?
The problem with dbus/base-passwd can be fixed by this patch, but for fsogsmd* modules the order is not so important, so I think that when there is circular dependency detected the order _shouldn't_ be so strict and maybe warning can be shown, but it shouldn't be fatal.
Looking at fsogsmd, that specific packages split doesn't really make sense. fsogsmd depends on fsogsmd-connman and fsogsmd-connman depends on fsogsmd. This means that both or neither can be installed but never either of them singly so the split is just a waste of space.
I agree we need to improve that patch to detect loops but I'm not sure a warning makes sense as we can't tell the difference between a case where we don't care and a case where the resulting image is corrupt...
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Andreas Müller

2011-12-18 11:51 UTC #9 lore raw

Quoted 122 lines · Martin Jansa

Quoted 108 lines · Richard Purdie
Quoted 71 lines · Martin Jansa
Quoted 70 lines · Richard Purdie
Quoted 69 lines · Martin Jansa
On Sat, Dec 17, 2011 at 01:32:28AM +0000, Richard Purdie wrote:
I've tried to build image with SRCREV=633 and it built image fine then I tried to apply your patch but without installorder.patch to confirm that the issue with circular depending packages is really cause by that only and then try to fix installorder.patch to work even with such packages, but I got many postinst errors :(.
From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.
| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script
|  returned status 1. * opkg_configure: pam-plugin-unix.postinst
|  returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script
|  returned status 1. * opkg_configure:
|  pango-module-basic-x.postinst returned 1. * pkg_run_script:
|  package "pango-module-basic-fc" postinst script returned status
|  1. * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script
|  returned status 1. * opkg_configure: update-modules.postinst
|  returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst
|  script returned status 1. * opkg_configure:
|  gdk-pixbuf-loader-png.postinst returned 1. * pkg_run_script:
|  package "gdk-pixbuf-loader-jpeg" postinst script returned
|  status 1. * opkg_configure: gdk-pixbuf-loader-jpeg.postinst
|  returned 1. * pkg_run_script: package "liberation-fonts"
|  postinst script returned status 1. * opkg_configure:
|  liberation-fonts.postinst returned 1. * pkg_run_script: package
|  "gdk-pixbuf-loader-xpm" postinst script returned status 1. *
|  opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1. *
|  pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
|  returned status 1. * opkg_configure:
|  gdk-pixbuf-loader-gif.postinst returned 1. * pkg_run_script:
|  package "ppp" postinst script returned status 1. *
|  opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script
|  returned status 127. * opkg_configure:
|  ttf-dejavu-common.postinst returned 127. * pkg_run_script:
|  package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127. *
|  pkg_run_script: package "ffalarms" postinst script returned
|  status 127. * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned
|  status 1. * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script
|  returned status 127. * opkg_configure:
|  ttf-dejavu-sans-mono.postinst returned 127. * pkg_run_script:
|  package "matchbox-keyboard-im" postinst script returned status
|  1. * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script
|  returned status 1. * opkg_configure:
|  hicolor-icon-theme.postinst returned 1. * pkg_run_script:
|  packaERROR: Function 'do_rootfs' failed (see
|  /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
| 
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script
|  returned status 1. * opkg_configure: gtk-immodule-xim.postinst
|  returned 1. * pkg_run_script: package "ca-certificates"
|  postinst script returned status 1. * opkg_configure:
|  ca-certificates.postinst returned 1.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite -image.bb, do_rootfs) failed with exit code ' 1'
This looks like you don't have the offline_postinstall patch applied?
I have
Please double check. That patch does things like:
Index: trunk/libopkg/pkg.c
===================================================================
libopkg/pkg.c +2 -2
@@ -1297,8 +1297,9 @@
 
      free(cmd);
 
      if (err) {
 
-	  opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n",
-               pkg->name, script, err);
+          if (!conf->offline_root)
+	       opkg_msg(ERROR, "package \"%s\" %s script returned status
 %d.\n", +                    pkg->name, script, err);
 
 	  return err;
 
      }
and these are clearly showing up as ERRORs above. This means that:
a) offline_root isn't set (extremely unlikely for do_rootfs to work)
b) the patch isn't applied
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
opkg revision 633 will not build correct metadata without the patches included.
Only patch not included in my opkg build was the installorder one.
I have my doubts about this, sorry...
With runtime circular dependencies broken by RRECOMMENDS I managed to build an image, but there is problem in target opkg
$D is not empty anymore (it's set to /), so all postinst scripts are executing the variant for do_rootfs not for target, e.g.

Quoted 7 lines

Configuring opkg.
//var/lib/opkg/info/opkg.postinst: line 3: install: command not found
update-alternatives: Linking //usr/bin/opkg to /usr/bin/opkg-cl Configuring kernel-module-fat. //var/lib/opkg/info/kernel-module-fat.postinst: line 3:
arm-oe-linux-gnueabi-depmod: command not found

Apart from circular dependencies my experiences with this patch is:

1. dbus dir ownership: Most ownerships are correct now. Only /var/run/dbus is still root:root ( at angstrom with custom fs-perms ).

2. First boot is VERY fast now. Not that I have a problem with being fast - but I see many lines like
| S98configure[77]: * pkg_run_script: package "update-modules" postinst script returned status 1.
| S98configure[77]: * opkg_configure: update-modules.postinst returned 1. | S98configure[77]: * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
| S98configure[77]: * opkg_configure: hicolor-icon-theme.postinst returned 1. | S98configure[77]: * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
| S98configure[77]: * opkg_configure: pango-module-basic-x.postinst returned 1. Many (all?) of these packages do not extend postinst.

3. xfce gui I usually use is far from working (only mouse pointer that's it)

Andreas

Martin Jansa

2011-12-18 12:16 UTC #10 lore raw

Quoted 130 lines · Andreas Müller

Quoted 122 lines · Martin Jansa
Quoted 108 lines · Richard Purdie
Quoted 71 lines · Martin Jansa
Quoted 70 lines · Richard Purdie
Quoted 69 lines · Martin Jansa
On Sat, Dec 17, 2011 at 01:32:28AM +0000, Richard Purdie wrote:
I've tried to build image with SRCREV=633 and it built image fine then I tried to apply your patch but without installorder.patch to confirm that the issue with circular depending packages is really cause by that only and then try to fix installorder.patch to work even with such packages, but I got many postinst errors :(.
From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.
| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script
|  returned status 1. * opkg_configure: pam-plugin-unix.postinst
|  returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script
|  returned status 1. * opkg_configure:
|  pango-module-basic-x.postinst returned 1. * pkg_run_script:
|  package "pango-module-basic-fc" postinst script returned status
|  1. * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script
|  returned status 1. * opkg_configure: update-modules.postinst
|  returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst
|  script returned status 1. * opkg_configure:
|  gdk-pixbuf-loader-png.postinst returned 1. * pkg_run_script:
|  package "gdk-pixbuf-loader-jpeg" postinst script returned
|  status 1. * opkg_configure: gdk-pixbuf-loader-jpeg.postinst
|  returned 1. * pkg_run_script: package "liberation-fonts"
|  postinst script returned status 1. * opkg_configure:
|  liberation-fonts.postinst returned 1. * pkg_run_script: package
|  "gdk-pixbuf-loader-xpm" postinst script returned status 1. *
|  opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1. *
|  pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
|  returned status 1. * opkg_configure:
|  gdk-pixbuf-loader-gif.postinst returned 1. * pkg_run_script:
|  package "ppp" postinst script returned status 1. *
|  opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script
|  returned status 127. * opkg_configure:
|  ttf-dejavu-common.postinst returned 127. * pkg_run_script:
|  package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127. *
|  pkg_run_script: package "ffalarms" postinst script returned
|  status 127. * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned
|  status 1. * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script
|  returned status 127. * opkg_configure:
|  ttf-dejavu-sans-mono.postinst returned 127. * pkg_run_script:
|  package "matchbox-keyboard-im" postinst script returned status
|  1. * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script
|  returned status 1. * opkg_configure:
|  hicolor-icon-theme.postinst returned 1. * pkg_run_script:
|  packaERROR: Function 'do_rootfs' failed (see
|  /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
| 
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script
|  returned status 1. * opkg_configure: gtk-immodule-xim.postinst
|  returned 1. * pkg_run_script: package "ca-certificates"
|  postinst script returned status 1. * opkg_configure:
|  ca-certificates.postinst returned 1.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite -image.bb, do_rootfs) failed with exit code ' 1'
This looks like you don't have the offline_postinstall patch applied?
I have
Please double check. That patch does things like:
Index: trunk/libopkg/pkg.c
===================================================================
libopkg/pkg.c +2 -2
@@ -1297,8 +1297,9 @@
 
      free(cmd);
 
      if (err) {
 
-	  opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n",
-               pkg->name, script, err);
+          if (!conf->offline_root)
+	       opkg_msg(ERROR, "package \"%s\" %s script returned status
 %d.\n", +                    pkg->name, script, err);
 
 	  return err;
 
      }
and these are clearly showing up as ERRORs above. This means that:
a) offline_root isn't set (extremely unlikely for do_rootfs to work)
b) the patch isn't applied
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
opkg revision 633 will not build correct metadata without the patches included.
Only patch not included in my opkg build was the installorder one.
I have my doubts about this, sorry...
With runtime circular dependencies broken by RRECOMMENDS I managed to build an image, but there is problem in target opkg
$D is not empty anymore (it's set to /), so all postinst scripts are executing the variant for do_rootfs not for target, e.g.
Quoted 7 lines
Configuring opkg.
//var/lib/opkg/info/opkg.postinst: line 3: install: command not found
update-alternatives: Linking //usr/bin/opkg to /usr/bin/opkg-cl Configuring kernel-module-fat. //var/lib/opkg/info/kernel-module-fat.postinst: line 3:
arm-oe-linux-gnueabi-depmod: command not found

Quoted 4 lines

Apart from circular dependencies my experiences with this patch is:
1. dbus dir ownership: Most ownerships are correct now. Only /var/run/dbus is still root:root ( at angstrom with custom fs-perms ).

after rebuilding dbus I even got some images with messagebus completely missing in packaged /etc/group (and the helper owned by sshd or somethig)

Quoted 4 lines

2. First boot is VERY fast now. Not that I have a problem with being fast - but I see many lines like
| S98configure[77]: * pkg_run_script: package "update-modules" postinst script returned status 1.

Quoted 8 lines

| S98configure[77]: * opkg_configure: update-modules.postinst returned 1. | S98configure[77]: * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
| S98configure[77]: * opkg_configure: hicolor-icon-theme.postinst returned 1. | S98configure[77]: * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
| S98configure[77]: * opkg_configure: pango-module-basic-x.postinst returned 1. Many (all?) of these packages do not extend postinst.

this is probably cause by D=/ on target.. in contrib/jansa/test there is untested patch for this, but I wont be available until tomorrow to report if it works.

Quoted 10 lines

3. xfce gui I usually use is far from working (only mouse pointer that's it)
Andreas
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Richard Purdie

author

2011-12-19 00:06 UTC #11 lore raw

In reply to Andreas Müller

Quoted 130 lines · Andreas Müller

Quoted 122 lines · Martin Jansa
Quoted 108 lines · Richard Purdie
Quoted 71 lines · Martin Jansa
Quoted 70 lines · Richard Purdie
Quoted 69 lines · Martin Jansa
On Sat, Dec 17, 2011 at 01:32:28AM +0000, Richard Purdie wrote:
I've tried to build image with SRCREV=633 and it built image fine then I tried to apply your patch but without installorder.patch to confirm that the issue with circular depending packages is really cause by that only and then try to fix installorder.patch to work even with such packages, but I got many postinst errors :(.
From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.
| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script
|  returned status 1. * opkg_configure: pam-plugin-unix.postinst
|  returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script
|  returned status 1. * opkg_configure:
|  pango-module-basic-x.postinst returned 1. * pkg_run_script:
|  package "pango-module-basic-fc" postinst script returned status
|  1. * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script
|  returned status 1. * opkg_configure: update-modules.postinst
|  returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst
|  script returned status 1. * opkg_configure:
|  gdk-pixbuf-loader-png.postinst returned 1. * pkg_run_script:
|  package "gdk-pixbuf-loader-jpeg" postinst script returned
|  status 1. * opkg_configure: gdk-pixbuf-loader-jpeg.postinst
|  returned 1. * pkg_run_script: package "liberation-fonts"
|  postinst script returned status 1. * opkg_configure:
|  liberation-fonts.postinst returned 1. * pkg_run_script: package
|  "gdk-pixbuf-loader-xpm" postinst script returned status 1. *
|  opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1. *
|  pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
|  returned status 1. * opkg_configure:
|  gdk-pixbuf-loader-gif.postinst returned 1. * pkg_run_script:
|  package "ppp" postinst script returned status 1. *
|  opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script
|  returned status 127. * opkg_configure:
|  ttf-dejavu-common.postinst returned 127. * pkg_run_script:
|  package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127. *
|  pkg_run_script: package "ffalarms" postinst script returned
|  status 127. * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned
|  status 1. * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script
|  returned status 127. * opkg_configure:
|  ttf-dejavu-sans-mono.postinst returned 127. * pkg_run_script:
|  package "matchbox-keyboard-im" postinst script returned status
|  1. * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script
|  returned status 1. * opkg_configure:
|  hicolor-icon-theme.postinst returned 1. * pkg_run_script:
|  packaERROR: Function 'do_rootfs' failed (see
|  /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
| 
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script
|  returned status 1. * opkg_configure: gtk-immodule-xim.postinst
|  returned 1. * pkg_run_script: package "ca-certificates"
|  postinst script returned status 1. * opkg_configure:
|  ca-certificates.postinst returned 1.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite -image.bb, do_rootfs) failed with exit code ' 1'
This looks like you don't have the offline_postinstall patch applied?
I have
Please double check. That patch does things like:
Index: trunk/libopkg/pkg.c
===================================================================
libopkg/pkg.c +2 -2
@@ -1297,8 +1297,9 @@
 
      free(cmd);
 
      if (err) {
 
-	  opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n",
-               pkg->name, script, err);
+          if (!conf->offline_root)
+	       opkg_msg(ERROR, "package \"%s\" %s script returned status
 %d.\n", +                    pkg->name, script, err);
 
 	  return err;
 
      }
and these are clearly showing up as ERRORs above. This means that:
a) offline_root isn't set (extremely unlikely for do_rootfs to work)
b) the patch isn't applied
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
opkg revision 633 will not build correct metadata without the patches included.
Only patch not included in my opkg build was the installorder one.
I have my doubts about this, sorry...
With runtime circular dependencies broken by RRECOMMENDS I managed to build an image, but there is problem in target opkg
$D is not empty anymore (it's set to /), so all postinst scripts are executing the variant for do_rootfs not for target, e.g.
Quoted 7 lines
Configuring opkg.
//var/lib/opkg/info/opkg.postinst: line 3: install: command not found
update-alternatives: Linking //usr/bin/opkg to /usr/bin/opkg-cl Configuring kernel-module-fat. //var/lib/opkg/info/kernel-module-fat.postinst: line 3:
arm-oe-linux-gnueabi-depmod: command not found

Quoted 4 lines

Apart from circular dependencies my experiences with this patch is:
1. dbus dir ownership: Most ownerships are correct now. Only /var/run/dbus is still root:root ( at angstrom with custom fs-perms ).

I think the volatile handling is different in angstrom so I'm not sure quite what is at fault here...

Quoted 13 lines

2. First boot is VERY fast now. Not that I have a problem with being fast - but I see many lines like
| S98configure[77]: * pkg_run_script: package "update-modules" postinst script returned status 1.
| S98configure[77]: * opkg_configure: update-modules.postinst returned 1. | S98configure[77]: * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
| S98configure[77]: * opkg_configure: hicolor-icon-theme.postinst returned 1. | S98configure[77]: * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
| S98configure[77]: * opkg_configure: pango-module-basic-x.postinst returned 1. Many (all?) of these packages do not extend postinst.

Quoted 1 line

3. xfce gui I usually use is far from working (only mouse pointer that's it)

I'm pretty sure these last two are the on device postinstalls not working as Martin mentions. We should just remove the offlineroot_varname patch as the easiest fix. I did this in the hope we could kill off some of the variables in the bbclass files but it doesn't look like such a good idea now :/. I'll remove that patch is nobody objects.

Cheers,

Richard

Martin Jansa

2011-12-19 06:01 UTC #12 lore raw

Quoted 152 lines · Richard Purdie

Quoted 130 lines · Andreas Müller
Quoted 122 lines · Martin Jansa
Quoted 108 lines · Richard Purdie
Quoted 71 lines · Martin Jansa
Quoted 70 lines · Richard Purdie
Quoted 69 lines · Martin Jansa
On Sat, Dec 17, 2011 at 01:32:28AM +0000, Richard Purdie wrote:
I've tried to build image with SRCREV=633 and it built image fine then I tried to apply your patch but without installorder.patch to confirm that the issue with circular depending packages is really cause by that only and then try to fix installorder.patch to work even with such packages, but I got many postinst errors :(.
From your description I understood that postinst execution should be almost the same only more logic is moved from rootfs_ipk.bbclass to opkg itself.
| Collected errors:
|  * pkg_run_script: package "pam-plugin-unix" postinst script
|  returned status 1. * opkg_configure: pam-plugin-unix.postinst
|  returned 1.
|  * pkg_run_script: package "pango-module-basic-x" postinst script
|  returned status 1. * opkg_configure:
|  pango-module-basic-x.postinst returned 1. * pkg_run_script:
|  package "pango-module-basic-fc" postinst script returned status
|  1. * opkg_configure: pango-module-basic-fc.postinst returned 1.
|  * pkg_run_script: package "update-modules" postinst script
|  returned status 1. * opkg_configure: update-modules.postinst
|  returned 1.
|  * pkg_run_script: package "gdk-pixbuf-loader-png" postinst
|  script returned status 1. * opkg_configure:
|  gdk-pixbuf-loader-png.postinst returned 1. * pkg_run_script:
|  package "gdk-pixbuf-loader-jpeg" postinst script returned
|  status 1. * opkg_configure: gdk-pixbuf-loader-jpeg.postinst
|  returned 1. * pkg_run_script: package "liberation-fonts"
|  postinst script returned status 1. * opkg_configure:
|  liberation-fonts.postinst returned 1. * pkg_run_script: package
|  "gdk-pixbuf-loader-xpm" postinst script returned status 1. *
|  opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1. *
|  pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
|  returned status 1. * opkg_configure:
|  gdk-pixbuf-loader-gif.postinst returned 1. * pkg_run_script:
|  package "ppp" postinst script returned status 1. *
|  opkg_configure: ppp.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-common" postinst script
|  returned status 127. * opkg_configure:
|  ttf-dejavu-common.postinst returned 127. * pkg_run_script:
|  package "ttf-dejavu-sans" postinst script returned status 127.
|  * opkg_configure: ttf-dejavu-sans.postinst returned 127. *
|  pkg_run_script: package "ffalarms" postinst script returned
|  status 127. * opkg_configure: ffalarms.postinst returned 127.
|  * pkg_run_script: package "rsyslog" postinst script returned
|  status 1. * opkg_configure: rsyslog.postinst returned 1.
|  * pkg_run_script: package "ttf-dejavu-sans-mono" postinst script
|  returned status 127. * opkg_configure:
|  ttf-dejavu-sans-mono.postinst returned 127. * pkg_run_script:
|  package "matchbox-keyboard-im" postinst script returned status
|  1. * opkg_configure: matchbox-keyboard-im.postinst returned 1.
|  * pkg_run_script: package "hicolor-icon-theme" postinst script
|  returned status 1. * opkg_configure:
|  hicolor-icon-theme.postinst returned 1. * pkg_run_script:
|  packaERROR: Function 'do_rootfs' failed (see
|  /OE/shr-core/tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-l
ite-image/2.0-r20/temp/log.do_rootfs.10063 for further information)
| ge "ttf-liberation-mono" postinst script returned status 127.
| 
|  * opkg_configure: ttf-liberation-mono.postinst returned 127.
|  * pkg_run_script: package "gtk-immodule-xim" postinst script
|  returned status 1. * opkg_configure: gtk-immodule-xim.postinst
|  returned 1. * pkg_run_script: package "ca-certificates"
|  postinst script returned status 1. * opkg_configure:
|  ca-certificates.postinst returned 1.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
NOTE: package shr-lite-image-2.0-r20: task do_rootfs: Failed
ERROR: Task 9 (/OE/shr-core/meta-smartphone/meta-shr/recipes-shr/images/shr-lite -image.bb, do_rootfs) failed with exit code ' 1'
This looks like you don't have the offline_postinstall patch applied?
I have
Please double check. That patch does things like:
Index: trunk/libopkg/pkg.c
===================================================================
libopkg/pkg.c +2 -2
@@ -1297,8 +1297,9 @@
 
      free(cmd);
 
      if (err) {
 
-	  opkg_msg(ERROR, "package \"%s\" %s script returned status %d.\n",
-               pkg->name, script, err);
+          if (!conf->offline_root)
+	       opkg_msg(ERROR, "package \"%s\" %s script returned status
 %d.\n", +                    pkg->name, script, err);
 
 	  return err;
 
      }
and these are clearly showing up as ERRORs above. This means that:
a) offline_root isn't set (extremely unlikely for do_rootfs to work)
b) the patch isn't applied
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
opkg revision 633 will not build correct metadata without the patches included.
Only patch not included in my opkg build was the installorder one.
I have my doubts about this, sorry...
With runtime circular dependencies broken by RRECOMMENDS I managed to build an image, but there is problem in target opkg
$D is not empty anymore (it's set to /), so all postinst scripts are executing the variant for do_rootfs not for target, e.g.
Quoted 7 lines
Configuring opkg.
//var/lib/opkg/info/opkg.postinst: line 3: install: command not found
update-alternatives: Linking //usr/bin/opkg to /usr/bin/opkg-cl Configuring kernel-module-fat. //var/lib/opkg/info/kernel-module-fat.postinst: line 3:
arm-oe-linux-gnueabi-depmod: command not found
Quoted 4 lines
Apart from circular dependencies my experiences with this patch is:
1. dbus dir ownership: Most ownerships are correct now. Only /var/run/dbus is still root:root ( at angstrom with custom fs-perms ).
I think the volatile handling is different in angstrom so I'm not sure quite what is at fault here...
Quoted 13 lines
2. First boot is VERY fast now. Not that I have a problem with being fast - but I see many lines like
| S98configure[77]: * pkg_run_script: package "update-modules" postinst script returned status 1.
| S98configure[77]: * opkg_configure: update-modules.postinst returned 1. | S98configure[77]: * pkg_run_script: package "hicolor-icon-theme" postinst script returned status 1.
| S98configure[77]: * opkg_configure: hicolor-icon-theme.postinst returned 1. | S98configure[77]: * pkg_run_script: package "pango-module-basic-x" postinst script returned status 1.
| S98configure[77]: * opkg_configure: pango-module-basic-x.postinst returned 1. Many (all?) of these packages do not extend postinst.

Quoted 8 lines

Quoted 1 line
3. xfce gui I usually use is far from working (only mouse pointer that's it)
I'm pretty sure these last two are the on device postinstalls not working as Martin mentions. We should just remove the offlineroot_varname patch as the easiest fix. I did this in the hope we could kill off some of the variables in the bbclass files but it doesn't look like such a good idea now :/. I'll remove that patch is nobody objects.

What about setting D only for offline-root case and keeping PKG_ROOT as it was (I'll rebase my patch on top of the one fixing circular dependencies and send it after another image test).

Regards,

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Martin Jansa

2011-12-19 08:11 UTC #13 lore raw

PATCH 1/1 opkg: add patch to make sure that D is empty when executing postinst scripts on target

Signed-off-by Martin Jansa <[email protected]>

---
 .../opkg/opkg/offlineroot_varname.patch            |   33 +++++++++++++++-----
 meta/recipes-devtools/opkg/opkg_svn.bb             |    4 +-
 2 files changed, 27 insertions(+), 10 deletions(-)

meta/recipes-devtools/opkg/opkg/offlineroot_varname.patch +25 -8

index a67f389..73600e3 100644
@@ -1,20 +1,37 @@
 OE uses D as the offline install directory in its scripts, not PKG_ROOT.
+D is expected to be empty on when offline_root is not used.
 
 Upstream-Status: Inappropriate [OE specific usage]
 
 RP 2011/12/15
 
-Index: trunk/libopkg/pkg.c
-===================================================================
---- trunk.orig/libopkg/pkg.c	2011-12-15 15:58:39.000000000 +0000
-+++ trunk/libopkg/pkg.c	2011-12-15 20:04:50.109992736 +0000
-@@ -1280,7 +1280,7 @@
+Signed-off-by: Martin Jansa <[email protected]>
+
+diff --git a/libopkg/pkg.c b/libopkg/pkg.c
+index 6ccbde2..7d16f84 100644
+--- a/libopkg/pkg.c
++++ b/libopkg/pkg.c
+@@ -1250,6 +1250,7 @@ pkg_run_script(pkg_t *pkg, const char *script, const char *args)
+      int err;
+      char *path;
+      char *cmd;
++     char *pkg_root;
+ 
+      if (conf->noaction)
+ 	     return 0;
+@@ -1280,8 +1281,13 @@ pkg_run_script(pkg_t *pkg, const char *script, const char *args)
  
       opkg_msg(INFO, "Running script %s.\n", path);
  
 -     setenv("PKG_ROOT",
-+     setenv("D",
- 	    pkg->dest ? pkg->dest->root_dir : conf->default_dest->root_dir, 1);
+-	    pkg->dest ? pkg->dest->root_dir : conf->default_dest->root_dir, 1);
++     pkg_root=pkg->dest ? pkg->dest->root_dir : conf->default_dest->root_dir;
++     setenv("PKG_ROOT", pkg_root, 1);
++     if (conf->offline_root) {
++       setenv("D", pkg_root, 1);
++     } else {
++       setenv("D", "", 1);
++     }
  
       if (! file_exists(path)) {
-
+ 	  free(path);

meta/recipes-devtools/opkg/opkg_svn.bb +2 -2

index dbdfc7e..065a2cb 100644
@@ -13,7 +13,7 @@ SRC_URI = "svn://opkg.googlecode.com/svn;module=trunk;proto=http \
            file://add_vercmp.patch \
            file://add_uname_support.patch \
            file://fix_installorder.patch \
-           file://offline_postinstall.patch\
+           file://offline_postinstall.patch \
            file://offlineroot_varname.patch \
            file://track_parents.patch \
 "

@@ -22,7 +22,7 @@ S = "${WORKDIR}/trunk"
 
 SRCREV = "633"
 PV = "0.1.8+svnr${SRCPV}"
-PR = "r3"
+PR = "r4"
 
 PACKAGES =+ "libopkg${PKGSUFFIX}-dev libopkg${PKGSUFFIX} update-alternatives-cworth${PKGSUFFIX}"

Signature · 1 line

1.7.8

Enrico Scholz

2011-12-18 10:46 UTC #14 lore raw

In reply to Richard Purdie

Richard Purdie <[email protected]>

Quoted 5 lines · writes:

This is likely as a result of the installorder patch :/. Sadly if we want the postinstalls to be installed in order we do need that patch.
The question is whether circular depends are something opkg should support or not?

I think, circular dependencies should (and must) be supported. It is nearly impossible to avoid them and other package managers (rpm, dpkg) work fine with them.

Forbidding them would require a large rewrite of oe recipes; e.g. the autogenerated perl deps cause a circle leading to

| Installing perl-module-extutils-makemaker (5.14.2-r2) to root...
| Installing perl-module-extutils-my (5.14.2-r2) to root...
| Installing perl-module-extutils-mm (5.14.2-r2) to root...
| Installing perl-module-extutils-makemaker (5.14.2-r2) to root...
| Installing perl-module-extutils-my (5.14.2-r2) to root...
| Installing perl-module-extutils-mm (5.14.2-r2) to root...

loops.

Quoted 1 line

What's debian's behaviour in that regard?

afais, dpkg supports a 'Pre-Depends' field which breaks the dependency circles. rpm supports more finegrained 'Requires(preinst/postinst)' tags too.

Enrico