Skip to contentSkip to conversation

audit: fix signedness bug in audit_log_execve_info()

PATCH RESEND New Xi Wang 1 participant 1 message Dec 20, 2011 Audit

lore
Share & tools
lore

Xi Wang

author
#0 lore raw

PATCH RESEND 1/1 audit: fix signedness bug in audit_log_execve_info()

In the loop, a size_t "len" is used to hold the return value of audit_log_single_execve_arg(), which returns -1 on error. In that case the error handling (len <= 0) will be bypassed since "len" is unsigned, and the loop continues with (p += len) being wrapped. Change the type of "len" to signed int to fix the error handling.

	size_t len;
	...
	for (...) {
		len = audit_log_single_execve_arg(...);
		if (len <= 0)
			break;
		p += len;
	}
---
 kernel/auditsc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/auditsc.c +2 -2
index 47b7fc1..5b118d8 100644
@@ -1166,8 +1166,8 @@ static void audit_log_execve_info(struct audit_context *context,
 				  struct audit_buffer **ab,
 				  struct audit_aux_data_execve *axi)
 {
-	int i;
-	size_t len, len_sent = 0;
+	int i, len;
+	size_t len_sent = 0;
 	const char __user *p;
 	char *buf;
 
Signature · 1 line
1.7.5.4