Skip to contentSkip to conversation

drm/i915: Disable semaphores by default on SNB

PATCH In review Keith Packard 1 participant 2 messages Dec 23, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Disable semaphores by default on SNB

Semaphores still cause problems on some machines:

Quoted 10 lines

From Udo Steinberg:

With Linux-3.2-rc6 I'm frequently seeing GPU hangs when large amounts of text scroll in an xterm, such as when extracting a tar archive. Such as this one (note the timestamps):

I can reproduce it fairly easily with something
as simple as:

while true; do dmesg; done

This patch turns them off on SNB while leaving them on for IVB.

---
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/i915_gem_execbuffer.c +1 -1
index c681dc1..0d4d308 100644
@@ -758,7 +758,7 @@ intel_enable_semaphores(struct drm_device *dev)
 
 	/* Enable semaphores on SNB when IO remapping is off */
 	if (INTEL_INFO(dev)->gen == 6)
-		return !intel_iommu_enabled;
+		return 0;
 
 	return 1;
 }
Signature · 1 line
1.7.7.3
#1 lore raw
Quoted 1 line · Keith Packard

/* Enable semaphores on SNB when IO remapping is off */

Yeah, the comment is wrong now. I've updated this too:

- /* Enable semaphores on SNB when IO remapping is off */
+ /* Enable semaphores on SNB */

Signature · 1 line
[email protected]