Skip to contentSkip to conversation

iw: use a newer commit in the public git

PATCH In review Eyal Reizer 3 participants 3 messages Jan 5, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iw: use a newer commit in the public git

switch to use a newer commit in the public git

---
 recipes/iw/iw_git.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
recipes/iw/iw_git.bb +3 -3
index c98e1bc..f0dc7ff 100644
@@ -4,9 +4,9 @@ SECTION = "base"
 PRIORITY = "optional"
 LICENSE = "BSD"
 
-SRCREV = "0a236ef5f8e4ba7218aac7d0cdacf45673d5b35c"
-PR = "r0"
-PV = "0.9.22"
+SRCREV = "8b2b1c6a77ee17e4128b22845cb8c5901de296c9"
+PR = "r1"
+PV = "3.2"
 PR_append = "+gitr${SRCPV}"
 
 DEPENDS = "libnl pkgconfig"
Signature · 1 line
1.7.0.4
#1 lore raw

Dear Ayal,

Am Donnerstag, den 05.01.2012, 11:47 +0200 schrieb Eyal Reizer:

Quoted 1 line

switch to use a newer commit in the public git

That line is redundant to the commit summary. Why not use the following as the summary?

iw_git: Update to commit 8b2b1c6a (version 3.2)

Additionally please add if this just introduces new features or if it fixes any problems for you.

And lastly please add how you have tested the new version.

Quoted 10 lines
---
 recipes/iw/iw_git.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
recipes/iw/iw_git.bb +0 -0
index c98e1bc..f0dc7ff 100644

recipes/iw/iw_git.bb SECTION = "base" · line 10

Quoted 10 lines
recipes/iw/iw_git.bb +3 -3
@@ -4,9 +4,9 @@ SECTION = "base"
 PRIORITY = "optional"
 LICENSE = "BSD"
 
-SRCREV = "0a236ef5f8e4ba7218aac7d0cdacf45673d5b35c"
-PR = "r0"
-PV = "0.9.22"
+SRCREV = "8b2b1c6a77ee17e4128b22845cb8c5901de296c9"
+PR = "r1"
+PV = "3.2"
 PR_append = "+gitr${SRCPV}"

I always forget, if a PR bump for a version update is needed if we have PR_append${SRCPV}. Could you check that again, please.

recipes/iw/iw_git.bb SECTION = "base" · line 12

Quoted 1 line
recipes/iw/iw_git.bb +0 -0
 DEPENDS = "libnl pkgconfig"

Thanks,

Paul

#2 lore raw
Quoted 29 lines · Paul Menzel

Dear Ayal,

Am Donnerstag, den 05.01.2012, 11:47 +0200 schrieb Eyal Reizer:

Quoted 1 line

switch to use a newer commit in the public git

That line is redundant to the commit summary. Why not use the following as the summary?

iw_git: Update to commit 8b2b1c6a (version 3.2)

Additionally please add if this just introduces new features or if it fixes any problems for you.

And lastly please add how you have tested the new version.

Quoted 13 lines
---
 recipes/iw/iw_git.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
recipes/iw/iw_git.bb +0 -0
index c98e1bc..f0dc7ff 100644
@@ -4,9 +4,9 @@ SECTION = "base"
 PRIORITY = "optional"
 LICENSE = "BSD"
 
Quoted 10 lines

recipes/iw/iw_git.bb SECTION = "base" · line 10

Quoted 7 lines
recipes/iw/iw_git.bb +3 -3
-SRCREV = "0a236ef5f8e4ba7218aac7d0cdacf45673d5b35c"
-PR = "r0"
-PV = "0.9.22"
+SRCREV = "8b2b1c6a77ee17e4128b22845cb8c5901de296c9"
+PR = "r1"
+PV = "3.2"
 PR_append = "+gitr${SRCPV}"

I always forget, if a PR bump for a version update is needed if we have PR_append${SRCPV}. Could you check that again, please.

Actually, if the version (PV) is bumped, PR should go back to 0 or 1, ideally. Otherwise it's not needed to bump PR, when PV is increased.

Signature · 1 line
Denys